From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19930 invoked by alias); 22 Apr 2018 01:31:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19917 invoked by uid 89); 22 Apr 2018 01:31:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Attached, D*ca, reviewing X-HELO: mail-wr0-f179.google.com Received: from mail-wr0-f179.google.com (HELO mail-wr0-f179.google.com) (209.85.128.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Apr 2018 01:31:35 +0000 Received: by mail-wr0-f179.google.com with SMTP id p18-v6so12721761wrm.1 for ; Sat, 21 Apr 2018 18:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T64DGvZUuy9yGNN44DCGK73yuUPO81LeDKheeyrrN5s=; b=Vw4sQQAu4O/wZLNMKkdh9PDwb+j7iCsVKisHGbJStEOOLGVxc7XIT7eEJyzghs+wsX 5HrgfMGkOMuQA9pPDBF7LbPxeq5/nYhMOLE4vMrs88zlApg/WpzFWdUvCQoJKtiyjpQz 62DceHL2WoMpIQiW1N9v/lTxsvmenh0fyjd8frIbhwR5OwRrH2DXiwGh1GpGB9AzhrN8 bxBnnUd72aKJrHB7yIVPu+kqXoF9x8uHESG1SlXpiszU9fjJlHp/U/Oh+fq7al4V70Cc sNzSdj2K4/cjRbHTCv5595C+fq/kQXFoL0VB9hF8rRi/OfC6+1mMNPjGT1f0qp0+wy0e Mwyw== X-Gm-Message-State: ALQs6tDbOEud4Jj8R85H5iGotKsnKLJ8a180SnMkM3KA5qYVSSBboqHG wPrWEiFcFY4AOkc5AETLEjSLvhz8bKN53vGPb4o= X-Google-Smtp-Source: AIpwx48CkuflBJ9oH8Qr36B3JUJJZ0TQCp3hzq57/9kvkd2CyrBm3Qc8zc1SoNivU+h5Lwq2xMR8XqTSXE88SNGgXlQ= X-Received: by 10.28.32.132 with SMTP id g126mr6162649wmg.52.1524360692776; Sat, 21 Apr 2018 18:31:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.165.130 with HTTP; Sat, 21 Apr 2018 18:31:31 -0700 (PDT) In-Reply-To: <0eae05d2f22d863db5b7b5b890a76a4a@polymtl.ca> References: <0eae05d2f22d863db5b7b5b890a76a4a@polymtl.ca> From: Rajendra SY Date: Sun, 22 Apr 2018 01:31:00 -0000 Message-ID: Subject: Re: [PATCH] [PR gdb/23095] Fixed test case to compile & run on FreeBSD To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="001a113d58b69a78e9056a65e171" X-SW-Source: 2018-04/txt/msg00432.txt.bz2 --001a113d58b69a78e9056a65e171 Content-Type: text/plain; charset="UTF-8" Content-length: 1366 Simon, Thanks for reviewing the patch. Attached updated patch. Thanks Rajendra On Sat, Apr 21, 2018 at 8:29 PM, Simon Marchi wrote: > On 2018-04-20 23:10, Rajendra SY wrote: >> >> Problems: >> 1. linking -dl lib on FreeBSD platform >> 2. backtrace from ld-elf shows r_debug_state() instead of >> _dl_debug_state() >> >> Cause: >> 1. There is no dl library on FreeBSD platform test has to ignore linking >> "-ldl" >> 2. The stop due to a shared library event shows backtrace frame #0 >> function as r_debug_state() >> >> Test passed: >> PASS: gdb.base/break-probes.exp: set stop-on-solib-events 1 >> >> gdb/ChangeLog: >> 2018-04-20 Rajendra SY >> >> PR gdb/23095 >> * gdb/testsuite/gdb.base/break-probes.exp: > > > Hi Rajendra, > > Instead of conditionally adding -ldl in the test, it would be better to pass > the "shlib_load" options to prepare_for_testing. It will add the right flag > depending on the platform. > > It is handled here, from what I see it already considers freebsd: > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/testsuite/lib/gdb.exp;h=4d48f5e3ad39967bba3ecf8cad5da5ea87f355c8;hb=HEAD#l3593 > > Can you try that? > > The other part of the change (r_debug_state) is probably fine to keep there, > because it's very specific to this test. > > Simon --001a113d58b69a78e9056a65e171 Content-Type: application/octet-stream; name="gdb-break-probes.diff" Content-Disposition: attachment; filename="gdb-break-probes.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jga4t6o20 Content-length: 1233 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvYnJlYWstcHJv YmVzLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvYnJlYWstcHJvYmVz LmV4cAppbmRleCAyMmFhNjYxNzFjLi42NjRiOTExZmRmIDEwMDY0NAotLS0g YS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2JyZWFrLXByb2Jlcy5leHAKKysr IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9icmVhay1wcm9iZXMuZXhwCkBA IC0yMyw3ICsyMywxMSBAQCBzZXQgbGlibmFtZSAkdGVzdGZpbGUtc29saWIK IHNldCBzcmNmaWxlX2xpYiAkc3JjZGlyLyRzdWJkaXIvJGxpYm5hbWUuYwog c2V0IGJpbmZpbGVfbGliIFtzdGFuZGFyZF9vdXRwdXRfZmlsZSAkbGlibmFt ZS5zb10KIAotc2V0IG5vcm1hbF9icCAiX2RsX2RlYnVnX3N0YXRlIgoraWYg eyBbaXN0YXJnZXQgIipic2QqIl0gfSB7CisgIHNldCBub3JtYWxfYnAgInJf ZGVidWdfc3RhdGUiCit9IGVsc2UgeworICBzZXQgbm9ybWFsX2JwICJfZGxf ZGVidWdfc3RhdGUiCit9CiBzZXQgcHJvYmVzX2JwICJkbF9tYWluIgogCiBp ZiB7IFtnZGJfY29tcGlsZV9zaGxpYiAkc3JjZmlsZV9saWIgJGJpbmZpbGVf bGliIFwKQEAgLTMzLDcgKzM3LDcgQEAgaWYgeyBbZ2RiX2NvbXBpbGVfc2hs aWIgJHNyY2ZpbGVfbGliICRiaW5maWxlX2xpYiBcCiB9CiAKIGlmIHsgW3By ZXBhcmVfZm9yX3Rlc3RpbmcgImZhaWxlZCB0byBwcmVwYXJlIiAkdGVzdGZp bGUgJHNyY2ZpbGUgXAotCSAgW2xpc3QgYWRkaXRpb25hbF9mbGFncz0tRFNI TElCX05BTUU9XCIkYmluZmlsZV9saWJcIiBsaWJzPS1sZGxdXSB9IHsKKwkg IFtsaXN0IGRlYnVnIHNobGliX2xvYWQgYWRkaXRpb25hbF9mbGFncz0tRFNI TElCX05BTUU9XCIkYmluZmlsZV9saWJcIl1dIH0gewogICAgIHJldHVybiAt MQogfQogCg== --001a113d58b69a78e9056a65e171--