From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107081 invoked by alias); 21 Nov 2018 14:50:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107064 invoked by uid 89); 21 Nov 2018 14:50:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,FROM_EXCESS_BASE64,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi1-f171.google.com Received: from mail-oi1-f171.google.com (HELO mail-oi1-f171.google.com) (209.85.167.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Nov 2018 14:50:03 +0000 Received: by mail-oi1-f171.google.com with SMTP id b141so4694525oii.12 for ; Wed, 21 Nov 2018 06:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=g50HVr3TOEt/hRe8ibnAiFGZn4iRMTdKL/9fOSCwCTo=; b=HPFdMuv687Zr4wKZDu7mV41xEn/hCLS1WylFiD5GusM4ysgI6gtJymbwuRPMppv+FG IgTgIMTtEl5npdQchcE4VXJ/5T0bEX1UJYzczuVMYiwlPmAXQy3M574egpk4NDfSzhe2 nNtWtoHGra88fFTvcZvrNHBzozY2Jy7enfgiIdTuJIst339bBCDyMGVxzyoPCvNkjJIE dbRe34QJcteW6bXEkFf0W2MDqi6MwFdE/BAlhHkz2TQUWX6Mt/oR99MZ3FGkF0ZtUrJ4 +FPrvFEehEQcxuikrpeAgKUIlnLlTfI6zO60KEjQHcc1UZjUgYWzCDO6k9e/55YdVmcR khIA== MIME-Version: 1.0 From: =?UTF-8?B?QmVubm8gRsO8bmZzdMO8Y2s=?= Date: Wed, 21 Nov 2018 14:50:00 -0000 Message-ID: Subject: [PATCH][PR python/23714] Make command-repeat work after gdb.execute To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="000000000000645680057b2ddd24" X-SW-Source: 2018-11/txt/msg00356.txt.bz2 --000000000000645680057b2ddd24 Content-Type: text/plain; charset="UTF-8" Content-length: 858 Since commit 56bcdbea2bed ("Let gdb.execute handle multi-line commands") command repetition after using the `gdb.execute` Python function fails (the previous command is not repeated anymore). This happens because read_command_lines_1 sets dont_repeat, but the call to prevent_dont_repeat in execute_gdb_command is later. The fix is to move the call to prevent_dont_repeat to the beginning of the function. Tested on my laptop (ArchLinux-x86_64) gdb/ChangeLog: PR python/#23714 * gdb/python/python.c (execute_gdb_command): call prevent_dont_repeat earlier to avoid affecting dont_repeat gdb/testuite/ChangeLog: PR python/#23714 * gdb.python/python.exp: Test gdb.execute("show commands"). --- gdb/python/python.c | 3 ++- gdb/testsuite/gdb.python/python.exp | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) --000000000000645680057b2ddd24 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-python-Make-command-repeat-work-after-gdb.execute.patch" Content-Disposition: attachment; filename="0001-python-Make-command-repeat-work-after-gdb.execute.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jora9ncm0 Content-length: 3164 RnJvbSBhMTczYTFhNThjZjg0MjU0MGMwMWU4YTMwM2IzZjQ0MDQ1ZmRmZDRi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/QmVu bm89MjBGPUMzPUJDbmZzdD1DMz1CQ2NrPz0gPGJlbm5vLmZ1ZW5mc3R1ZWNr QGdtYWlsLmNvbT4KRGF0ZTogV2VkLCAyMSBOb3YgMjAxOCAxNToyODowMCAr MDEwMApTdWJqZWN0OiBbUEFUQ0hdIHB5dGhvbjogTWFrZSBjb21tYW5kLXJl cGVhdCB3b3JrIGFmdGVyIGdkYi5leGVjdXRlCgpTaW5jZSBjb21taXQKCiAg NTZiY2RiZWEyYmVkICgiTGV0IGdkYi5leGVjdXRlIGhhbmRsZSBtdWx0aS1s aW5lIGNvbW1hbmRzIikKCmNvbW1hbmQgcmVwZXRpdGlvbiBhZnRlciB1c2lu ZyB0aGUgYGdkYi5leGVjdXRlYCBQeXRob24gZnVuY3Rpb24KZmFpbHMgKHRo ZSBwcmV2aW91cyBjb21tYW5kIGlzIG5vdCByZXBlYXRlZCBhbnltb3JlKS4g VGhpcyBoYXBwZW5zCmJlY2F1c2UgcmVhZF9jb21tYW5kX2xpbmVzXzEgc2V0 cyBkb250X3JlcGVhdCwgYnV0IHRoZSBjYWxsIHRvCnByZXZlbnRfZG9udF9y ZXBlYXQgaW4gZXhlY3V0ZV9nZGJfY29tbWFuZCBpcyBsYXRlci4KClRoZSBm aXggaXMgdG8gbW92ZSB0aGUgY2FsbCB0byBwcmV2ZW50X2RvbnRfcmVwZWF0 IHRvIHRoZSBiZWdpbm5pbmcgb2YKdGhlIGZ1bmN0aW9uLgoKVGVzdGVkIG9u IG15IGxhcHRvcCAoQXJjaExpbnV4LXg4Nl82NCkKCmdkYi9DaGFuZ2VMb2c6 CgogICAgUFIgcHl0aG9uLyMyMzcxNAogICAgKiBnZGIvcHl0aG9uL3B5dGhv bi5jIChleGVjdXRlX2dkYl9jb21tYW5kKTogY2FsbCBwcmV2ZW50X2RvbnRf cmVwZWF0CiAgICBlYXJsaWVyIHRvIGF2b2lkIGFmZmVjdGluZyBkb250X3Jl cGVhdAoKZ2RiL3Rlc3R1aXRlL0NoYW5nZUxvZzoKCiAgICBQUiBweXRob24v IzIzNzE0CiAgICAqIGdkYi5weXRob24vcHl0aG9uLmV4cDogVGVzdCBnZGIu ZXhlY3V0ZSgic2hvdyBjb21tYW5kcyIpLgotLS0KIGdkYi9weXRob24vcHl0 aG9uLmMgICAgICAgICAgICAgICAgIHwgMyArKy0KIGdkYi90ZXN0c3VpdGUv Z2RiLnB5dGhvbi9weXRob24uZXhwIHwgMSArCiAyIGZpbGVzIGNoYW5nZWQs IDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L2dkYi9weXRob24vcHl0aG9uLmMgYi9nZGIvcHl0aG9uL3B5dGhvbi5jCmlu ZGV4IGEzN2VkMTBiY2YuLmQ2NDUzZTc4NmMgMTAwNjQ0Ci0tLSBhL2dkYi9w eXRob24vcHl0aG9uLmMKKysrIGIvZ2RiL3B5dGhvbi9weXRob24uYwpAQCAt NTgzLDYgKzU4Myw4IEBAIGV4ZWN1dGVfZ2RiX2NvbW1hbmQgKFB5T2JqZWN0 ICpzZWxmLCBQeU9iamVjdCAqYXJncywgUHlPYmplY3QgKmt3KQogCiAgIHN0 ZDo6c3RyaW5nIHRvX3N0cmluZ19yZXM7CiAKKyAgc2NvcGVkX3Jlc3RvcmUg cHJldmVudGVyID0gcHJldmVudF9kb250X3JlcGVhdCAoKTsKKwogICBUUlkK ICAgICB7CiAgICAgICBzdHJ1Y3QgaW50ZXJwICppbnRlcnA7CkBAIC02MTIs NyArNjE0LDYgQEAgZXhlY3V0ZV9nZGJfY29tbWFuZCAoUHlPYmplY3QgKnNl bGYsIFB5T2JqZWN0ICphcmdzLCBQeU9iamVjdCAqa3cpCiAJaW50ZXJwID0g aW50ZXJwX2xvb2t1cCAoY3VycmVudF91aSwgImNvbnNvbGUiKTsKIAljdXJy ZW50X3Vpb3V0ID0gaW50ZXJwLT5pbnRlcnBfdWlfb3V0ICgpOwogCi0Jc2Nv cGVkX3Jlc3RvcmUgcHJldmVudGVyID0gcHJldmVudF9kb250X3JlcGVhdCAo KTsKIAlpZiAodG9fc3RyaW5nKQogCSAgdG9fc3RyaW5nX3JlcyA9IGV4ZWN1 dGVfY29udHJvbF9jb21tYW5kc190b19zdHJpbmcgKGxpbmVzLmdldCAoKSwK IAkJCQkJCQkgICAgICBmcm9tX3R0eSk7CmRpZmYgLS1naXQgYS9nZGIvdGVz dHN1aXRlL2dkYi5weXRob24vcHl0aG9uLmV4cCBiL2dkYi90ZXN0c3VpdGUv Z2RiLnB5dGhvbi9weXRob24uZXhwCmluZGV4IDA3MjM1MDdhZjMuLmNiNzZh MGY4ZTYgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9w eXRob24uZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weXRo b24uZXhwCkBAIC0xMjEsNiArMTIxLDcgQEAgZ2RiX3Rlc3QgInB5dGhvbiBw cmludCAoeCkiICIyMyIKIAogZ2RiX3Rlc3QgInB5dGhvbiBnZGIuZXhlY3V0 ZSgnZWNobyAyXFxuZWNobyAzXFxcXG5cXG4nKSIgIjIzIiBcCiAgICAgIm11 bHRpLWxpbmUgZXhlY3V0ZSIKK2dkYl90ZXN0ICIgIiAiMjMiICJ0ZXN0IHRo YXQgZ2RiLmV4ZWN1dGUgZG9lcyBub3QgYWZmZWN0IHJlcGVhdCBoaXN0b3J5 IgogCiAjIFRlc3QgcG9zdF9ldmVudC4KIGdkYl9weV90ZXN0X211bHRpcGxl ICJwb3N0IGV2ZW50IGluc2VydGlvbiIgXAotLSAKMi4xOS4xCgo= --000000000000645680057b2ddd24--