From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29063 invoked by alias); 22 Jul 2011 17:19:02 -0000 Received: (qmail 28664 invoked by uid 22791); 22 Jul 2011 17:19:00 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Jul 2011 17:18:39 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id p6MHIbv9006014 for ; Fri, 22 Jul 2011 10:18:38 -0700 Received: from ywa12 (ywa12.prod.google.com [10.192.1.12]) by kpbe11.cbf.corp.google.com with ESMTP id p6MHI5PF019457 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 22 Jul 2011 10:18:36 -0700 Received: by ywa12 with SMTP id 12so1586349ywa.20 for ; Fri, 22 Jul 2011 10:18:36 -0700 (PDT) Received: by 10.150.95.12 with SMTP id s12mr2140770ybb.373.1311355116111; Fri, 22 Jul 2011 10:18:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.48.15 with HTTP; Fri, 22 Jul 2011 10:18:06 -0700 (PDT) In-Reply-To: <201107201903.22754.pedro@codesourcery.com> References: <20110715205209.8B3B3190BC2@elbrus2.mtv.corp.google.com> <201107201735.13150.pedro@codesourcery.com> <201107201903.22754.pedro@codesourcery.com> From: Paul Pluzhnikov Date: Fri, 22 Jul 2011 17:27:00 -0000 Message-ID: Subject: Re: [RFC][patch] Avoid repeated calls to solib_add on initial attach. To: Pedro Alves Cc: gdb-patches@sourceware.org, Luis Machado Content-Type: multipart/mixed; boundary=000e0cd6a9cedec60504a8aba798 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00631.txt.bz2 --000e0cd6a9cedec60504a8aba798 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 593 On Wed, Jul 20, 2011 at 11:03 AM, Pedro Alves wrote: > (Meant to say before but forgot... the DSO list is per > program space, not inferior -- you should move the > counter to struct program_space) Thanks for comments. Revised patch attached. Tested on Linux/x86_64 with no regressions. -- Paul Pluzhnikov 2011-07-22 Paul Pluzhnikov * progspace.h (struct program_space): Add solib_add_generation. * infcmd.c (post_create_inferior): Only call solib_add if not already done. * solib.c (solib_add): Increment solib_add_generation. --000e0cd6a9cedec60504a8aba798 Content-Type: text/plain; charset=US-ASCII; name="gdb-suppress-repeated-solib-add-20110722.txt" Content-Disposition: attachment; filename="gdb-suppress-repeated-solib-add-20110722.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gqfeksfy0 Content-length: 4421 SW5kZXg6IHByb2dzcGFjZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvcHJvZ3NwYWNlLmgsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNwpkaWZmIC11IC1wIC1yMS43IHByb2dzcGFjZS5o Ci0tLSBwcm9nc3BhY2UuaAkxMCBKYW4gMjAxMSAyMDozODo1MCAtMDAwMAkx LjcKKysrIHByb2dzcGFjZS5oCTIyIEp1bCAyMDExIDE3OjAzOjA3IC0wMDAw CkBAIC0xODUsNiArMTg1LDkgQEAgc3RydWN0IHByb2dyYW1fc3BhY2UKICAg ICAgICBzb2xpYi5jLiAgKi8KICAgICBzdHJ1Y3Qgc29fbGlzdCAqc29fbGlz dDsKIAorICAgIC8qIE51bWJlciBvZiBjYWxscyB0byBzb2xpYl9hZGQuICAq LworICAgIHVuc2lnbmVkIHNvbGliX2FkZF9nZW5lcmF0aW9uOworCiAgICAg LyogUGVyIHBzcGFjZSBkYXRhLXBvaW50ZXJzIHJlcXVpcmVkIGJ5IG90aGVy IEdEQiBtb2R1bGVzLiAgKi8KICAgICB2b2lkICoqZGF0YTsKICAgICB1bnNp Z25lZCBudW1fZGF0YTsKSW5kZXg6IGluZmNtZC5jCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvaW5mY21kLmMs dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjg3CmRpZmYgLXUgLXAgLXIxLjI4 NyBpbmZjbWQuYwotLS0gaW5mY21kLmMJMzAgTWF5IDIwMTEgMTg6MDQ6MzIg LTAwMDAJMS4yODcKKysrIGluZmNtZC5jCTIyIEp1bCAyMDExIDE3OjAzOjA3 IC0wMDAwCkBAIC00MjEsNiArNDIxLDkgQEAgcG9zdF9jcmVhdGVfaW5mZXJp b3IgKHN0cnVjdCB0YXJnZXRfb3BzIAogCiAgIGlmIChleGVjX2JmZCkKICAg ICB7CisgICAgICBjb25zdCB1bnNpZ25lZCBzb2xpYl9hZGRfZ2VuZXJhdGlv bgorCT0gY3VycmVudF9wcm9ncmFtX3NwYWNlLT5zb2xpYl9hZGRfZ2VuZXJh dGlvbjsKKwogICAgICAgLyogQ3JlYXRlIHRoZSBob29rcyB0byBoYW5kbGUg c2hhcmVkIGxpYnJhcnkgbG9hZCBhbmQgdW5sb2FkCiAJIGV2ZW50cy4gICov CiAjaWZkZWYgU09MSUJfQ1JFQVRFX0lORkVSSU9SX0hPT0sKQEAgLTQyOCwy NCArNDMxLDI5IEBAIHBvc3RfY3JlYXRlX2luZmVyaW9yIChzdHJ1Y3QgdGFy Z2V0X29wcyAKICNlbHNlCiAgICAgICBzb2xpYl9jcmVhdGVfaW5mZXJpb3Jf aG9vayAoZnJvbV90dHkpOwogI2VuZGlmCi0gICAgfQotCi0gIC8qIElmIHRo ZSBzb2xpc3QgaXMgZ2xvYmFsIGFjcm9zcyBwcm9jZXNzZXMsIHRoZXJlJ3Mg bm8gbmVlZCB0bwotICAgICByZWZldGNoIGl0IGhlcmUuICAqLwotICBpZiAo ZXhlY19iZmQgJiYgIWdkYmFyY2hfaGFzX2dsb2JhbF9zb2xpc3QgKHRhcmdl dF9nZGJhcmNoKSkKLSAgICB7Ci0gICAgICAvKiBTb21ldGltZXMgdGhlIHBs YXRmb3JtLXNwZWNpZmljIGhvb2sgbG9hZHMgaW5pdGlhbCBzaGFyZWQKLQkg bGlicmFyaWVzLCBhbmQgc29tZXRpbWVzIGl0IGRvZXNuJ3QuICBJZiBpdCBk b2Vzbid0IEZST01fVFRZIHdpbGwgYmUKLQkgaW5jb3JyZWN0bHkgMCBidXQg c3VjaCBzb2xpYiB0YXJnZXRzIHNob3VsZCBiZSBmaXhlZCBhbnl3YXkuICBJ ZiB3ZQotCSBtYWRlIGFsbCB0aGUgaW5mZXJpb3IgaG9vayBtZXRob2RzIGNv bnNpc3RlbnQsIHRoaXMgY2FsbCBjb3VsZCBiZQotCSByZW1vdmVkLiAgQ2Fs bCBpdCBvbmx5IGFmdGVyIHRoZSBzb2xpYiB0YXJnZXQgaGFzIGJlZW4gaW5p dGlhbGl6ZWQgYnkKLQkgc29saWJfY3JlYXRlX2luZmVyaW9yX2hvb2suICAq LwogCisgICAgICBpZiAoY3VycmVudF9wcm9ncmFtX3NwYWNlLT5zb2xpYl9h ZGRfZ2VuZXJhdGlvbiA9PSBzb2xpYl9hZGRfZ2VuZXJhdGlvbikKKwl7CisJ ICAvKiBUaGUgcGxhdGZvcm0tc3BlY2lmaWMgaG9vayBzaG91bGQgbG9hZCBp bml0aWFsIHNoYXJlZCBsaWJyYXJpZXMsCisJICAgICBidXQgZGlkbid0LiAg RlJPTV9UVFkgd2lsbCBiZSBpbmNvcnJlY3RseSAwIGJ1dCBzdWNoIHNvbGli CisJICAgICB0YXJnZXRzIHNob3VsZCBiZSBmaXhlZCBhbnl3YXkuICBDYWxs IGl0IG9ubHkgYWZ0ZXIgdGhlIHNvbGliCisJICAgICB0YXJnZXQgaGFzIGJl ZW4gaW5pdGlhbGl6ZWQgYnkgc29saWJfY3JlYXRlX2luZmVyaW9yX2hvb2su ICAqLworCisJICBpZiAoaW5mb192ZXJib3NlKQorCSAgICB3YXJuaW5nIChf KCJwbGF0Zm9ybS1zcGVjaWZpYyBzb2xpYl9jcmVhdGVfaW5mZXJpb3JfaG9v ayBkaWQgIgorCQkgICAgICAgIm5vdCBsb2FkIGluaXRpYWwgc2hhcmVkIGxp YnJhcmllcy4iKSk7CisKKwkgIC8qIElmIHRoZSBzb2xpc3QgaXMgZ2xvYmFs IGFjcm9zcyBwcm9jZXNzZXMsIHRoZXJlJ3Mgbm8gbmVlZCB0bworCSAgICAg cmVmZXRjaCBpdCBoZXJlLiAgKi8KKwkgIGlmICghZ2RiYXJjaF9oYXNfZ2xv YmFsX3NvbGlzdCAodGFyZ2V0X2dkYmFyY2gpKQorCSAgICB7CiAjaWZkZWYg U09MSUJfQURECi0gICAgICBTT0xJQl9BREQgKE5VTEwsIDAsIHRhcmdldCwg YXV0b19zb2xpYl9hZGQpOworCSAgICAgIFNPTElCX0FERCAoTlVMTCwgMCwg dGFyZ2V0LCBhdXRvX3NvbGliX2FkZCk7CiAjZWxzZQotICAgICAgc29saWJf YWRkIChOVUxMLCAwLCB0YXJnZXQsIGF1dG9fc29saWJfYWRkKTsKKwkgICAg ICBzb2xpYl9hZGQgKE5VTEwsIDAsIHRhcmdldCwgYXV0b19zb2xpYl9hZGQp OwogI2VuZGlmCisJICAgIH0KKwl9CiAgICAgfQogCiAgIC8qIElmIHRoZSB1 c2VyIHNldHMgd2F0Y2hwb2ludHMgYmVmb3JlIGV4ZWN1dGlvbiBoYXZpbmcg c3RhcnRlZCwKSW5kZXg6IHNvbGliLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9zb2xpYi5jLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjE0OQpkaWZmIC11IC1wIC1yMS4xNDkgc29saWIu YwotLS0gc29saWIuYwkzMCBKdW4gMjAxMSAxOToyOTo1NCAtMDAwMAkxLjE0 OQorKysgc29saWIuYwkyMiBKdWwgMjAxMSAxNzowMzowNyAtMDAwMApAQCAt OTE0LDYgKzkxNCw4IEBAIHNvbGliX2FkZCAoY2hhciAqcGF0dGVybiwgaW50 IGZyb21fdHR5LAogewogICBzdHJ1Y3Qgc29fbGlzdCAqZ2RiOwogCisgIGN1 cnJlbnRfcHJvZ3JhbV9zcGFjZS0+c29saWJfYWRkX2dlbmVyYXRpb24rKzsK KwogICBpZiAocGF0dGVybikKICAgICB7CiAgICAgICBjaGFyICpyZV9lcnIg PSByZV9jb21wIChwYXR0ZXJuKTsK --000e0cd6a9cedec60504a8aba798--