From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1872 invoked by alias); 6 Jul 2011 17:04:09 -0000 Received: (qmail 1864 invoked by uid 22791); 6 Jul 2011 17:04:08 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 17:03:46 +0000 Received: from kpbe13.cbf.corp.google.com (kpbe13.cbf.corp.google.com [172.25.105.77]) by smtp-out.google.com with ESMTP id p66H3jed024153 for ; Wed, 6 Jul 2011 10:03:45 -0700 Received: from yxp4 (yxp4.prod.google.com [10.190.4.196]) by kpbe13.cbf.corp.google.com with ESMTP id p66H3hnq012582 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 6 Jul 2011 10:03:44 -0700 Received: by yxp4 with SMTP id 4so96326yxp.17 for ; Wed, 06 Jul 2011 10:03:43 -0700 (PDT) Received: by 10.151.87.14 with SMTP id p14mr56490ybl.145.1309971823141; Wed, 06 Jul 2011 10:03:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.7.14 with HTTP; Wed, 6 Jul 2011 10:03:13 -0700 (PDT) In-Reply-To: <20110706163219.GA31225@host1.jankratochvil.net> References: <4E0FAB8D.2070709@rawbw.com> <20110704214654.GA21844@host1.jankratochvil.net> <20110705170728.GY2407@adacore.com> <20110706105409.GA8840@host1.jankratochvil.net> <20110706160704.GC2407@adacore.com> <20110706163219.GA31225@host1.jankratochvil.net> From: Paul Pluzhnikov Date: Wed, 06 Jul 2011 17:12:00 -0000 Message-ID: Subject: Re: [patch,7.3] Fix JIT clang-lli gdb-7.3 regression To: Jan Kratochvil Cc: Joel Brobecker , gdb-patches@sourceware.org, Yuri , Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00202.txt.bz2 On Wed, Jul 6, 2011 at 9:32 AM, Jan Kratochvil wrote: > On Wed, 06 Jul 2011 18:07:04 +0200, Joel Brobecker wrote: >> > That is on unload+reload of the JIT engine. =A0OTOH (a) this case is p= robably >> > not faced by normal users and (b) it needs more work for better perfor= mance >> > and (c) in this case maybe the overall multi-JIT rework would be bette= r. >> >> So, would the following approach be acceptable? >> =A0 (1) HEAD: Apply Paul's patch, then look at solutions for >> =A0 =A0 =A0 the remaining failures/regressions... > > If Paul is going to implement the multi-JITer one as he was talking about. I am not sure there is an actual use case for that, and I was not planning on working on that. > Otherwise I would be for update by me of the very last patch of mine which > PASSed unload + reload as 739571cc3151651f49f7171cfd98275d983bfaaa^ did. Fixing the unload/reload case would (I expect) be fairly simple without reverting to a global -- just need to clear jit_inferior_data on unload. >> =A0 (2) BRANCH: Apply Paul's patch; I think we might want to apply >> =A0 =A0 =A0 the testcase part as well, even if we still need to figure o= ut >> =A0 =A0 =A0 why it doesn't work for Jan... Updated patch should work for Jan... Thanks, --=20 Paul Pluzhnikov