From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32273 invoked by alias); 19 Jul 2011 20:27:53 -0000 Received: (qmail 32264 invoked by uid 22791); 19 Jul 2011 20:27:53 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jul 2011 20:27:39 +0000 Received: from kpbe13.cbf.corp.google.com (kpbe13.cbf.corp.google.com [172.25.105.77]) by smtp-out.google.com with ESMTP id p6JKRZ3e008226 for ; Tue, 19 Jul 2011 13:27:36 -0700 Received: from gwb11 (gwb11.prod.google.com [10.200.2.11]) by kpbe13.cbf.corp.google.com with ESMTP id p6JKPvKJ007959 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 19 Jul 2011 13:27:34 -0700 Received: by gwb11 with SMTP id 11so185816gwb.20 for ; Tue, 19 Jul 2011 13:27:34 -0700 (PDT) Received: by 10.150.95.12 with SMTP id s12mr2650034ybb.373.1311107254322; Tue, 19 Jul 2011 13:27:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.48.15 with HTTP; Tue, 19 Jul 2011 13:27:04 -0700 (PDT) In-Reply-To: <201107191928.23553.pedro@codesourcery.com> References: <20110719174427.D9BC3190BC8@elbrus2.mtv.corp.google.com> <201107191928.23553.pedro@codesourcery.com> From: Paul Pluzhnikov Date: Tue, 19 Jul 2011 20:31:00 -0000 Message-ID: Subject: Re: [RFC][patch] Allow user to disable tracepoint support in gdbserver via command line To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00496.txt.bz2 On Tue, Jul 19, 2011 at 11:28 AM, Pedro Alves wrot= e: > Most of that querying is actually unnecessary. =A0All the symbols the > tracepoints module is looking up are required for libinproctrace.so to be > active. =A0So, there's no need to look them all up if any fails to be fou= nd, since > if any fails, we know we don't have libinproctrace.so loaded yet. =A0In p= ractice, > we end up doing one (tracepoint related) query per DSO only. =A0Can you g= ive the > patch below a try? =A0We have had this in our tree for months. =A0Hopeful= y it'll > still apply cleanly. It does apply cleanly, and does reduce the number of packets from 28*10 to just 10. Could you commit it? Thanks, --=20 Paul Pluzhnikov