From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80747 invoked by alias); 6 Sep 2019 04:17:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80730 invoked by uid 89); 6 Sep 2019 04:17:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=U*gdb-patches, gdbpatchessourcewareorg, sk:gdb-pat, gdb-patches@sourceware.org X-HELO: mail-ot1-f45.google.com Received: from mail-ot1-f45.google.com (HELO mail-ot1-f45.google.com) (209.85.210.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2019 04:17:15 +0000 Received: by mail-ot1-f45.google.com with SMTP id o101so4500842ota.8 for ; Thu, 05 Sep 2019 21:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RSQkUtF8bZClSIYqUfqwTYSZZgGbGQCKjnWNsIZQ4oM=; b=FggPq6L1iT8OAWR1qq3qFbBjukePdyf0HjkpEIkT1OHvlYwsIDbv2ckR+07BvT0j77 zc8acgAhhJAjN3WJIQ522hVucsgh0FIryXk3elb7LG3iXVlNwVjXJl5jzM7k1hhxOitI KKF0pUrsdmbfHuvnCAya6Pkw0Kv6P6bDIz5lufkkfZMCipFJ4kMEznAfGdaNvWn2gD8C yb47yR5CpSO1eu5S2a+T/UYFZEdWZOGe5ytkJB2IUG8CueyTpF/L4ZNsUwLJMyOviaez zdFedRX/lcNdn7i17z5XbpT33jHUGAw2vmO4mdPmZFCHebdD4P+VWsJKFbgpeJvGwVPE geTg== MIME-Version: 1.0 References: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> In-Reply-To: From: Eric Christopher Date: Fri, 06 Sep 2019 04:17:00 -0000 Message-ID: Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info To: Christian Biesinger Cc: Dave Blaikie , Douglas Evans , Pedro Alves , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00062.txt.bz2 https://bugs.llvm.org/show_bug.cgi?id=14500#c3 has the relevant information :) On Thu, Sep 5, 2019, 7:48 PM Christian Biesinger via gdb-patches < gdb-patches@sourceware.org> wrote: > On Thu, Sep 5, 2019 at 5:12 PM David Blaikie wrote: > > > > Clang now supports labels - so I'd like to essentially revert this patch. > > Out of curiosity, when did clang get support for this? > > Christian > > > Is this OK? > > > > > > On Thu, Apr 24, 2014 at 8:23 PM David Blaikie > wrote: > > > > > > On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans wrote: > > > > David Blaikie writes: > > > > > Clang doesn't emit debug info for labels (Clang PR14500). XFAIL a > > > > > bunch of GDB tests that rely on debug info for labels. > > > > > > > > > > For some reason gdb.linespec/ls-expr.exp gathered all tests into a > > > > > dictionary and then ran them. This made it hard to XFAIL just the > > > > > right tests. I refactored this to execute the tests directly, > removing > > > > > the dictionary so I could XFAIL the right tests. Is there a > reason it > > > > > would've been written that way? Does my patch break it in some > way? > > > > > commit c438cb16b63292e415330f289616c4e4ecece63c > > > > > Author: David Blaikie > > > > > Date: Sun Apr 13 11:42:02 2014 -0700 > > > > > > > > > > XFAIL under Clang tests using labels > > > > > > > > > > gdb/testsuite/ > > > > > * gdb.base/label.exp: XFAIL label related tests under Clang. > > > > > * gdb.cp/cplabel.exp: Ditto. > > > > > * gdb.linespec/ls-errs.exp: Refactor tests to execute > directly > > > > > and XFAIL under Clang those using labels. > > > > > > > > LGTM > > > > > > > > > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog > > > > > index 730c116..b04b940 100644 > > > > > --- gdb/testsuite/ChangeLog > > > > > +++ gdb/testsuite/ChangeLog > > > > > @@ -1,3 +1,9 @@ > > > > > +2014-04-12 David Blaikie > > > > > + > > > > > + * gdb.base/label.exp: XFAIL label related tests under > Clang. > > > > > + * gdb.cp/cplabel.exp: Ditto. > > > > > + * gdb.linespec/ls-errs.exp: Refactor tests to execute > directly and XFAIL under Clang those using labels. > > > > > + > > > > > > > > Nit: space vs tabs. Just use tabs. > > > > Plus line is longer than 80 chars. > > > > > > Thanks for the catches - fixed those up and committed in > > > c2e827ad5340fcf1735df6c77cb0311e56b985ef. > > > > > > Also refactored some of the xfails along the lines of what Pedro > > > suggested in the one test case that had several similar failures > > > (gdb.base/label.exp). If/when we fix this in Clang it might be worth > > > refactoring into a common function (though I'm personally not very > > > vested in keeping the test suite usable with anything other than ToT > > > Clang - perhaps others are). >