From: Eric Christopher <echristo@gmail.com>
To: Mark Wielaard <mjw@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] DWARFv5. Handle DW_TAG_atomic_type _Atomic type modifier.
Date: Mon, 23 Jun 2014 18:01:00 -0000 [thread overview]
Message-ID: <CALehDX4kij8kK1zaYGrMQJPLQSs8KdntAmeyWkyQvcsVJytd2w@mail.gmail.com> (raw)
In-Reply-To: <1403543197.3970.49.camel@bordewijk.wildebeest.org>
> It is certainly reasonable to add new vendor attributes or tags, but
> only for "independent" tags or attributes that consumers can easily
> ignore if they aren't recognized. There is no mechanism for introducing
> new vendor type qualifier tags like these in DWARF. The issue is that a
> consumer cannot detect that a tag is just a type qualifier which can be
> ignored if not recognized (all type qualifiers do use DW_AT_type to
> point to the underlying type, but so do other non-qualifier tags that
> have completely different semantics). So if we would add a vendor tag
> and GCC starts annotating/wrapping other type tags with
> DW_TAG_GNU_atomic_type then consumers will start failing to find the
> underlying type (I already had to patch up various consumers when I
> added DW_TAG_restrict_type, which has been standard since DWARFv3). So
> if we would introduce a vendor extension to mark atomic types, then it
> would have to work differently from the proposed type qualifier tag.
>
FWIW a new vendor tag, even for such as this, would be a better
solution. The numbers you choose for any attributes, if the proposals
are accepted, would not necessarily be the same ones you chose. That
confusion between numbers in consumers is worse than an unknown tag
IMO.
-eric
next prev parent reply other threads:[~2014-06-23 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 10:25 Mark Wielaard
2014-06-23 16:27 ` Tom Tromey
2014-06-23 17:07 ` Mark Wielaard
2014-06-23 17:48 ` Pedro Alves
2014-06-23 18:00 ` Tom Tromey
2014-06-23 18:01 ` Eric Christopher [this message]
2014-06-23 21:34 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALehDX4kij8kK1zaYGrMQJPLQSs8KdntAmeyWkyQvcsVJytd2w@mail.gmail.com \
--to=echristo@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mjw@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox