From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc44.google.com (mail-oo1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by sourceware.org (Postfix) with ESMTPS id 02B7E3857C58 for ; Thu, 16 Jul 2020 21:17:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 02B7E3857C58 Received: by mail-oo1-xc44.google.com with SMTP id o36so1455854ooi.11 for ; Thu, 16 Jul 2020 14:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iNV8tQACspr6+4anshYL5vdPJTGZCVwdsVhWNjnwC8g=; b=uJ5k6r0Zy4En8P0oXRcB3RovTW9fifpNQ3qc4hrvSN1DNO1kCMonp6OkoM5S9qy5im c0ovS6E9k8G2bz8wI3biRZO6SjIi8L/UWAL6KV8tu3f2JnQq9JXNZfbJEBdjwh1XAX67 bwbF55DCgMs4G+1OQEN3zELq9/AK6o67J87VTsQp8bYoaeqYcmgH5eJFVjS46BYMLQH0 IWLtCkOAzm9zZsNgVJjh+kfBzuefaP/zG5opDjB/BKmSjiubBnogHJQ7H2K0v+x/tEpX rO5DiDFiq44Yn9lMLORmJo7gOqRInovYFd18hYXY14IEAqcIIf85VehwHBB8+rkJJOHB n9hg== X-Gm-Message-State: AOAM5317dPIzenbA6dVpoVUABasD4Pp+MsPXA6OQrhmQmLhfOGwoP+bt uSwPimGIti1P7J59CXSUeCUfM3fkjU5GC+19vxk= X-Google-Smtp-Source: ABdhPJzposinkDjkCF7gZHjz2MZAgWA7K0Ql+9ABeGPi8qZgJ/AHR+pDdZMa68DnDm0xr4pLoAGr8uHhAB0rgDYR//E= X-Received: by 2002:a4a:b006:: with SMTP id f6mr5982160oon.13.1594934222378; Thu, 16 Jul 2020 14:17:02 -0700 (PDT) MIME-Version: 1.0 References: <87ft9rmd7c.fsf@tromey.com> In-Reply-To: From: Eric Christopher Date: Thu, 16 Jul 2020 14:16:46 -0700 Message-ID: Subject: Re: [PATCH] Update testsuite mechanism to allow object files as source files. To: Caroline Tice Cc: Tom Tromey , Eric Christopher , Simon Marchi , Caroline Tice via Gdb-patches , Joseph Myers X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2020 21:17:04 -0000 Should be just gas in the binutils-gdb checkout? -eric On Thu, Jul 16, 2020 at 2:10 PM Caroline Tice via Gdb-patches < gdb-patches@sourceware.org> wrote: > Has the DWARF assembler in the GDB testsuite been updated to handle > DWARF v5? Or can it handle that automatically? Is there a good > example I can look at to see how to use it? > > -- Caroline > cmtice@google.com > > On Thu, Jul 16, 2020 at 1:12 PM Tom Tromey wrote: > > > > Joseph> On general free software and reproducible builds principles: > > Joseph> * The source for any checked-in object file should be checked in. > > Joseph> * That source should include comments giving all information > required to > > Joseph> be able to reproduce the object file byte-for-byte > > > > In the past we tried this kind of thing, by taking the assembly > > generated by the compiler, then editing it and checking it in. > > > > However, IMO, this turned out to be a pain. The hand editing was often > > not sufficiently documented, and the tests were still > > architecture-dependent. Once or twice I think someone has had to edit > > the .S file later, which is error-prone. Also, the earliest test suite > > additions like this didn't include the original source, making this > > harder to handle. > > > > The "DWARF assembler" in the test suite avoids all this, at least for > > tests that require particular debuginfo. The main drawbacks of this > > approach are (again IMO) that sometimes it's a pain to write the DWARF > > by hand, and that sometimes the assembler framework itself needs > > upgrades before one can even begin. However, the tests are much more > > robust. > > > > I'd encourage the extension of the latter approach as much as possible. > > It isn't perfect but IME has been better on the whole. > > > > Tom >