From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2492 invoked by alias); 20 Sep 2013 05:02:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2479 invoked by uid 89); 20 Sep 2013 05:02:23 -0000 Received: from mail-vb0-f46.google.com (HELO mail-vb0-f46.google.com) (209.85.212.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 20 Sep 2013 05:02:23 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-vb0-f46.google.com Received: by mail-vb0-f46.google.com with SMTP id p13so7201883vbe.33 for ; Thu, 19 Sep 2013 22:02:20 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.52.119.228 with SMTP id kx4mr3817794vdb.12.1379653340851; Thu, 19 Sep 2013 22:02:20 -0700 (PDT) Received: by 10.220.121.198 with HTTP; Thu, 19 Sep 2013 22:02:20 -0700 (PDT) In-Reply-To: References: <87bo3rz790.fsf@fleche.redhat.com> Date: Fri, 20 Sep 2013 05:02:00 -0000 Message-ID: Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop. From: Alexey Makhalov To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=047d7bdc0a9c4b86a204e6c993a8 X-SW-Source: 2013-09/txt/msg00723.txt.bz2 --047d7bdc0a9c4b86a204e6c993a8 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 2709 Tom, thanks for advice. Now it works fine. Index: sim/common/sim-options.c =================================================================== RCS file: /cvs/src/src/sim/common/sim-options.c,v retrieving revision 1.31 diff -u -p -r1.31 sim-options.c --- sim/common/sim-options.c 3 Sep 2013 20:45:08 -0000 1.31 +++ sim/common/sim-options.c 20 Sep 2013 04:57:09 -0000 @@ -35,6 +35,7 @@ along with this program. If not, see wrote: > I'll try. > > > On Tue, Sep 17, 2013 at 10:29 AM, Tom Tromey wrote: >> >> >>>>> "Alexey" == Alexey Makhalov writes: >> >> Alexey> I've added checking for hash table overflow. It's better to have >> Alexey> internal error message instead of looping. >> >> Alexey> 2013-09-09 Alexey Makhalov >> Alexey> * sim-options.c (dup_arg_p) Check for hash table overflow. >> >> Is it possible to just use the libiberty hashtab code and not have it >> ever overflow? >> >> Tom > > --047d7bdc0a9c4b86a204e6c993a8 Content-Type: application/octet-stream; name="htab.patch" Content-Disposition: attachment; filename="htab.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hlsy1wgp0 Content-length: 2782 SW5kZXg6IHNpbS9jb21tb24vc2ltLW9wdGlvbnMuYwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvc2ltL2NvbW1vbi9z aW0tb3B0aW9ucy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMxCmRpZmYg LXUgLXAgLXIxLjMxIHNpbS1vcHRpb25zLmMKLS0tIHNpbS9jb21tb24vc2lt LW9wdGlvbnMuYwkzIFNlcCAyMDEzIDIwOjQ1OjA4IC0wMDAwCTEuMzEKKysr IHNpbS9jb21tb24vc2ltLW9wdGlvbnMuYwkyMCBTZXAgMjAxMyAwNDo1Nzow OSAtMDAwMApAQCAtMzUsNiArMzUsNyBAQCBhbG9uZyB3aXRoIHRoaXMgcHJv Z3JhbS4gIElmIG5vdCwgc2VlIDxoCiAjaW5jbHVkZSAic2ltLWFzc2VydC5o IgogCiAjaW5jbHVkZSAiYmZkLmgiCisjaW5jbHVkZSAiaGFzaHRhYi5oIgog CiAvKiBBZGQgYSBzZXQgb2Ygb3B0aW9ucyB0byB0aGUgc2ltdWxhdG9yLgog ICAgVEFCTEUgaXMgYW4gYXJyYXkgb2YgT1BUSU9OUyB0ZXJtaW5hdGVkIGJ5 IGEgTlVMTCBgb3B0Lm5hbWUnIGVudHJ5LgpAQCAtNDg1LDM3ICs0ODYsNDAg QEAgc3RhbmRhcmRfaW5zdGFsbCAoU0lNX0RFU0Mgc2QpCiAgIHJldHVybiBT SU1fUkNfT0s7CiB9CiAKKy8qIEEgc2ltcGxlIGNvbXBhcmlzb24gZnVuY3Rp b24gd2l0aCBvcHBvc2l0ZSBzZW1hbnRpY3MgdG8gc3RyY21wLiAgKi8KKwor c3RhdGljIGludAorc3RyZXEgKGNvbnN0IGNoYXIgKmxocywgY29uc3QgY2hh ciAqcmhzKQoreworICByZXR1cm4gIXN0cmNtcCAobGhzLCByaHMpOworfQor CiAvKiBSZXR1cm4gbm9uLXplcm8gaWYgYXJnIGlzIGEgZHVwbGljYXRlIGFy Z3VtZW50LgogICAgSWYgQVJHIGlzIE5VTEwsIGluaXRpYWxpemUuICAqLwog Ci0jZGVmaW5lIEFSR19IQVNIX1NJWkUgOTcKLSNkZWZpbmUgQVJHX0hBU0go YSkgKCgyNTYgKiAodW5zaWduZWQgY2hhcikgYVswXSArICh1bnNpZ25lZCBj aGFyKSBhWzFdKSAlIEFSR19IQVNIX1NJWkUpCisjZGVmaW5lIEFSR19IQVNI X1NJWkUgMjU2CiAKIHN0YXRpYyBpbnQKIGR1cF9hcmdfcCAoY29uc3QgY2hh ciAqYXJnKQogewotICBpbnQgaGFzaDsKLSAgc3RhdGljIGNvbnN0IGNoYXIg KiphcmdfdGFibGUgPSBOVUxMOworICB2b2lkICoqc2xvdDsKKyAgc3RhdGlj IGh0YWJfdCBhcmdfdGFibGUgPSBOVUxMOwogCiAgIGlmIChhcmcgPT0gTlVM TCkKICAgICB7CiAgICAgICBpZiAoYXJnX3RhYmxlID09IE5VTEwpCi0JYXJn X3RhYmxlID0gKGNvbnN0IGNoYXIgKiopIHhtYWxsb2MgKEFSR19IQVNIX1NJ WkUgKiBzaXplb2YgKGNoYXIgKikpOwotICAgICAgbWVtc2V0IChhcmdfdGFi bGUsIDAsIEFSR19IQVNIX1NJWkUgKiBzaXplb2YgKGNoYXIgKikpOworICAg ICAgICBhcmdfdGFibGUgPSBodGFiX2NyZWF0ZSAoQVJHX0hBU0hfU0laRSwg aHRhYl9oYXNoX3N0cmluZywgCisgICAgICAgICAgICAgICAoaW50ICgqKShj b25zdCB2b2lkICosIGNvbnN0IHZvaWQgKikpIHN0cmVxLCBmcmVlKTsKKyAg ICAgIGVsc2UKKyAgICAgICAgaHRhYl9lbXB0eSAoYXJnX3RhYmxlKTsKICAg ICAgIHJldHVybiAwOwogICAgIH0KIAotICBoYXNoID0gQVJHX0hBU0ggKGFy Zyk7Ci0gIHdoaWxlIChhcmdfdGFibGVbaGFzaF0gIT0gTlVMTCkKLSAgICB7 Ci0gICAgICBpZiAoc3RyY21wIChhcmcsIGFyZ190YWJsZVtoYXNoXSkgPT0g MCkKLQlyZXR1cm4gMTsKLSAgICAgIC8qIFdlIGFzc3VtZSB0aGVyZSB3b24n dCBiZSBtb3JlIHRoYW4gQVJHX0hBU0hfU0laRSBhcmd1bWVudHMgc28gd2UK LQkgZG9uJ3QgY2hlY2sgaWYgdGhlIHRhYmxlIGlzIGZ1bGwuICAqLwotICAg ICAgaWYgKCsraGFzaCA9PSBBUkdfSEFTSF9TSVpFKQotCWhhc2ggPSAwOwot ICAgIH0KLSAgYXJnX3RhYmxlW2hhc2hdID0gYXJnOworICBzbG90ID0gaHRh Yl9maW5kX3Nsb3QgKGFyZ190YWJsZSwgYXJnLCBJTlNFUlQpOworICBpZiAo KnNsb3QgIT0gTlVMTCkKKyAgICByZXR1cm4gMTsKKworICAqc2xvdCA9IHN0 cmR1cChhcmcpOwogICByZXR1cm4gMDsKIH0K --047d7bdc0a9c4b86a204e6c993a8--