From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20373 invoked by alias); 21 Sep 2013 02:59:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20360 invoked by uid 89); 21 Sep 2013 02:59:11 -0000 Received: from mail-vc0-f181.google.com (HELO mail-vc0-f181.google.com) (209.85.220.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 21 Sep 2013 02:59:11 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f181.google.com Received: by mail-vc0-f181.google.com with SMTP id hz10so848871vcb.26 for ; Fri, 20 Sep 2013 19:59:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.220.199.5 with SMTP id eq5mr9484023vcb.16.1379732348303; Fri, 20 Sep 2013 19:59:08 -0700 (PDT) Received: by 10.220.121.198 with HTTP; Fri, 20 Sep 2013 19:59:08 -0700 (PDT) In-Reply-To: <87k3ibqtxk.fsf@fleche.redhat.com> References: <87bo3rz790.fsf@fleche.redhat.com> <87k3ibqtxk.fsf@fleche.redhat.com> Date: Sat, 21 Sep 2013 02:59:00 -0000 Message-ID: Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop. From: Alexey Makhalov To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=047d7b5db26a81ae1304e6dbf8e7 X-SW-Source: 2013-09/txt/msg00785.txt.bz2 --047d7b5db26a81ae1304e6dbf8e7 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 2559 fixed Index: sim/common/sim-options.c =================================================================== RCS file: /cvs/src/src/sim/common/sim-options.c,v retrieving revision 1.31 diff -u -p -r1.31 sim-options.c --- sim/common/sim-options.c 3 Sep 2013 20:45:08 -0000 1.31 +++ sim/common/sim-options.c 21 Sep 2013 02:56:18 -0000 @@ -35,6 +35,7 @@ along with this program. If not, see wrote: >>>>>> "Alexey" == Alexey Makhalov writes: > > Alexey> + arg_table = htab_create (ARG_HASH_SIZE, htab_hash_string, > Alexey> + (int (*)(const void *, const void *)) streq, free); > > I think casts like this are better avoided. > Since streq is only used here, it is no trouble to just give it the > proper type. > > Alexey> + *slot = strdup(arg); > > The GNU coding style requires a space before the paren here. > > Tom --047d7b5db26a81ae1304e6dbf8e7 Content-Type: application/octet-stream; name="htab.patch" Content-Disposition: attachment; filename="htab.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hlu94y2t0 Content-length: 2745 SW5kZXg6IHNpbS9jb21tb24vc2ltLW9wdGlvbnMuYwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvc2ltL2NvbW1vbi9z aW0tb3B0aW9ucy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMxCmRpZmYg LXUgLXAgLXIxLjMxIHNpbS1vcHRpb25zLmMKLS0tIHNpbS9jb21tb24vc2lt LW9wdGlvbnMuYwkzIFNlcCAyMDEzIDIwOjQ1OjA4IC0wMDAwCTEuMzEKKysr IHNpbS9jb21tb24vc2ltLW9wdGlvbnMuYwkyMSBTZXAgMjAxMyAwMjo1Njox OCAtMDAwMApAQCAtMzUsNiArMzUsNyBAQCBhbG9uZyB3aXRoIHRoaXMgcHJv Z3JhbS4gIElmIG5vdCwgc2VlIDxoCiAjaW5jbHVkZSAic2ltLWFzc2VydC5o IgogCiAjaW5jbHVkZSAiYmZkLmgiCisjaW5jbHVkZSAiaGFzaHRhYi5oIgog CiAvKiBBZGQgYSBzZXQgb2Ygb3B0aW9ucyB0byB0aGUgc2ltdWxhdG9yLgog ICAgVEFCTEUgaXMgYW4gYXJyYXkgb2YgT1BUSU9OUyB0ZXJtaW5hdGVkIGJ5 IGEgTlVMTCBgb3B0Lm5hbWUnIGVudHJ5LgpAQCAtNDg1LDM3ICs0ODYsMzkg QEAgc3RhbmRhcmRfaW5zdGFsbCAoU0lNX0RFU0Mgc2QpCiAgIHJldHVybiBT SU1fUkNfT0s7CiB9CiAKKy8qIEEgc2ltcGxlIGNvbXBhcmlzb24gZnVuY3Rp b24gd2l0aCBvcHBvc2l0ZSBzZW1hbnRpY3MgdG8gc3RyY21wLiAgKi8KKwor c3RhdGljIGludAorc3RyZXEgKGNvbnN0IHZvaWQgKmxocywgY29uc3Qgdm9p ZCAqcmhzKQoreworICByZXR1cm4gIXN0cmNtcCAoKGNvbnN0IGNoYXIgKikg bGhzLCAoY29uc3QgY2hhciAqKSByaHMpOworfQorCiAvKiBSZXR1cm4gbm9u LXplcm8gaWYgYXJnIGlzIGEgZHVwbGljYXRlIGFyZ3VtZW50LgogICAgSWYg QVJHIGlzIE5VTEwsIGluaXRpYWxpemUuICAqLwogCi0jZGVmaW5lIEFSR19I QVNIX1NJWkUgOTcKLSNkZWZpbmUgQVJHX0hBU0goYSkgKCgyNTYgKiAodW5z aWduZWQgY2hhcikgYVswXSArICh1bnNpZ25lZCBjaGFyKSBhWzFdKSAlIEFS R19IQVNIX1NJWkUpCisjZGVmaW5lIEFSR19IQVNIX1NJWkUgMjU2CiAKIHN0 YXRpYyBpbnQKIGR1cF9hcmdfcCAoY29uc3QgY2hhciAqYXJnKQogewotICBp bnQgaGFzaDsKLSAgc3RhdGljIGNvbnN0IGNoYXIgKiphcmdfdGFibGUgPSBO VUxMOworICB2b2lkICoqc2xvdDsKKyAgc3RhdGljIGh0YWJfdCBhcmdfdGFi bGUgPSBOVUxMOwogCiAgIGlmIChhcmcgPT0gTlVMTCkKICAgICB7CiAgICAg ICBpZiAoYXJnX3RhYmxlID09IE5VTEwpCi0JYXJnX3RhYmxlID0gKGNvbnN0 IGNoYXIgKiopIHhtYWxsb2MgKEFSR19IQVNIX1NJWkUgKiBzaXplb2YgKGNo YXIgKikpOwotICAgICAgbWVtc2V0IChhcmdfdGFibGUsIDAsIEFSR19IQVNI X1NJWkUgKiBzaXplb2YgKGNoYXIgKikpOworICAgICAgICBhcmdfdGFibGUg PSBodGFiX2NyZWF0ZSAoQVJHX0hBU0hfU0laRSwgaHRhYl9oYXNoX3N0cmlu Zywgc3RyZXEsIGZyZWUpOworICAgICAgZWxzZQorCWh0YWJfZW1wdHkgKGFy Z190YWJsZSk7CiAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgaGFzaCA9 IEFSR19IQVNIIChhcmcpOwotICB3aGlsZSAoYXJnX3RhYmxlW2hhc2hdICE9 IE5VTEwpCi0gICAgewotICAgICAgaWYgKHN0cmNtcCAoYXJnLCBhcmdfdGFi bGVbaGFzaF0pID09IDApCi0JcmV0dXJuIDE7Ci0gICAgICAvKiBXZSBhc3N1 bWUgdGhlcmUgd29uJ3QgYmUgbW9yZSB0aGFuIEFSR19IQVNIX1NJWkUgYXJn dW1lbnRzIHNvIHdlCi0JIGRvbid0IGNoZWNrIGlmIHRoZSB0YWJsZSBpcyBm dWxsLiAgKi8KLSAgICAgIGlmICgrK2hhc2ggPT0gQVJHX0hBU0hfU0laRSkK LQloYXNoID0gMDsKLSAgICB9Ci0gIGFyZ190YWJsZVtoYXNoXSA9IGFyZzsK KyAgc2xvdCA9IGh0YWJfZmluZF9zbG90IChhcmdfdGFibGUsIGFyZywgSU5T RVJUKTsKKyAgaWYgKCpzbG90ICE9IE5VTEwpCisgICAgcmV0dXJuIDE7CisK KyAgKnNsb3QgPSBzdHJkdXAgKGFyZyk7CiAgIHJldHVybiAwOwogfQogCg== --047d7b5db26a81ae1304e6dbf8e7--