Re: [PATCH 07/11] [C++/mingw] Define __STDC_CONSTANT_MACROS / __STDC_LIMIT_MACROS for stdint.h

Pedro Alves
2015-11-03T14:07:02Z

On 11/03/2015 01:58 PM, Simon Marchi wrote:
> On 15-11-02 03:47 PM, Simon Marchi wrote:
>> FYI, I stumbled on the same problem when building for various architectures this weekend. I
>> generated some toolchains by using some of the Buildroot included configurations, which use
>> uclibc. I ended up defining those macros as well in CFLAGS. So that change can help for more
>> configurations than just mingw.
>
> Actually, would it be better to add ifndefs?
>
> #ifndef __STDC_CONSTANT_MACROS
> #define __STDC_CONSTANT_MACROS
> #endif
>
> (same for __STDC_LIMIT_MACROS)
>
> I tried to build the latest version of the branch, but since I had specified those in CFLAGS, I get:

Isn't this a case of "don't do that (CFLAGS), then" ?

If I update the gnulib patch per Paul's comment here:

https://lists.nongnu.org/archive/html/bug-gnulib/2015-11/msg00006.html

then __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS will be
unconditionally defined in config.h; I don't think defines
in config.h can be ifndefed.

Thanks,
Pedro Alves