From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23164 invoked by alias); 14 Mar 2017 02:13:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23067 invoked by uid 89); 14 Mar 2017 02:13:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=H*f:mfLAOusr, H*i:sk:c50f945, H*f:sk:c50f945, H*f:0CyBC X-HELO: mail-vk0-f43.google.com Received: from mail-vk0-f43.google.com (HELO mail-vk0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Mar 2017 02:13:07 +0000 Received: by mail-vk0-f43.google.com with SMTP id t8so45144755vke.3 for ; Mon, 13 Mar 2017 19:13:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oqbRO2dZaP8z+Gs/8KT0I5qZjqSggF9IxN9jb92pcU0=; b=aFWaToWrM6ZlTyMHat9w2PuUUyM0jm+LpkbDjQhCC7e2U70pcNWpLFs1Q5t+5Qnkws tKeziEXJmQlpEFVTbo8zhljqmL1k3YfN+8Yb7xKvnkOOSjAa9OlxQTIfMgLJ8w4Mc/N2 IX3jVwZBjkgJhLmKLZPWU3JxjxEQjaiP52X69PXuR60cOWRANTclTU0UFbOzfNeU7brG t2JMlxYH0RKxUQYfIkSp1vVfe0UsD/v2bF6+jdx087BHotCCGYWI3JmmGVLxawNSwYzY Wp1QsI8mAHb0xuhd1j5NxsDsSrJiV13mpkp6qZEMjTge+5/hhifGRkhO4tnjEoEyFb6v I9XA== X-Gm-Message-State: AMke39mZM0LH9R3PA891XePy/J0kKSsIuRC9eq5zgUdqSvHrjnlwnMQlOAx1WGhaCPCJM78gIii73xI3r75QLg== X-Received: by 10.31.59.197 with SMTP id i188mr13042485vka.45.1489457586525; Mon, 13 Mar 2017 19:13:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.102.68 with HTTP; Mon, 13 Mar 2017 19:12:46 -0700 (PDT) In-Reply-To: References: <630aafbb-8684-5aea-0fa1-f0f538b4eb02@ericsson.com> From: Gareth McMullin Date: Tue, 14 Mar 2017 02:13:00 -0000 Message-ID: Subject: Re: [PATCH] PR remote/21188: Fix remote serial timeout To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=001a1142f1785a8e1c054aa75e28 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00216.txt.bz2 --001a1142f1785a8e1c054aa75e28 Content-Type: text/plain; charset=UTF-8 Content-length: 410 On Tue, Mar 14, 2017 at 2:40 PM, Simon Marchi wrote: > Thanks for the updated patch. I just gave it a quick look, and it looks > good functionally. Just a little formatting issue. The four lines: > > else if (timeout_remaining < 0) > continue; > else > return SERIAL_TIMEOUT; > > should have one less indent (shift them two spaces to the left). Thank you. Corrected. --001a1142f1785a8e1c054aa75e28 Content-Type: text/x-patch; charset=US-ASCII; name="serial_timeout.patch" Content-Disposition: attachment; filename="serial_timeout.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j08wixaa0 Content-length: 3697 ZGlmZiAtLWdpdCBhL2dkYi9DaGFuZ2VMb2cgYi9nZGIvQ2hhbmdlTG9nCmlu ZGV4IDYwODUwMWIuLjExMWNmNGQgMTAwNjQ0Ci0tLSBhL2dkYi9DaGFuZ2VM b2cKKysrIGIvZ2RiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDkgQEAKKzIwMTct MDMtMTQgR2FyZXRoIE1jTXVsbGluICA8Z2FyZXRoQGJsYWNrc3BoZXJlLmNv Lm56PgorCisJUFIgcmVtb3RlLzIxMTg4CisJKiBzZXItdW5peC5jIChkb19o YXJkd2lyZV9yZWFkY2hhcik6IFdhaXQgZm9yIGZ1bGwgdGltZW91dCB0byBl bGFwc2UuCisJKiBzZXJpYWwuaCAoc2VyaWFsX3QpOiBSZW1vdmUgZmllbGRz IGN1cnJlbnRfdGltZW91dCBhbmQgdGltZW91dF9yZW1haW5pbmcuCisKIDIw MTctMDMtMTQgIFBlZHJvIEFsdmVzICA8cGFsdmVzQHJlZGhhdC5jb20+Cgog CSogY3AtbmFtZS1wYXJzZXIueSAoY3BfZGVtYW5nbGVkX25hbWVfdG9fY29t cCk6IFVwZGF0ZSBjb21tZW50LgpkaWZmIC0tZ2l0IGEvZ2RiL3Nlci11bml4 LmMgYi9nZGIvc2VyLXVuaXguYwppbmRleCBiOWU1NWYwLi43ZjczYWY4IDEw MDY0NAotLS0gYS9nZGIvc2VyLXVuaXguYworKysgYi9nZGIvc2VyLXVuaXgu YwpAQCAtNDQxLDggKzQ0MSw2IEBAIGhhcmR3aXJlX3JhdyAoc3RydWN0IHNl cmlhbCAqc2NiKQogICBzdGF0ZS5zZ3R0eWIuc2dfZmxhZ3MgJj0gfihDQlJF QUsgfCBFQ0hPKTsKICNlbmRpZgoKLSAgc2NiLT5jdXJyZW50X3RpbWVvdXQg PSAwOwotCiAgIGlmIChzZXRfdHR5X3N0YXRlIChzY2IsICZzdGF0ZSkpCiAg ICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkZXJyLCAic2V0X3R0eV9z dGF0ZSBmYWlsZWQ6ICVzXG4iLAogCQkJc2FmZV9zdHJlcnJvciAoZXJybm8p KTsKQEAgLTU0Niw5ICs1NDQsMjEgQEAgZG9faGFyZHdpcmVfcmVhZGNoYXIg KHN0cnVjdCBzZXJpYWwgKnNjYiwgaW50IHRpbWVvdXQpCiAgICAgICBpZiAo ZGV0YWNoKQogCXJldHVybiBTRVJJQUxfVElNRU9VVDsKCi0gICAgICBzY2It PnRpbWVvdXRfcmVtYWluaW5nID0gKHRpbWVvdXQgPCAwID8gdGltZW91dCA6 IHRpbWVvdXQgLSBkZWx0YSk7CisgICAgICBpbnQgdGltZW91dF9yZW1haW5p bmcgPSAodGltZW91dCA8IDAgPyB0aW1lb3V0IDogdGltZW91dCAtIGRlbHRh KTsKICAgICAgIHN0YXR1cyA9IHdhaXRfZm9yIChzY2IsIGRlbHRhKTsKCisg ICAgICBpZiAoc3RhdHVzID09IFNFUklBTF9USU1FT1VUKSB7CisJaWYgKHRp bWVvdXRfcmVtYWluaW5nID4gMCkKKwkgIHsKKwkgICAgdGltZW91dCA9IHRp bWVvdXRfcmVtYWluaW5nOworCSAgICBjb250aW51ZTsKKwkgIH0KKwllbHNl IGlmICh0aW1lb3V0X3JlbWFpbmluZyA8IDApCisJICBjb250aW51ZTsKKwll bHNlCisJICByZXR1cm4gU0VSSUFMX1RJTUVPVVQ7CisgICAgICB9CisKICAg ICAgIGlmIChzdGF0dXMgPCAwKQogCXJldHVybiBzdGF0dXM7CgpAQCAtNTU2 LDIxICs1NjYsNyBAQCBkb19oYXJkd2lyZV9yZWFkY2hhciAoc3RydWN0IHNl cmlhbCAqc2NiLCBpbnQgdGltZW91dCkKCiAgICAgICBpZiAoc3RhdHVzIDw9 IDApCiAJewotCSAgaWYgKHN0YXR1cyA9PSAwKQotCSAgICB7Ci0JICAgICAg LyogWmVybyBjaGFyYWN0ZXJzIG1lYW5zIHRpbWVvdXQgKGl0IGNvdWxkIGFs c28gYmUgRU9GLCBidXQKLQkgICAgICAgICB3ZSBkb24ndCAoeWV0IGF0IGxl YXN0KSBkaXN0aW5ndWlzaCkuICAqLwotCSAgICAgIGlmIChzY2ItPnRpbWVv dXRfcmVtYWluaW5nID4gMCkKLQkJewotCQkgIHRpbWVvdXQgPSBzY2ItPnRp bWVvdXRfcmVtYWluaW5nOwotCQkgIGNvbnRpbnVlOwotCQl9Ci0JICAgICAg ZWxzZSBpZiAoc2NiLT50aW1lb3V0X3JlbWFpbmluZyA8IDApCi0JCWNvbnRp bnVlOwotCSAgICAgIGVsc2UKLQkJcmV0dXJuIFNFUklBTF9USU1FT1VUOwot CSAgICB9Ci0JICBlbHNlIGlmIChlcnJubyA9PSBFSU5UUikKKwkgIGlmIChl cnJubyA9PSBFSU5UUikKIAkgICAgY29udGludWU7CiAJICBlbHNlCiAJICAg IHJldHVybiBTRVJJQUxfRVJST1I7CS8qIEdvdCBhbiBlcnJvciBmcm9tIHJl YWQuICAqLwpkaWZmIC0tZ2l0IGEvZ2RiL3NlcmlhbC5oIGIvZ2RiL3Nlcmlh bC5oCmluZGV4IGNmNGU2NTkuLjI5MDA1MDcgMTAwNjQ0Ci0tLSBhL2dkYi9z ZXJpYWwuaAorKysgYi9nZGIvc2VyaWFsLmgKQEAgLTI1MCwxMSArMjUwLDYg QEAgc3RydWN0IHNlcmlhbAogCQkJCSAgIGJ1ZmZlci4gIC12ZSBmb3Igc3Rp Y2t5IGVycm9ycy4gICovCiAgICAgdW5zaWduZWQgY2hhciAqYnVmcDsJLyog Q3VycmVudCBieXRlICovCiAgICAgdW5zaWduZWQgY2hhciBidWZbQlVGU0la XTsJLyogRGEgYnVmZmVyIGl0c2VsZiAqLwotICAgIGludCBjdXJyZW50X3Rp bWVvdXQ7CS8qIChzZXItdW5peC5jIHRlcm1pb3ssc30gb25seSksIGxhc3QK LQkJCQkgICB2YWx1ZSBvZiBWVElNRSAqLwotICAgIGludCB0aW1lb3V0X3Jl bWFpbmluZzsJLyogKHNlci11bml4LmMgdGVybWlveyxzfSBvbmx5KSwgd2UK LQkJCQkgICBzdGlsbCBuZWVkIHRvIHdhaXQgZm9yIHRoaXMgbWFueQotCQkJ CSAgIG1vcmUgc2Vjb25kcy4gICovCiAgICAgc3RydWN0IHNlcmlhbCAqbmV4 dDsJLyogUG9pbnRlciB0byB0aGUgbmV4dCBgc3RydWN0IHNlcmlhbCAqJyAq LwogICAgIGludCBkZWJ1Z19wOwkJLyogVHJhY2UgdGhpcyBzZXJpYWwgZGV2 aWNlcyBvcGVyYXRpb24uICAqLwogICAgIGludCBhc3luY19zdGF0ZTsJCS8q IEFzeW5jIGludGVybmFsIHN0YXRlLiAgKi8K --001a1142f1785a8e1c054aa75e28--