From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121766 invoked by alias); 23 Mar 2019 11:59:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121138 invoked by uid 89); 23 Mar 2019 11:59:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,FROM_EXCESS_BASE64,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=English, english X-HELO: mail-vs1-f48.google.com Received: from mail-vs1-f48.google.com (HELO mail-vs1-f48.google.com) (209.85.217.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Mar 2019 11:59:20 +0000 Received: by mail-vs1-f48.google.com with SMTP id a190so692204vsd.0 for ; Sat, 23 Mar 2019 04:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=CuKkrUWTnu9Gl8wUQv/QqgvfVKIWG898ixfxdGnmyzY=; b=A1r+nr6NgZzNEVn3IFupidqZRFAxoFz8YDA1SfWpR28iaM6SRxn9L1rM4Svwungq0u M2GHcwV+dMQRGvrT2gHkUHoaH80T5oI6uRyxU7n/GZaS9uxGYGKGavZt2OM7jZjDl+WX /V/p6hEP3raZ39b7AwEtaKl3jRTHqfwHsq/v6FyaNRNzpki09uQn85JzBJoN77BpRshE hJNJu6Nxl0uVn2G2Qd9x13R1gAGHyZnvIWNuLOFAN93kWfGc2SoRY+Aenr/Z4uzChKNS 9BUt+zALllTSaLzK5D4sE1EJhHeJOd/npIdBHE0vZlEnIdpZCsOgSxxd7hrUZrVCEqgz I3UA== MIME-Version: 1.0 From: =?UTF-8?B?0JLQu9Cw0LTQuNC80LjRgCDQnNCw0YDRgtGM0Y/QvdC+0LI=?= Date: Sat, 23 Mar 2019 11:59:00 -0000 Message-ID: Subject: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="000000000000849c380584c1b3aa" X-SW-Source: 2019-03/txt/msg00497.txt.bz2 --000000000000849c380584c1b3aa Content-Type: text/plain; charset="UTF-8" Content-length: 497 The fourth argument of FormatMessage() in strwinerror() in file win32-low.c is set to zero. Thus, Windows could use system default locale to translate error codes to error message. At the same time, gdbserver have hardcoded English error messages ("Error creating process..." for example). As a result, server could display error messages with mixed languages. I made a patch to use en_US locale in FormatMessage, so all error messages will be in English. Changelog and patch files are attached --000000000000849c380584c1b3aa Content-Type: application/octet-stream; name="Changelog.24377" Content-Disposition: attachment; filename="Changelog.24377" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtlfxad41 Content-length: 297 Z2RiL2dkYnNlcnZlci9DaGFuZ2VMb2c6DQoyMDE5LTAzLTIzICBWbGFkaW1p ciBNYXJ0eWFub3YgIDx2aWxnZWZvcmNlQGdtYWlsLmNvbT4NCg0KCVBSIHNl cnZlci8yNDM3Nw0KCSogd2luMzItbG93LmMgKHN0cndpbmVycm9yKTogQ2hh bmdlZCBzeXN0ZW0gZGVhZnVsdCBsb2NhbGUgdG8NCgllbl9VUyB3aGVuIHRy YW5zbGF0aW5nIFdpbmRvd3MgZXJyb3IgY29kZSB0byBtZXNzYWdl --000000000000849c380584c1b3aa Content-Type: application/octet-stream; name="0001-Fix-mixing-English-and-system-default-languages-in-e.patch" Content-Disposition: attachment; filename="0001-Fix-mixing-English-and-system-default-languages-in-e.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtlfxacr0 Content-length: 1098 RnJvbSAxYmNmYzliZGMxNDM5OWYwNGM4MDJhYzVlNGY0NTkxNTM4YjlkMmZk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBWbGFkaW1pciBNYXJ0 eWFub3YgPHZpbGdlZm9yY2VAZ21haWwuY29tPgpEYXRlOiBTYXQsIDIzIE1h ciAyMDE5IDE0OjMxOjMzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4IG1p eGluZyBFbmdsaXNoIGFuZCBzeXN0ZW0gZGVmYXVsdCBsYW5ndWFnZXMgaW4g ZXJyb3IKIG1lc3NhZ2VzIG9uIFdpbmRvd3MKCi0tLQogZ2RiL2dkYnNlcnZl ci93aW4zMi1sb3cuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2dkYi9nZGJz ZXJ2ZXIvd2luMzItbG93LmMgYi9nZGIvZ2Ric2VydmVyL3dpbjMyLWxvdy5j CmluZGV4IDFhNTAxNDFjMTIuLjIyNmUwMTI2ZDggMTAwNjQ0Ci0tLSBhL2dk Yi9nZGJzZXJ2ZXIvd2luMzItbG93LmMKKysrIGIvZ2RiL2dkYnNlcnZlci93 aW4zMi1sb3cuYwpAQCAtNTE2LDcgKzUxNiw3IEBAIHN0cndpbmVycm9yIChE V09SRCBlcnJvcikKIAkJCSAgICAgICB8IEZPUk1BVF9NRVNTQUdFX0FMTE9D QVRFX0JVRkZFUiwKIAkJCSAgICAgICBOVUxMLAogCQkJICAgICAgIGVycm9y LAotCQkJICAgICAgIDAsIC8qIERlZmF1bHQgbGFuZ3VhZ2UgKi8KKwkJCSAg ICAgICBNQUtFTEFOR0lEKExBTkdfRU5HTElTSCwgU1VCTEFOR19FTkdMSVNI X1VTKSwKIAkJCSAgICAgICAoTFBUU1RSKSAmbXNnYnVmLAogCQkJICAgICAg IDAsCiAJCQkgICAgICAgTlVMTCk7Ci0tIAoyLjE2LjIud2luZG93cy4xCgo= --000000000000849c380584c1b3aa--