Re: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows

Eli Zaretskii
2019-03-29T12:32:12Z

> From: Ð’Ð»Ð°Ð´Ð¸Ð¼Ð¸Ñ€ ÐœÐ°Ñ€Ñ‚ÑŒÑÐ½Ð¾Ð² <vilgeforce@gmail.com>
> Date: Fri, 29 Mar 2019 12:38:50 +0300
> Cc: gdb-patches@sourceware.org
>
> Using system default locale is not a good idea, user must have a way
> to change message language. If somebody have to debug on chinese
> Windows, he'll get Chinese messages. And this way mustn't affect any
> other applications or the system itself. LC_ALL and other env.
> variables will affect only gettext, not FormatMessage in the current
> implementation.

That completes the full circle and gets us right back to square one.
Where you wanted to force FormatMessage to use the English language
and I asked whether this isn't a step backward.

Anyway, since we have reviewed the various ways of fixing this, I
think you now have all the information you need to produce a patch.
Telling FormatMessage to use English is simple, and letting users
choose a different locale is only meaningful if the other messages,
those which aren't output via FormatMessage, can also be translated to
other languages, which requires to use _() and Gettext.