From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84447 invoked by alias); 31 Mar 2019 19:39:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84437 invoked by uid 89); 31 Mar 2019 19:39:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=1.4 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,FROM_EXCESS_BASE64,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.1 spammy==d0=b2=d1, H*f:sk:CAL5iTP, H*f:CAL5iTP, H*f:sk:83mullp?= X-HELO: mail-vs1-f43.google.com Received: from mail-vs1-f43.google.com (HELO mail-vs1-f43.google.com) (209.85.217.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 31 Mar 2019 19:39:17 +0000 Received: by mail-vs1-f43.google.com with SMTP id t78so4254783vsc.1 for ; Sun, 31 Mar 2019 12:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h8fYevxlwZMRpN+PqQarrRaRR4FjIhrC/rYNFW+UftQ=; b=EjFCTxuTi8h4kTTZkn3zg3+1CiuX32lQMFt1Fi3LGfR4+qg1CVzwKqrDYTl64efccg j2FXz81nSMW+lpsQsjpoQAsPmVB6kc+p0FVchcmJTTT3GQOhj8ns0hFCUlFc/BrNa98q EcTFdAPCY8YrIpfxV+EXvSNZjR0s/YbQMII2pUkFQ6qIN01l8Hl6pqNHl7a8Zk+xVvLU ICI/Npqzz9vIAT34k+pOrl+ZlC8Z/mh7oUXJXy7EDaC5eS2B1A5//JAdtyXCnoicaeuU EpxJ8gYlAjs+TDqlpVy5VU6xs4HfOjG6Es8gUOfI4VfimFOeNXIXYg2qXzhQmKF0cKSD U7aA== MIME-Version: 1.0 References: <83mullpwg6.fsf@gnu.org> <83ef6qjdbb.fsf@gnu.org> <838swyjafd.fsf@gnu.org> <837echkgjo.fsf@gnu.org> <8336n3hzkx.fsf@gnu.org> In-Reply-To: <8336n3hzkx.fsf@gnu.org> From: =?UTF-8?B?0JLQu9Cw0LTQuNC80LjRgCDQnNCw0YDRgtGM0Y/QvdC+0LI=?= Date: Sun, 31 Mar 2019 19:39:00 -0000 Message-ID: Subject: Re: [PATCH][PR server/24377] Fix mixing English and system default languages in error messages on Windows To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="000000000000219fc70585690fa1" X-SW-Source: 2019-03/txt/msg00782.txt.bz2 --000000000000219fc70585690fa1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 867 =D0=B2=D1=81, 31 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 17:45, Eli Zaretsk= ii : > Bother: do we want to behave like a Posix platform here, or like a > Windows system? Windows doesn't have LC_MESSAGES as a locale > category. I just saw LC_MESSAGES usage in gettext... > Finally, a more general point: I'm not sure I understand the purpose > of this change. Is the purpose to let users control the language of > the gdbserver system error messages? Yes, it's the purprose. > If so, would they need to > control that by setting environment variables? It sounds less > convenient than it could have been, I think. Why not a GDB variable > instead? Environment variables are used in gettext anyway, I think single source for localisation language is convenient. I corrected issues you mentioned (I hope!) and made a function to get local= e ID. --000000000000219fc70585690fa1 Content-Type: application/octet-stream; name="0001-gettext-like-localisation-of-error-messages-added-to.patch" Content-Disposition: attachment; filename="0001-gettext-like-localisation-of-error-messages-added-to.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jtxbdjf40 Content-length: 4453 RnJvbSA4NWY0NmQzNmEyMDQzYzU4MjQ4ZDJkNmNiMDFlMDNhY2I2NjIwMmZh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBWbGFkaW1pciBNYXJ0 eWFub3YgPHZpbGdlZm9yY2VAZ21haWwuY29tPgpEYXRlOiBTdW4sIDMxIE1h ciAyMDE5IDIyOjE4OjI0ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gZ2V0dGV4 dC1saWtlIGxvY2FsaXNhdGlvbiBvZiBlcnJvciBtZXNzYWdlcyBhZGRlZCB0 bwogc3Ryd2luZXJyb3IKCi0tLQogZ2RiL2dkYnNlcnZlci93aW4zMi1sb3cu YyB8IDcwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNjkgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2dkYi9nZGJzZXJ2ZXIvd2lu MzItbG93LmMgYi9nZGIvZ2Ric2VydmVyL3dpbjMyLWxvdy5jCmluZGV4IDFh NTAxNDFjMTIuLmZlOGMxNDUzYTMgMTAwNjQ0Ci0tLSBhL2dkYi9nZGJzZXJ2 ZXIvd2luMzItbG93LmMKKysrIGIvZ2RiL2dkYnNlcnZlci93aW4zMi1sb3cu YwpAQCAtNDk2LDYgKzQ5Niw3MyBAQCBjaGlsZF9zdG9yZV9pbmZlcmlvcl9y ZWdpc3RlcnMgKHN0cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUsIGludCByKQog ICAgICAgKCp0aGVfbG93X3RhcmdldC5zdG9yZV9pbmZlcmlvcl9yZWdpc3Rl cikgKHJlZ2NhY2hlLCB0aCwgcmVnbm8pOwogfQogCisvKiBSZXR1cm4gbG9j YWxlIElEIGZyb20gZW52aXJvbm1lbnQgdmFyaWFibGVzIChMQ19BTEwgYW5k IExBTkcpCisgICAgb3IgMCAod2hpY2ggbWVhbnMgc3lzdGVtIGRlZmF1bHQp LiAqLworTENJRAorZ2V0X2xjaWQodm9pZCkKK3sKKyAgdHlwZWRlZiBIUkVT VUxUIChXSU5BUEkgKlJGQzE3NjZUT0xDSUQpKExDSUQgKnBMb2NhbGUsIExQ VFNUUiBwc3pSZmMxNzY2KTsKKyAgdHlwZWRlZiBMQ0lEIChXSU5BUEkgKkxP Q0FMRU5BTUVUT0xDSUQpKExQQ1dTVFIgbHBOYW1lLCBEV09SRCBkd0ZsYWdz KTsKKworICBzdGF0aWMgSE1PRFVMRSBoTWxhbmcgPSBMb2FkTGlicmFyeSAo Ik1sYW5nLmRsbCIpOworICBITU9EVUxFIGhLZXJuZWwzMiA9IEdldE1vZHVs ZUhhbmRsZSAoImtlcm5lbDMyLmRsbCIpOworCisgIExDSUQgbGNpZCA9IDA7 IC8qIFN5c3RlbSBkZWZhdWx0ICovCisgIGNoYXIgYnVmWzI1Nl07CisgIFdD SEFSIHdidWZbMjU2XTsKKyAgY2hhciAqbG9jYWxlTmFtZSA9IE5VTEw7Cisg IGNoYXIgKnB0ciA9IE5VTEw7CisgIFJGQzE3NjZUT0xDSUQgUmZjMTc2NlRv TGNpZCA9IE5VTEw7CisgIExPQ0FMRU5BTUVUT0xDSUQgTG9jYWxlTmFtZVRv TENJRCA9IE5VTEw7CisKKyAgTG9jYWxlTmFtZVRvTENJRCA9IChMT0NBTEVO QU1FVE9MQ0lEKSBHZXRQcm9jQWRkcmVzcyAoaEtlcm5lbDMyLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJMb2NhbGVOYW1lVG9MQ0lEIik7CisgIGlmIChMb2NhbGVOYW1lVG9M Q0lEID09IE5VTEwpCisgIHsKKyAgICBpZiAoaE1sYW5nICE9IE5VTEwpCisg ICAgICBSZmMxNzY2VG9MY2lkID0gKFJGQzE3NjZUT0xDSUQpIEdldFByb2NB ZGRyZXNzIChoTWxhbmcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiUmZjMTc2NlRvTGNpZFciKTsK KyAgICBpZiAoUmZjMTc2NlRvTGNpZCA9PSBOVUxMKQorICAgICAgcmV0dXJu IGxjaWQ7ICAvKiBObyBjb252ZXJzaW9uIGZ1bmNpb25zIC0gcmV0dXJuIHN5 c3RlbSBkZWZhdWx0ICovCisgIH0KKworICAvKiBTZXR0aW5nIG9mIExDX0FM TCBvdmVyd3JpdGVzIGFsbCBvdGhlci4gKi8KKyAgbG9jYWxlTmFtZSA9IGdl dGVudiAoIkxDX0FMTCIpOworICBpZiAobG9jYWxlTmFtZSA9PSBOVUxMIHx8 IGxvY2FsZU5hbWVbMF0gPT0gJ1wwJykKKyAgICBsb2NhbGVOYW1lID0gZ2V0 ZW52ICgiTEFORyIpOworCisKKyAgaWYgKGxvY2FsZU5hbWUgPT0gTlVMTCB8 fCBsb2NhbGVOYW1lWzBdID09ICdcMCcpCisgICAgcmV0dXJuIGxjaWQ7CisK KyAgaWYgKCFzdHJjbXAgKGxvY2FsZU5hbWUsICJDIikpCisgICAgcmV0dXJu IE1BS0VMQU5HSUQgKExBTkdfRU5HTElTSCwgU1VCTEFOR19FTkdMSVNIX1VT KTsKKworICBzdHJuY3B5IChidWYsIGxvY2FsZU5hbWUsIENPVU5UT0YgKGJ1 ZikgLSAxKTsKKyAgcHRyID0gc3RyY2hyIChidWYsICcuJyk7ICAgICAgLyog Y3V0IGF0ICIuIiAqLworICBpZiAocHRyICE9IE5VTEwpCisgICAgKnB0ciA9 IDB4MDA7CisKKyAgcHRyID0gc3RyY2hyIChidWYsICdfJyk7ICAgICAgLyog cmVwbGFjZSAiXyIgKi8KKyAgaWYgKHB0ciAhPSBOVUxMKQorICAgICpwdHIg PSAnLSc7CisKKyAgaWYgKExvY2FsZU5hbWVUb0xDSUQgIT0gTlVMTCkKKyAg eworICAgIE11bHRpQnl0ZVRvV2lkZUNoYXIgKENQX0FDUCwKKyAgICAgICAg ICAgICAgICAgICAgICAgIDAsCisgICAgICAgICAgICAgICAgICAgICAgICBi dWYsCisgICAgICAgICAgICAgICAgICAgICAgICAtMSwKKyAgICAgICAgICAg ICAgICAgICAgICAgIHdidWYsCisgICAgICAgICAgICAgICAgICAgICAgICBD T1VOVE9GICh3YnVmKSAtIDEpOworICAgIGxjaWQgPSBMb2NhbGVOYW1lVG9M Q0lEICh3YnVmLCAwKTsKKyAgfQorICBlbHNlCisgICAgUmZjMTc2NlRvTGNp ZCAoJmxjaWQsIGJ1Zik7CisKKyAgcmV0dXJuIGxjaWQ7Cit9CisKIC8qIE1h cCB0aGUgV2luZG93cyBlcnJvciBudW1iZXIgaW4gRVJST1IgdG8gYSBsb2Nh bGUtZGVwZW5kZW50IGVycm9yCiAgICBtZXNzYWdlIHN0cmluZyBhbmQgcmV0 dXJuIGEgcG9pbnRlciB0byBpdC4gIFR5cGljYWxseSwgdGhlIHZhbHVlcwog ICAgZm9yIEVSUk9SIGNvbWUgZnJvbSBHZXRMYXN0RXJyb3IuCkBAIC01MTIs MTEgKzU3OSwxMiBAQCBzdHJ3aW5lcnJvciAoRFdPUkQgZXJyb3IpCiAgIHN0 YXRpYyBjaGFyIGJ1ZlsxMDI0XTsKICAgVENIQVIgKm1zZ2J1ZjsKICAgRFdP UkQgbGFzdGVyciA9IEdldExhc3RFcnJvciAoKTsKKwogICBEV09SRCBjaGFy cyA9IEZvcm1hdE1lc3NhZ2UgKEZPUk1BVF9NRVNTQUdFX0ZST01fU1lTVEVN CiAJCQkgICAgICAgfCBGT1JNQVRfTUVTU0FHRV9BTExPQ0FURV9CVUZGRVIs CiAJCQkgICAgICAgTlVMTCwKIAkJCSAgICAgICBlcnJvciwKLQkJCSAgICAg ICAwLCAvKiBEZWZhdWx0IGxhbmd1YWdlICovCisJCQkgICAgICAgZ2V0X2xj aWQgKCksCiAJCQkgICAgICAgKExQVFNUUikgJm1zZ2J1ZiwKIAkJCSAgICAg ICAwLAogCQkJICAgICAgIE5VTEwpOwotLSAKMi4xNi4yLndpbmRvd3MuMQoK --000000000000219fc70585690fa1--