Re: [PATCH] Scan for Mach-O start address in LC_MAIN and properly check bfd_mach_o_scan_start_address's return value

David Albert
2012-11-23T19:58:07Z

On Mon, Nov 19, 2012 at 10:30 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "David" == David Albert <davidbalbert@gmail.com> writes:
>
> David> - I didn't run the test suite because it wasn't clear what parts of
> David> the suite I should run. I tested it manually and didn't find any
> David> regressions.
>
> Unfortunately, what you have to do is run the entire test suite before
> and after your change, and verify that there were no regressions or
> dropped tests. Also you have to know that some tests fail spuriously --
> I guess you could post a list of differences and someone could advise.

Sorry I missed this. I ran the binutils test suite before submitting.

-David

>
> Tom