Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special.

Thomas Schwinge
2014-05-22T16:13:03Z

[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]

Hi Gary!

On Thu, 22 May 2014 17:02:08 +0100, Gary Benson <gbenson@redhat.com> wrote:
> Thomas Schwinge wrote:
> > In GCC, I'm consistenly seeing the following new failure:
> >
> > ./test-demangle < ../../../source/libiberty/testsuite/demangle-expected
> > FAIL at line 4350, options --format=auto --no-params:
> > in: _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> > out: (null)
> > exp:
> > ./test-demangle: 895 tests, 1 failures
> > make[2]: *** [check-cplus-dem] Error 1
> >
> > The patch was committed incompletely; I added the missing last line in
> > r210803:
> [snip]
> > @@ -4347,3 +4347,4 @@ void post<std::function<void ()> >(std::function<void ()>&&)::{lambda()#1}*& std
> > --format=auto --no-params
> > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> > _QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
> > +_QueueNotification_QueueController__$4PPPPPPPM_A_INotice___Z
>
> I thought that extra line was a mistake; I thought each test was
> precisely three lines:
>
> # options
> # input to be demangled
> # expected output
>
> What is the extra line here?

I too had to look it up -- see the explanation at the beginning of the
file:

# --no-params There are two lines of expected output; the first
# is with DMGL_PARAMS, the second is without it.

Grüße,
Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]