From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5509 invoked by alias); 9 May 2014 20:53:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5486 invoked by uid 89); 9 May 2014 20:53:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f52.google.com Received: from mail-oa0-f52.google.com (HELO mail-oa0-f52.google.com) (209.85.219.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 09 May 2014 20:53:46 +0000 Received: by mail-oa0-f52.google.com with SMTP id eb12so5582191oac.11 for ; Fri, 09 May 2014 13:53:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=7qTIc26Jg3psqQIKmotgSymVaPfwCGdLdvTvBH608d4=; b=eg7JKiVnZxIqQPrsW9vXRHiRn/NIgqq4tMw++/2mATndjtZ7nU5OlfQYSbOWnxmZvK sDmPbfcvG96F0Z6jEGqE7wcPjIexavQzQ/L+oK2EL80bfw/mrTCKu7IYnO67GCnXZuHw Cx6pHTOL8X9U18vNvVl20FP20LZwOS2G0y779BGAGQ/5KxAafJAfRMmFcvVOrrZkUiUl ZwcfrKgO+2OMWGH3L+cd/vn4H2bva7+tVrml0IO75vUJXFp+ADN6hykfYOalIG8wzlyH 7LSSqPst6Y+/NKFCWqDeljtoc8VPXGe5SmM3g/qvecYAkDVd0Gd89S1arXS5qUPIByiA oycw== X-Gm-Message-State: ALoCoQm8mbpTsK3muTu2pv0hT5/RiDtLpbCkOuXY/OTa636LLbjNXoFEg6Vxv8mDzU5tzMtIRYR+ MIME-Version: 1.0 X-Received: by 10.60.16.103 with SMTP id f7mr17555166oed.8.1399668824174; Fri, 09 May 2014 13:53:44 -0700 (PDT) Received: by 10.60.118.39 with HTTP; Fri, 9 May 2014 13:53:44 -0700 (PDT) In-Reply-To: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> References: <1399646123-9960-1-git-send-email-aburgess@broadcom.com> Date: Fri, 09 May 2014 20:53:00 -0000 Message-ID: Subject: Re: [PATCH] cplus-demangler, free resource after a failed call to gnu_special. From: Ian Lance Taylor To: Andrew Burgess Cc: gcc-patches , Jason Merrill , gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-05/txt/msg00118.txt.bz2 On Fri, May 9, 2014 at 7:35 AM, Andrew Burgess wrote: > if ((AUTO_DEMANGLING || GNU_DEMANGLING)) > { > success = gnu_special (work, &mangled, &decl); > + if (!success) > + { > + delete_work_stuff (work); > + string_delete (&decl); > + } As far as I can see, decl may be uninitialized at this point. I don't think you can call string_delete. You need to ensure that decl is initialized somehow. Ian