From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18155 invoked by alias); 4 Dec 2011 08:26:26 -0000 Received: (qmail 18147 invoked by uid 22791); 4 Dec 2011 08:26:25 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_SB X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 04 Dec 2011 08:26:06 +0000 Received: by wgbds11 with SMTP id ds11so4070405wgb.12 for ; Sun, 04 Dec 2011 00:26:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.102.233 with SMTP id fr9mr7098972wib.40.1322987164695; Sun, 04 Dec 2011 00:26:04 -0800 (PST) Received: by 10.180.96.72 with HTTP; Sun, 4 Dec 2011 00:26:04 -0800 (PST) In-Reply-To: <4EDAD0EF.20405@codesourcery.com> References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <4EDAD0EF.20405@codesourcery.com> Date: Sun, 04 Dec 2011 08:26:00 -0000 Message-ID: Subject: Re: [PATCH] arm reversible : From: oza Pawandeep To: Yao Qi Cc: =?ISO-8859-1?Q?Petr_Hluz=EDn?= , Tom Tromey , paawan oza , "gdb-patches@sourceware.org" , chandra krishnappa Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00094.txt.bz2 Hi Yao and Tom, please have a look at sample changlog below. let me know whether this much detailed explanation is sufficient ? 2011-12-03 Oza Pawandeep * arm-linux-tdep.c: arm_linux_init_abi modified to include arm reversible debugging feature. registered arm_process_record to gdb_arch syscall pointer initialization. * arm-tdep.c: arm-reversible-debugging implementation. newly added functions are as follows. =09 > arm_process_record: handles basic initialization and record summarisation, decodes basic insn ids, on which it hands over controls to decode_insn. > deallocate_reg_mem : clean up function > decode_insn: Decodes arm/thumb insn and calls appropriate decoding routine to record the change. > thumb_record_branch: branch insn reording (thumb) > thumb_record_ldm_stm_swi: load, store and sycall insn recoding (thumb) > thumb_record_misc: misc insn recording (thumb) > thumb_record_ld_st_stack: store and stack insn recording (thum= b) > thumb_record_ld_st_imm_offset: load, store with immediate offset insn recording (thumb) > thumb_record_ld_st_reg_offset: load, store with register offset recording (thumb) > thumb_record_add_sub_cmp_mov: addition, subtractation, compare and move insn recording (thumb) > thumb_record_shift_add_sub: shift, add and sub insn recording (thumb) > arm_record_coproc_data_proc: coprocessor and data processing recording (partially implemented) (arm) > arm_record_coproc: coprocessor insn recording (partially implemented) (arm) > arm_record_b_bl: branch insn recording (arm) > arm_record_ld_st_multiple: load and store multiple insn recordi= ng (arm) > arm_record_ld_st_reg_offset: load and store reg offset recording (arm) > arm_record_ld_st_imm_offset: load and store immediate offset recording (arm) > arm_record_data_proc_imm: data processing insn recording (arm) > arm_record_data_proc_misc_ld_str: data processing, misc, load a= nd store insn recording (arm) > arm_record_extension_space:arm extension space insn recording (arm) > arm_record_strx: str(X) type insn recording (arm) > sbo_sbz: checks for mendatory sbo and sbz fields in insn, added new data structures: > insn_decode_record_t: local record structure which contains ins= n's record, which includes both reg and memory. REG_ALLOC and MEM_ALLOC macros takes care of actual memory alloca= tion in local record which is finally processed by arm_rocess_record. * arm-tdep.h: arm-reversible data structures > modified gdbarch_tdep: added member (function pointer) arm_swi_record which is supposed to be recording system calls > arm_process_record externed. =09 Regards, Oza. On Sun, Dec 4, 2011 at 7:16 AM, Yao Qi wrote: > On 12/04/2011 03:01 AM, oza Pawandeep wrote: >> diff -urN arm_orig/ChangeLog arm_new/ChangeLog >> --- arm_orig/ChangeLog =C2=A0 =C2=A0 =C2=A0 =C2=A02011-12-03 18:05:04.00= 0000000 +0530 >> +++ arm_new/ChangeLog 2011-12-03 19:48:56.000000000 +0530 >> @@ -1,3 +1,9 @@ >> +2011-12-03 =C2=A0Oza Pawandeep =C2=A0 >> + >> + =C2=A0 =C2=A0 * arm-linux-tdep.c: Added arm-reversible and process rec= ord >> + =C2=A0 =C2=A0 * arm-tdep.c: arm-reversible-debugging implementation >> + =C2=A0 =C2=A0 * arm-tdep.h: arm-reversible data structures >> + > > ChangeLog like this is not accurate to reflect your changes. =C2=A0"Add > reverse debugging and process record for ARM" is sort of summary of your > patch, but in ChangeLog, we usually need more details on function level. > > Please read other ChangeLog entries in ChangeLog, and see how it is > written. =C2=A0Or, you can read this > > http://www.gnu.org/prep/standards/standards.html#Change-Logs > > -- > Yao (=E9=BD=90=E5=B0=A7)