From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18330 invoked by alias); 7 Jun 2012 17:20:45 -0000 Received: (qmail 18319 invoked by uid 22791); 7 Jun 2012 17:20:43 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Jun 2012 17:20:30 +0000 Received: by wgbdr1 with SMTP id dr1so561909wgb.12 for ; Thu, 07 Jun 2012 10:20:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.196.91 with SMTP id q69mr1366359wen.185.1339089629235; Thu, 07 Jun 2012 10:20:29 -0700 (PDT) Received: by 10.216.235.140 with HTTP; Thu, 7 Jun 2012 10:20:29 -0700 (PDT) In-Reply-To: <4FD0AF8C.2040908@codesourcery.com> References: <4FD0AF8C.2040908@codesourcery.com> Date: Thu, 07 Jun 2012 17:20:00 -0000 Message-ID: Subject: Re: [PATCH] Makefile.in includes linux-record.c to be common for all arch. (arm-reversible>phase-3) From: oza Pawandeep To: Yao Qi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00218.txt.bz2 ok. sure will add it there as it is not currently linking. but on the contrary 'record.o' is also under the same section COMMON_OBS, which is also not required where no record support. hence it is confusing. Regards, Oza. On Thu, Jun 7, 2012 at 7:11 PM, Yao Qi wrote: > On 06/07/2012 11:51 AM, oza Pawandeep wrote: >> linux-record.o is added under COMMON_OBS, now -linux-tdep.c compil= es. >> ok to commit ? > > I feel it is useless to link linux-record.o for the ports t, hat don't > support record at all. > > If you want to support record in arm-linux, gdb/configure.tgt is the > right place to modify, IMO. =C2=A0You need to add "linux-record.o" into > gdb_target_obs in "arm*-*-linux*)". > > -- > Yao (=E9=BD=90=E5=B0=A7)