From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20707 invoked by alias); 15 Oct 2011 16:34:59 -0000 Received: (qmail 19033 invoked by uid 22791); 15 Oct 2011 16:34:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 15 Oct 2011 16:34:40 +0000 Received: by wyg34 with SMTP id 34so845608wyg.0 for ; Sat, 15 Oct 2011 09:34:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.61.132 with SMTP id t4mr165753wbh.51.1318696478710; Sat, 15 Oct 2011 09:34:38 -0700 (PDT) Received: by 10.180.105.69 with HTTP; Sat, 15 Oct 2011 09:34:38 -0700 (PDT) In-Reply-To: <4E998B76.8020803@codesourcery.com> References: <998639.46560.qm@web112516.mail.gq1.yahoo.com> <321260.58442.qm@web112504.mail.gq1.yahoo.com> <1316327455.23344.YahooMailNeo@web112509.mail.gq1.yahoo.com> <1316404058.27177.YahooMailNeo@web112502.mail.gq1.yahoo.com> <1318650316.91503.YahooMailNeo@web112508.mail.gq1.yahoo.com> <4E9952EA.5040805@codesourcery.com> <4E998B76.8020803@codesourcery.com> Date: Sat, 15 Oct 2011 16:34:00 -0000 Message-ID: Subject: Re: [PATCH] arm reversible : From: oza Pawandeep To: Yao Qi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00437.txt.bz2 Hi Yao, first of all thank you for your comments, will be sending the patch soon with your comments incorporated as much as possible. thank you again for sending test results; I suppose failed test case might be including 1) system call support 2) signal support 3) any other linux ABI support 4) there are some programs on x86 assembly which needs to be written for ARM and put separately. Thanks Yao, Oza. On Sat, Oct 15, 2011 at 6:02 PM, Yao Qi wrote: > On 10/15/2011 05:31 PM, Yao Qi wrote: >> I noticed that test cases in gdb.reverse are *not* enabled in default. >> You need to add the following two lines in your board file to turn them = on, >> >> =C2=A0 set_board_info gdb,use_precord 1 >> =C2=A0 set_board_info gdb,can_reverse 1 >> >> It is good if you can post the test result in gdb.reverse so that we are >> more confidient to your patch. > =C2=A0 =C2=A0 =C2=A0 ^^^^^^^^^^ typo "confident". > > I run test cases in gdb.reverse with my own board file [1], and get > following result on x86: > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D=3D=3D gdb Summ= ary =3D=3D=3D > > # of expected passes =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A02774 > # of unexpected failures =C2=A0 =C2=A0 =C2=A0 =C2=A022 > > I also applied your patch, and run gdb.reverse test cases on arm natively: > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D=3D=3D gdb Summ= ary =3D=3D=3D > > # of expected passes =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01180 > # of unexpected failures =C2=A0 =C2=A0 =C2=A0 =C2=A01090 > # of expected failures =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0142 > > I don't think these fails are all related to your arm-reverse patch. > IMO, it means there are still some work to do, not only in arm bits, but > also in gdb general parts and test cases. =C2=A0Sorry that I can't give a= ny > useful suggestion here. > > -- > Yao (=E9=BD=90=E5=B0=A7) > > [1] My board file reverse.exp > > load_generic_config "unix" > process_multilib_options "" > > # The default compiler for this target. > set_board_info compiler "[find_gcc]" > > set_board_info gdb,can_reverse 1 > set_board_info gdb,use_precord 1 >