From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16709 invoked by alias); 30 Aug 2012 06:10:21 -0000 Received: (qmail 16694 invoked by uid 22791); 30 Aug 2012 06:10:19 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Aug 2012 06:10:06 +0000 Received: by vbkv13 with SMTP id v13so1682001vbk.0 for ; Wed, 29 Aug 2012 23:10:05 -0700 (PDT) Received: by 10.52.26.137 with SMTP id l9mr1983870vdg.62.1346307005342; Wed, 29 Aug 2012 23:10:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.58.164.66 with HTTP; Wed, 29 Aug 2012 23:09:45 -0700 (PDT) In-Reply-To: References: <503B9E59.6050502@codesourcery.com> From: Mike Frysinger Date: Thu, 30 Aug 2012 06:10:00 -0000 Message-ID: Subject: Re: [RFC] New GDB Port CR16 To: Kaushik Phatak Cc: "gdb-patches@sourceware.org" , Yao Qi Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00863.txt.bz2 On Thu, Aug 30, 2012 at 1:23 AM, Kaushik Phatak wrote: >> needs a space there: > + switch(a) >> just one space after "case" >> also, the comment should have two spaces before the */: > > I have fixed the above three issues in the attached patch. > If everything else looks OK, could you please check these in for me as I > do not have write privileges to the repository? i've committed the sim/cr16/ changes. i can't commit the sim/common/ changes yet because the libgloss header hasn't been merged yet. -mike