From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by sourceware.org (Postfix) with ESMTPS id 28037385B835 for ; Sat, 18 Apr 2020 11:18:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 28037385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nelson.chu@sifive.com Received: by mail-il1-x142.google.com with SMTP id t10so4833746ilg.9 for ; Sat, 18 Apr 2020 04:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bxSrlVstTpAaQb1PpO+aa4UrZ5mY89UGC0QHxQD+HGE=; b=H9XjdiGBiHibK+HiwMyR4tm8R0bdUXpz8xyvCAl4dArEgGRGXi+pg3axA90qRTldqx 8yCjeNEIgrvMZtxnPXGyJI5mPgnHQIklJ0XiiXTZS2O9SQ9kglq+cKpHwtM2W2AvXIFc uPJWY4b26n64d8mXNjQb0jU6ysWv73Esr59aR2EV4an+2iq43cjmVtQQRmQoXBjDr/t4 JZ6/tRscyT9MP8bkYo7562aQ9cm5HhKW0on32lrj3Z/e4bjwXh79JNQmvfVUEAqLz88D 3YLYyd16Pn1TyE6EVnF17i2d/y3Zg17u1Ozg1Xa6afKMWO4LjehclqoNhtrYIGJ1Ttla IX3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bxSrlVstTpAaQb1PpO+aa4UrZ5mY89UGC0QHxQD+HGE=; b=bIRAZe0VFp11DTv3vj1ZRJ/8qR+I593RIemedulEWJG6A+6otFYodmcX/keOVd7N5b 1TRURbXL0swxn0qQOKD5R8gGsCvWEmYlCHqhaew4jI9q42XAfDTRnH7W0Vnb/mLfgXHM kzCd5IKXRK0PDY3LkK/idM7UgsyOr7NL+lBN9fmYwV6VyLsyZNk1dygXSyN0uY8w8/nE 8gIbn5+r9h1CMSkTWTkIux90/knBULYJ+fz45Dwd86IZITwT5NLNCitwwALMNYCE2HU/ gXErY1iT5hIwVMu6+jxpo8LNEK1Lc90y+zANmrBiwG3KaFtyaGzJf6qre+q7LKHRaAmI bZyw== X-Gm-Message-State: AGi0PuamZQeDcBaS6/PWBZhNzIV8V7Xqtba2n0/t1bdqPr3MOBRycLfJ GFAxCYZx38wdF4r/PYo7V5WRyVHdkI8ECeCgjWca9g== X-Google-Smtp-Source: APiQypL4GvqA1rMNS3kmzw46hkZ2mLuOviHR8mGFQj6ghQe4Lv7evw4yOjG3sits1meiDRsnEm4L12MhNKWy9LeRzlE= X-Received: by 2002:a92:c794:: with SMTP id c20mr7434071ilk.273.1587208688655; Sat, 18 Apr 2020 04:18:08 -0700 (PDT) MIME-Version: 1.0 References: <1587208075-2462-1-git-send-email-nelson.chu@sifive.com> <1587208075-2462-3-git-send-email-nelson.chu@sifive.com> In-Reply-To: <1587208075-2462-3-git-send-email-nelson.chu@sifive.com> From: Nelson Chu Date: Sat, 18 Apr 2020 19:17:59 +0800 Message-ID: Subject: Re: [PATCH 2/7] RISC-V: Forgot to update the priv-reg-fail-read-only-01 test case. To: Binutils , gdb-patches@sourceware.org Cc: Andrew Burgess , Andrew Waterman , asb@lowrisc.org, Kito Cheng , Maxim Blinov , Jim Wilson , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-22.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2020 11:18:10 -0000 CC Palmer. Thanks Nelson On Sat, Apr 18, 2020 at 7:08 PM Nelson Chu wrote: > > priv-reg and priv-reg-fail-read-only-01 should be updated at the same time. > The fromer checks all CSR by csrr instructions, and the later uses csrw to > check whether the CSR is read only or not. > > gas/ > * testsuite/gas/riscv/priv-reg-fail-read-only-01.s: Updated. > --- > .../gas/riscv/priv-reg-fail-read-only-01.s | 114 ++++++++++----------- > 1 file changed, 57 insertions(+), 57 deletions(-) > > diff --git a/gas/testsuite/gas/riscv/priv-reg-fail-read-only-01.s b/gas/testsuite/gas/riscv/priv-reg-fail-read-only-01.s > index 501a52e..3646c80 100644 > --- a/gas/testsuite/gas/riscv/priv-reg-fail-read-only-01.s > +++ b/gas/testsuite/gas/riscv/priv-reg-fail-read-only-01.s > @@ -1,7 +1,8 @@ > .macro csr val > csrw \val, a1 > .endm > -# 1.9.1 registers > + > + # Supported the current priv spec 1.11. > csr ustatus > csr uie > csr utvec > @@ -9,7 +10,7 @@ > csr uscratch > csr uepc > csr ucause > - csr ubadaddr > + csr utval # Added in 1.10 > csr uip > > csr fflags > @@ -86,26 +87,15 @@ > csr sideleg > csr sie > csr stvec > + csr scounteren # Added in 1.10 > > csr sscratch > csr sepc > csr scause > - csr sbadaddr > + csr stval # Added in 1.10 > csr sip > > - csr sptbr > - > - csr hstatus > - csr hedeleg > - csr hideleg > - csr hie > - csr htvec > - > - csr hscratch > - csr hepc > - csr hcause > - csr hbadaddr > - csr hip > + csr satp # Added in 1.10 > > csr mvendorid > csr marchid > @@ -113,24 +103,39 @@ > csr mhartid > > csr mstatus > - csr misa > + csr misa # 0xf10 in 1.9, but changed to 0x301 since 1.9.1. > csr medeleg > csr mideleg > csr mie > csr mtvec > + csr mcounteren # Added in 1.10 > > csr mscratch > csr mepc > csr mcause > - csr mbadaddr > + csr mtval # Added in 1.10 > csr mip > > - csr mbase > - csr mbound > - csr mibase > - csr mibound > - csr mdbase > - csr mdbound > + csr pmpcfg0 # Added in 1.10 > + csr pmpcfg1 # Added in 1.10 > + csr pmpcfg2 # Added in 1.10 > + csr pmpcfg3 # Added in 1.10 > + csr pmpaddr0 # Added in 1.10 > + csr pmpaddr1 # Added in 1.10 > + csr pmpaddr2 # Added in 1.10 > + csr pmpaddr3 # Added in 1.10 > + csr pmpaddr4 # Added in 1.10 > + csr pmpaddr5 # Added in 1.10 > + csr pmpaddr6 # Added in 1.10 > + csr pmpaddr7 # Added in 1.10 > + csr pmpaddr8 # Added in 1.10 > + csr pmpaddr9 # Added in 1.10 > + csr pmpaddr10 # Added in 1.10 > + csr pmpaddr11 # Added in 1.10 > + csr pmpaddr12 # Added in 1.10 > + csr pmpaddr13 # Added in 1.10 > + csr pmpaddr14 # Added in 1.10 > + csr pmpaddr15 # Added in 1.10 > > csr mcycle > csr minstret > @@ -195,10 +200,7 @@ > csr mhpmcounter30h > csr mhpmcounter31h > > - csr mucounteren > - csr mscounteren > - csr mhcounteren > - > + csr mcountinhibit # Added in 1.11 > csr mhpmevent3 > csr mhpmevent4 > csr mhpmevent5 > @@ -236,34 +238,32 @@ > > csr dcsr > csr dpc > - csr dscratch > -# 1.10 registers > - csr utval > - > - csr scounteren > - csr stval > - csr satp > + csr dscratch0 # Added in 1.11 > + csr dscratch1 # Added in 1.11 > > - csr mcounteren > - csr mtval > + # Supported in previous priv spec, but dropped now. > + csr ubadaddr # 0x043 in 1.9.1, but the value is utval since 1.10 > + csr sbadaddr # 0x143 in 1.9.1, but the value is stval since 1.10 > + csr sptbr # 0x180 in 1.9.1, but the value is satp since 1.10 > + csr mbadaddr # 0x343 in 1.9.1, but the value is mtval since 1.10 > + csr mucounteren # 0x320 in 1.9.1, dropped in 1.10, but the value is mcountinhibit since 1.11 > + csr dscratch # 0x7b2 in 1.10, but the value is dscratch0 since 1.11 > > - csr pmpcfg0 > - csr pmpcfg1 > - csr pmpcfg2 > - csr pmpcfg3 > - csr pmpaddr0 > - csr pmpaddr1 > - csr pmpaddr2 > - csr pmpaddr3 > - csr pmpaddr4 > - csr pmpaddr5 > - csr pmpaddr6 > - csr pmpaddr7 > - csr pmpaddr8 > - csr pmpaddr9 > - csr pmpaddr10 > - csr pmpaddr11 > - csr pmpaddr12 > - csr pmpaddr13 > - csr pmpaddr14 > - csr pmpaddr15 > + csr hstatus # 0x200, dropped in 1.10 > + csr hedeleg # 0x202, dropped in 1.10 > + csr hideleg # 0x203, dropped in 1.10 > + csr hie # 0x204, dropped in 1.10 > + csr htvec # 0x205, dropped in 1.10 > + csr hscratch # 0x240, dropped in 1.10 > + csr hepc # 0x241, dropped in 1.10 > + csr hcause # 0x242, dropped in 1.10 > + csr hbadaddr # 0x243, dropped in 1.10 > + csr hip # 0x244, dropped in 1.10 > + csr mbase # 0x380, dropped in 1.10 > + csr mbound # 0x381, dropped in 1.10 > + csr mibase # 0x382, dropped in 1.10 > + csr mibound # 0x383, dropped in 1.10 > + csr mdbase # 0x384, dropped in 1.10 > + csr mdbound # 0x385, dropped in 1.10 > + csr mscounteren # 0x321, dropped in 1.10 > + csr mhcounteren # 0x322, dropped in 1.10 > -- > 2.7.4 >