From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7CczOLM77WDtBQAAWB0awg (envelope-from ) for ; Tue, 13 Jul 2021 03:07:31 -0400 Received: by simark.ca (Postfix, from userid 112) id C07F31EDEE; Tue, 13 Jul 2021 03:07:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F0F301E79C for ; Tue, 13 Jul 2021 03:07:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 234CA389851D for ; Tue, 13 Jul 2021 07:07:26 +0000 (GMT) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 4EEDD383B409 for ; Tue, 13 Jul 2021 07:07:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EEDD383B409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-io1-xd2f.google.com with SMTP id l5so25838977iok.7 for ; Tue, 13 Jul 2021 00:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VovCD9sOWlUqTHA8GhzMBdUwUjo3harxyJXcQmZqQJw=; b=UGAmMOrnJbzbUGMbDckBnUOUTRebiy0AcqE7q4q3MYQ02d5ZS5UcrTq8BOxLOal+KV QYINQ4kEtdM7dxunJGaf+sgW+bGu20rKsfFoNImfMxW2agZqL+8conla7XZ0M4x2J1XV /D+/1qjvTNLkW8YTQXoNOW2maSs7ZJc11qX4tLBVdKwwDj7+6U65xXbC53M6n/Miy14O cV5sWOrxanPwyGcjNh7Ij1zLYwm5ab3XUxaiPycEepfgBnOmDScjEQzcrw5MfEAfv3ma QkqlrwV6oicxGfyXALws5mzuenABR5y7OgE9qOYZ/7euyk1yEEzv5pBO6Y3+qgxx5uH5 7omw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VovCD9sOWlUqTHA8GhzMBdUwUjo3harxyJXcQmZqQJw=; b=qDfF79+Ey7VHM2h4oDVjGC6m+KiiIXk8oPBjaObeehfs/OmRquQA7cxk6XFw9xg2Ci 40t1lRsAW7Ay61948iJZFvjJ6akNWYd3OrEFOAp6gi2JSKEj/ZSE13MxMPUnIT3arSKV ND/nCPiU2BWuXl9tUHs4qYX6YfAqvfWXtZ0PhBsSWdEPKtzRP3DCKEnXzqRq8l7K/+GS 7HKjVnGm9W5q4rddpHSiziObQYRkoRYe5eUKuHPad0waJ4TCbrpAc9ilWrR2uH0ig/f4 8b3K9/bVCF2O/XTEBgEhoAKniQTrCChi8jYVlPnZvYCC2nI9K8mNuG5VIDlt1qQhpHpK rPlA== X-Gm-Message-State: AOAM533an/0Et9ttAykF7nBSuzUehF92c6GLxSsY9JlBoiaKJsXDyQsS DfOpGWZ15w3yw2KoeNd7ujcvy0ht1iDUSYDRZcZQvA== X-Google-Smtp-Source: ABdhPJxqkWG7qsbmcLbvpqPmhMg5isWYLSHzW/UjVDBKtLgmwsWv9ChyIFRKLrwwNQyAxlMtu5XbXZjwFYwLe4CW4oU= X-Received: by 2002:a5d:9cd9:: with SMTP id w25mr2150882iow.36.1626160031633; Tue, 13 Jul 2021 00:07:11 -0700 (PDT) MIME-Version: 1.0 References: <20210709072825.13709-1-nelson.chu@sifive.com> <20210709072825.13709-2-nelson.chu@sifive.com> In-Reply-To: From: Nelson Chu Date: Tue, 13 Jul 2021 15:07:01 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] RISC-V: Enable elf attributes when default configure option isn't set. To: Kito Cheng Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Waterman , Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Thanks for the suggestion. Committed this one first. Nelson On Fri, Jul 9, 2021 at 4:00 PM Kito Cheng wrote: > > I would suggest this patch could be a standalone patch from the > mapping symbol patch set. > > On Fri, Jul 9, 2021 at 3:28 PM Nelson Chu wrote: > > > > Since gcc commit, 3c70b3ca1ef58f302bf8c16d9e7c7bb8626408bf, we now enable > > elf attributes for all riscv targets by default in gcc. Therefore, I > > think binutils should have the same behavior, in case users are writing > > assembly files. > > > > ChangLog: > > > > binutils/ > > > > * testsuite/binutils-all/readelf.s: Add comments for riscv. > > * testsuite/binutils-all/readelf.s-64: Likewise. > > * testsuite/binutils-all/readelf.s-64-unused: Likewise. > > * testsuite/binutils-all/readelf.ss: Likewise. > > * testsuite/binutils-all/readelf.ss-64: Likewise. > > * testsuite/binutils-all/readelf.ss-64-unused: Likewise. > > > > gas/ > > > > * configure.ac: If --enable-default-riscv-attribute isn't set, > > then we enable the elf attributes for all riscv targets by > > default. > > * configure: Regenerated. > > --- > > binutils/testsuite/binutils-all/readelf.s | 3 ++- > > binutils/testsuite/binutils-all/readelf.s-64 | 2 ++ > > binutils/testsuite/binutils-all/readelf.s-64-unused | 2 ++ > > binutils/testsuite/binutils-all/readelf.ss | 1 + > > binutils/testsuite/binutils-all/readelf.ss-64 | 1 + > > binutils/testsuite/binutils-all/readelf.ss-64-unused | 1 + > > gas/configure | 9 +-------- > > gas/configure.ac | 9 +-------- > > 8 files changed, 11 insertions(+), 17 deletions(-) > > > > diff --git a/binutils/testsuite/binutils-all/readelf.s b/binutils/testsuite/binutils-all/readelf.s > > index 6ae4dc756b9..ff37acb4da8 100644 > > --- a/binutils/testsuite/binutils-all/readelf.s > > +++ b/binutils/testsuite/binutils-all/readelf.s > > @@ -11,9 +11,10 @@ Section Headers: > > #... > > +\[ .\] .* +PROGBITS +00000000 0000(3c|40|44|48|50) 0000(04|10) 00 +WA +0 +0 +(.|..) > > +\[ .\] .* +NOBITS +00000000 0000(40|44|48|4c|60) 000000 00 +WA +0 +0 +(.|..) > > -# ARM targets put .ARM.attributes here > > +# ARM targets put .ARM.attributes here. > > # MIPS targets put .reginfo, .mdebug, .MIPS.abiflags and .gnu.attributes here. > > # v850 targets put .call_table_data and .call_table_text here. > > +# riscv targets put .riscv.attributes here. > > #... > > +\[..\] .symtab +SYMTAB +00000000 0+.* 0+.* 10 +.. +.+ +4 > > +\[..\] .strtab +STRTAB +00000000 0+.* 0+.* 00 .* +0 +0 +1 > > diff --git a/binutils/testsuite/binutils-all/readelf.s-64 b/binutils/testsuite/binutils-all/readelf.s-64 > > index 92ec05f0376..4c957f7a938 100644 > > --- a/binutils/testsuite/binutils-all/readelf.s-64 > > +++ b/binutils/testsuite/binutils-all/readelf.s-64 > > @@ -14,10 +14,12 @@ Section Headers: > > +\[ 4\] .bss +NOBITS +0000000000000000 +000000(4c|50|54|58|68) > > +0000000000000000 +0000000000000000 +WA +0 +0 +.* > > # x86 targets may put .note.gnu.property here. > > +# riscv targets put .riscv.attributes here. > > #... > > +\[ .\] .symtab +SYMTAB +0000000000000000 +0+.* > > # aarch64-elf targets have one more data symbol. > > # x86 targets may have .note.gnu.property. > > +# riscv targets have .riscv.attributes. > > +0+.* +0000000000000018 +(6|7) +(3|4) +8 > > +\[ .\] .strtab +STRTAB +0000000000000000 +0+.* > > +0+.* +0000000000000000 .* +0 +0 +1 > > diff --git a/binutils/testsuite/binutils-all/readelf.s-64-unused b/binutils/testsuite/binutils-all/readelf.s-64-unused > > index a1e6cd1bbd8..771439411a0 100644 > > --- a/binutils/testsuite/binutils-all/readelf.s-64-unused > > +++ b/binutils/testsuite/binutils-all/readelf.s-64-unused > > @@ -14,10 +14,12 @@ Section Headers: > > +\[ 4\] .bss +NOBITS +0000000000000000 +000000(4c|50|54|58) > > +0000000000000000 +0000000000000000 +WA +0 +0 +.* > > # x86 targets may put .note.gnu.property here. > > +# riscv targets put .riscv.attributes here. > > #... > > +\[ .\] .symtab +SYMTAB +0000000000000000 +0+.* > > # aarch64-elf targets have one more data symbol. > > # x86 targets may have .note.gnu.property. > > +# riscv targets have .riscv.attributes. > > +0+.* +0000000000000018 +(6|7) +(6|7) +8 > > +\[ .\] .strtab +STRTAB +0000000000000000 +0+.* > > +0+.* +0000000000000000 .* +0 +0 +1 > > diff --git a/binutils/testsuite/binutils-all/readelf.ss b/binutils/testsuite/binutils-all/readelf.ss > > index 5fbb5d002e3..b81c016e9e7 100644 > > --- a/binutils/testsuite/binutils-all/readelf.ss > > +++ b/binutils/testsuite/binutils-all/readelf.ss > > @@ -9,6 +9,7 @@ Symbol table '.symtab' contains .* entries: > > +.: 00000000 +0 +NOTYPE +LOCAL +DEFAULT +[34] static_data_symbol > > # v850 targets include extra SECTION symbols here for the .call_table_data > > # and .call_table_text sections. > > +# riscv targets add .riscv.attribute symbol here... > > #... > > +[0-9]+: 00000000 +0 +NOTYPE +GLOBAL +DEFAULT +1 text_symbol > > +[0-9]+: 00000000 +0 +NOTYPE +GLOBAL +DEFAULT +UND external_symbol > > diff --git a/binutils/testsuite/binutils-all/readelf.ss-64 b/binutils/testsuite/binutils-all/readelf.ss-64 > > index 99a732f71f5..c6ffb0fc523 100644 > > --- a/binutils/testsuite/binutils-all/readelf.ss-64 > > +++ b/binutils/testsuite/binutils-all/readelf.ss-64 > > @@ -7,6 +7,7 @@ Symbol table '.symtab' contains .* entries: > > #... > > +.: 0000000000000000 +0 +NOTYPE +LOCAL +DEFAULT +3 static_data_symbol > > # ... or here ... > > +# riscv targets add .riscv.attribute symbol here... > > #... > > .* +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +1 text_symbol > > +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +UND external_symbol > > diff --git a/binutils/testsuite/binutils-all/readelf.ss-64-unused b/binutils/testsuite/binutils-all/readelf.ss-64-unused > > index f48a4b2bbd2..cf515aa60d0 100644 > > --- a/binutils/testsuite/binutils-all/readelf.ss-64-unused > > +++ b/binutils/testsuite/binutils-all/readelf.ss-64-unused > > @@ -10,6 +10,7 @@ Symbol table '.symtab' contains .* entries: > > #... > > +.: 0000000000000000 +0 +NOTYPE +LOCAL +DEFAULT +3 static_data_symbol > > # ... or here ... > > +# riscv targets add .riscv.attribute symbol here... > > #... > > .* +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +1 text_symbol > > +.: 0000000000000000 +0 +NOTYPE +GLOBAL +DEFAULT +UND external_symbol > > diff --git a/gas/configure b/gas/configure > > index 110d707f079..7a528fd485e 100755 > > --- a/gas/configure > > +++ b/gas/configure > > @@ -12550,14 +12550,7 @@ _ACEOF > > > > > > if test ${ac_default_generate_riscv_attr} = unset; then > > - case ${target_os} in > > - elf) > > - ac_default_generate_riscv_attr=1 > > - ;; > > - *) > > - ac_default_generate_riscv_attr=0 > > - ;; > > - esac > > + ac_default_generate_riscv_attr=1 > > fi > > > > > > diff --git a/gas/configure.ac b/gas/configure.ac > > index 78efba88e23..e2374268c56 100644 > > --- a/gas/configure.ac > > +++ b/gas/configure.ac > > @@ -727,14 +727,7 @@ AC_DEFINE_UNQUOTED(DEFAULT_X86_USED_NOTE, > > properties by default.]) > > > > if test ${ac_default_generate_riscv_attr} = unset; then > > - case ${target_os} in > > - elf) > > - ac_default_generate_riscv_attr=1 > > - ;; > > - *) > > - ac_default_generate_riscv_attr=0 > > - ;; > > - esac > > + ac_default_generate_riscv_attr=1 > > fi > > > > AC_DEFINE_UNQUOTED(DEFAULT_RISCV_ATTR, > > -- > > 2.30.2 > >