From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vBXrKMeRAWbYiBUAWB0awg (envelope-from ) for ; Mon, 25 Mar 2024 11:01:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ThNaJamJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 907F51E0C0; Mon, 25 Mar 2024 11:01:27 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7331C1E030 for ; Mon, 25 Mar 2024 11:01:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E5243858418 for ; Mon, 25 Mar 2024 15:01:25 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4FECD385842C for ; Mon, 25 Mar 2024 15:00:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4FECD385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4FECD385842C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711378865; cv=none; b=Lf966LzAj0oQI9twU5oA0AQNVIpEPFz1+MbrhgFib1xLP69I/my8oUPXDsIaJ27XtPt3dxOmzG8jx3FGu7UR4mi4Gfn5rI30OyBR+oV91D/QSG7LI6TyvymcpNQ1TNVXD9W/lG6eE6TybyuffOIN6xW2uj4YA5vli/MbUtiLPig= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711378865; c=relaxed/simple; bh=B72E3IC545uJYYyjoN4gfM9bKohWlBU7pJPZkCbvymw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=NzLIJ8KbqAPQx2JooiIFIZwcflOEvG/PcAkWCu5d6N5PwteV9/t7I2L+LRK7kFDM17vM2CpNiJvew7kf9DIZAWpyPeTMBqtVIRRedmOgXaNnZsmFAWXBqyvkqBzIqeo748V4327VjGgI9YUoLg85ymjhZHravRXsw0Px77OjeWM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711378855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gHw+KFTMTWqNzhre0BB8Oju3hyARWOzH/7li2iLJifA=; b=ThNaJamJ0bUWReeBGTE3G6KwV4gpMSpLgXH5LW4GPZIKhBFLiIvfsmv8Jqh2aTFWNoVFGP yyRyEpsQA6UnOZ+5K2dpAwHRNlicuzO/duu0hPZqUZbQwvCsO8LYIN3X2ad+LjvhdX1PmQ mZ5ogbfXFbvGDoihYv5vaXWyGD6BA2k= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-Ksmk97bfMKG4pN_RCm6zYA-1; Mon, 25 Mar 2024 11:00:52 -0400 X-MC-Unique: Ksmk97bfMKG4pN_RCm6zYA-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2a05923dbd9so1517604a91.2 for ; Mon, 25 Mar 2024 08:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711378851; x=1711983651; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gHw+KFTMTWqNzhre0BB8Oju3hyARWOzH/7li2iLJifA=; b=UWeOphj1QYEAvMJG/E9nxEpEP9Ez4evQ5jbotvySnFG94qIvjpXl30mULP6kaIN4fd MzWE4JIxsQvSgDFamLWHS9Rr6FwXiGxh1L1Q7ifz1rG9iNoeEvVPo38MV76FkAs+9zT8 AQf4djnkH0M+uKL1OLKVjEnoxL7mpxhRXCfbBZsuKSFe2WqMGcwEbBtsaXF5z8WONTtg 3bvDX5Bef7C24L/cqoZsZEmke7fLt1fctpsv57jdbPgvHA/w83NBmFwhoSTuBoidLEDY 7fRyRrtJQDzRNu3eR4BGKOvxHHL6i8IHHZCTeWSBZF4lH9oZnL0sUCvBdPsQR9MZoXhY Hynw== X-Gm-Message-State: AOJu0Yx2yylZVCFRzEgggPPrscQXEsjsJqJ5LuW8nqpCT3RxwW0eJWRd 87/06OklqG++IT9xz/QqhSZCRyWy58yW0TDJN8+GI+7FjtEYsbmsGoSr1P8hxEhwgpP9z2pj4FD dHGBR9Zn3qU79+XOUWu96Ybkyw/+IRiVNrbt/uo2VtMEWiylQzko76CFvNLG6Le4oQPaI81tetP JtrafEtcTZXkbrByiY15SiykEM2lbh8MS+MSpPm5dsBg== X-Received: by 2002:a17:90a:c914:b0:29c:70e:6ec0 with SMTP id v20-20020a17090ac91400b0029c070e6ec0mr6354650pjt.14.1711378851586; Mon, 25 Mar 2024 08:00:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeMS6FLIdATHqJhrH1KUGu5JksxEbKbY5XN2K4JQfPDsNlMqIuZJtV97WPQr9xGpNkDhabJdoBAttQrF11WZs= X-Received: by 2002:a17:90a:c914:b0:29c:70e:6ec0 with SMTP id v20-20020a17090ac91400b0029c070e6ec0mr6354628pjt.14.1711378851294; Mon, 25 Mar 2024 08:00:51 -0700 (PDT) MIME-Version: 1.0 References: <20240320-bcache-type-v1-0-fe616105e9ae@adacore.com> <20240320-bcache-type-v1-1-fe616105e9ae@adacore.com> In-Reply-To: <20240320-bcache-type-v1-1-fe616105e9ae@adacore.com> From: Alexandra Petlanova Hajkova Date: Mon, 25 Mar 2024 16:00:39 +0100 Message-ID: Subject: Re: [PATCH 1/3] Some constification in psymtab To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000820ddf06147d70d0" X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --000000000000820ddf06147d70d0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 20, 2024 at 9:24=E2=80=AFPM Tom Tromey wro= te: > This patch changes some spots in psymtab.[ch] to use 'const'. This is > just preparation for a subsequent patch. Note that psymbols are > conceptually const, and since they were changed to be > objfile-indepdendent, they are truly never modified -- which is what > makes this patch reasonably short. > --- > gdb/psymtab.c | 59 > ++++++++++++++++++++++++++++------------------------------- > gdb/psymtab.h | 4 ++-- > 2 files changed, 30 insertions(+), 33 deletions(-) > > diff --git a/gdb/psymtab.c b/gdb/psymtab.c > index a831e5eec40..f1aabd5b10b 100644 > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -37,18 +37,15 @@ > #include > #include "gdbsupport/buildargv.h" > > This patch looks reasonable and causes no regressions for Fedora Rawhide > on aarch64. > --000000000000820ddf06147d70d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 20, 2024 at 9:24=E2=80=AF= PM Tom Tromey <tromey@adacore.com<= /a>> wrote:
<= div>This patch changes some spots in psymtab.[ch] to use 'const'.= =C2=A0 This is
just preparation for a subsequent patch.=C2=A0 Note that psymbols are
conceptually const, and since they were changed to be
objfile-indepdendent, they are truly never modified -- which is what
makes this patch reasonably short.
---
=C2=A0gdb/psymtab.c | 59 ++++++++++++++++++++++++++++----------------------= ---------
=C2=A0gdb/psymtab.h |=C2=A0 4 ++--
=C2=A02 files changed, 30 insertions(+), 33 deletions(-)

diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index a831e5eec40..f1aabd5b10b 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -37,18 +37,15 @@
=C2=A0#include <set>
=C2=A0#include "gdbsupport/buildargv.h"

This patch looks reasonable and causes no regressions for Fedora = Rawhide on aarch64.
--000000000000820ddf06147d70d0--