Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: support source tracking for multi-location breakpoints
Date: Tue, 6 Oct 2026 11:41:06 +0200	[thread overview]
Message-ID: <CAJVr-EP7tCkqyrwgyiTyDRpYAiMyH831mmXXABnQbg4YBDGRDg@mail.gmail.com> (raw)
In-Reply-To: <5d354be53ea21f4da7b446c6337d694c06c475f3.1791027408.git.aburgess@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Sat, Oct 3, 2026 at 1:38 PM Andrew Burgess <aburgess@redhat.com> wrote:

> Currently, when breakpoint source tracking is enabled (see 'set
> breakpoint source-tracking enabled on'), GDB will not source track
> multi-location breakpoints.
>
> As a first take this was fine, but I think that we can support source
> tracking for some multi-location breakpoints.
>
> Source tracking only applies to breakpoints set based on a file and
> line number, so the rest of this discussion is only concerned with
> this case.  This includes things like 'break file:line' and also
> 'break line'.  In the latter case GDB uses the current source file to
> provide the filename, so the two cases are really equivalent.
>
> If we consider 'break file:line' then there are two ways that this can
> resolve to multiple locations.
>
> First, if 'file:line' lands in an inline function, and the inline
> function is inlined multiple times (or has an out-of-line
> instantiation) then there can be multiple locations.  However, there
> is only a single source line for all of these breakpoint locations,
> the original line in the single original file.
>
>
> Hi Andrew,

 I like your approach. My initial restriction on all multi-threaded
breakpoints was too broad.
It's great the source-tracking actually works for the inlined functions.

Thank you for your improvement,
Alexandra

[-- Attachment #2: Type: text/html, Size: 1929 bytes --]

  reply	other threads:[~2026-10-06  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03 11:37 Andrew Burgess
2026-10-06  9:41 ` Alexandra Petlanova Hajkova [this message]
2026-10-22 13:33 ` [PATCHv2] " Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJVr-EP7tCkqyrwgyiTyDRpYAiMyH831mmXXABnQbg4YBDGRDg@mail.gmail.com \
    --to=ahajkova@redhat.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox