From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OK/kFkv6smPaHA4AWB0awg (envelope-from ) for ; Mon, 02 Jan 2023 10:37:47 -0500 Received: by simark.ca (Postfix, from userid 112) id 52B901E222; Mon, 2 Jan 2023 10:37:47 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=c2sYylon; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AE2B21E0D3 for ; Mon, 2 Jan 2023 10:37:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2519E3858422 for ; Mon, 2 Jan 2023 15:37:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2519E3858422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672673866; bh=bd6dunpaQUvhsM6zaux4Hk8S4P75xV7Mj2YAEqusfs8=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=c2sYylonfSveRbGSxTUKjMCMiIcKw15gia3P0wyBrlUyuzAo1hz3Fq61eF8U5c/Js jcsrTmHoYv4fXzpca1oTmInECRTq6atZdVWHxoa+ELOh5XgvakMk/RUu/g7aKSlzx7 Ym/Wl6ZxegrYRlY/LbFLrfSoBtj2A0MHumpW/+ig= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E09BF3858D32 for ; Mon, 2 Jan 2023 15:37:26 +0000 (GMT) Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-227-VXEY-xvwNTG88PNLPvi4_w-1; Mon, 02 Jan 2023 10:37:25 -0500 X-MC-Unique: VXEY-xvwNTG88PNLPvi4_w-1 Received: by mail-pf1-f197.google.com with SMTP id j1-20020aa78001000000b0057d28e11cb6so13098161pfi.11 for ; Mon, 02 Jan 2023 07:37:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7IVX/5M0GuO+1AbuJxFWmndj7OmYhvTHEq6Gm2zUHsc=; b=SB2ZAW9oXyAX8wtUZ/HxKOEdAeoNj0VMGTY3B4xubf2Qeq96uCUodp2xIrdGaqsVpi L3pphpKOwF/xwYB8d6x39UujBfc+inMbhzzj/Aj4g4vpwZm8lOKsg2zB80TishHzcxcz 7DP0pAvhJcODU7VPdt9E9pMToVZfRAMMbUPJtJE32WYkhO77Zu9zIhCy8yFABzZIQwox xFHG7fFz79NQLmsJ2RCDERAHNceKK4QrHw/xabZNwzmNIwV4+Lal05x/GWoeBAe4SofA elC/KrPdvkdycwQ7FFwsfDnVzZ3EEJLHt09vgUsrXveJtmuafLuUlyF4KkiKX13VZcOA aZ6w== X-Gm-Message-State: AFqh2ko03JSTPBVpoJyQim0uWErPEDj/QIWOU22Y/EmqTDPCoOjB+kYf hGiiIU+AYCJjxu+lkWwMtdBYiRKu9RMyU1IXOb1LIcvUKTpF9SFF/p3vZTKO8SQwqNKnczypdnm 5W/hL7DUvF+/OlTCAFAYjb+sxKtVUncR2DGWyUA== X-Received: by 2002:a17:903:32c8:b0:189:e149:a1af with SMTP id i8-20020a17090332c800b00189e149a1afmr2101704plr.18.1672673843739; Mon, 02 Jan 2023 07:37:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXs4bjW/q815VgEq2APFFh+qAP3KciqU2vU5Qs6Lpc/vPiuVdIFUC0lWZT1HHESpHI29bhqwmOcQSM7eeH40tQU= X-Received: by 2002:a17:903:32c8:b0:189:e149:a1af with SMTP id i8-20020a17090332c800b00189e149a1afmr2101697plr.18.1672673843094; Mon, 02 Jan 2023 07:37:23 -0800 (PST) MIME-Version: 1.0 References: <20221222154338.2223678-1-blarsen@redhat.com> In-Reply-To: <20221222154338.2223678-1-blarsen@redhat.com> Date: Mon, 2 Jan 2023 16:37:11 +0100 Message-ID: Subject: Re: [PATCH v3] gdb: add 'maintenance print record-instruction' command To: Bruno Larsen Cc: gdb-patches@sourceware.org, Eli Zaretskii X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexandra Petlanova Hajkova via Gdb-patches Reply-To: Alexandra Petlanova Hajkova Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > +# This file is part of the GDB testsuite. it tests the functionality of > +# the maintenance print record-instruction command, but does not check the > +# syntax, only if the command finds or fails to find recorded history. > + > +if ![supports_reverse] { > + return > +} > + > I think this patch is good to go in general. But it might be nice to add a small summary about how the test works as a comment at the beginning of the test? Regards, Alexandra