From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RMfFCMMdUmVGfAUAWB0awg (envelope-from ) for ; Mon, 13 Nov 2023 07:59:47 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=adXqzOea; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1A3A91E0C1; Mon, 13 Nov 2023 07:59:47 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F413C1E091 for ; Mon, 13 Nov 2023 07:59:44 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84A933858031 for ; Mon, 13 Nov 2023 12:59:44 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 47A4D3858C52 for ; Mon, 13 Nov 2023 12:59:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47A4D3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47A4D3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699880374; cv=none; b=mHKxztOmrmYULqu3u/1pAls40Jk2+7dglbrGo/JZ2Dz3n+CxUCA+XnBrGbhTviRntuIOSmWfHG/sPmuW3XsHYne+U0N3nAZcGWwEwC6tH018JB+fO33vprqNUSMjsHxtxCiwVpzhjP30Z8/VWdYnjw05V5U72g/qlIqwEW3x4/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699880374; c=relaxed/simple; bh=dFONHFYOibRhb7EgRoxcYMFpKrfp+JZS4qhlPFHxuGI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=R9WdE9+b/KOn4mnUv/UR+1p4QFNKsV7d/xiNOqZ4JG7EQHXUjWu/Sj+IYxyhyYQLvI3/1H6DPxQGP28YYQKCEndcKs9L5o4oYurVs3JBTpCQtbm46YtGXofBms19Qw6Fxkw2efDTHw+yNPs9/GevnHAOXk4GCnZCNTj7y+8d3Ig= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699880372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PgcIIF/UhUxnl4hf2zRUlvWfwoOcro/SMKSd4pGDOCA=; b=adXqzOea1X6HvAIPD1r94cxLGopbnUtl8hpbI4m+b/yyssp8EzlAWufKOy4cq6XjhNaZIG tQgWmZVkmBJobxm8BXbItGLpntMg29zMYLPQyKTwKqpPxBc/PGys5eibNfKVd0W06GY5py s+4S9PRoCqSfV3GMbo0EAsjJgbzyGWk= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-21-B9XXvW3oOOSubNGaqzNa2A-1; Mon, 13 Nov 2023 07:59:31 -0500 X-MC-Unique: B9XXvW3oOOSubNGaqzNa2A-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-692bf04c548so4509254b3a.0 for ; Mon, 13 Nov 2023 04:59:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699880370; x=1700485170; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PgcIIF/UhUxnl4hf2zRUlvWfwoOcro/SMKSd4pGDOCA=; b=klkaIYUkmNTHLVdQ74tuRgxIXcnML2Yp8xU6oTJGWCfd0L1q9M0bZc1Coy1XwJZtzZ kirRxIkyFTCNyVcXW7FSS+dAjzEV2GFWH8JW1LsxDbwOWaxEekag6z4soIfjO1HEBbUk Yz1GBXDOZpUk6BIy9dcWqyFA3JusOabw6VevbFVDroOMSWB6Ou5tG3yz1m5fBUzZVrYB TFvKp02WWeLbHm2hU6aE3x4/eMc3aB6YR6z3pK76n5dqdIqJcAlgVvaYDsxa/pWHSZro 4KNMYtSWzQZwB9iqGbdBp3RtNymQm6WPdL9iDbIuM+d/GkbBfWboL/0i99NhjP/RYtl1 z6IA== X-Gm-Message-State: AOJu0Yw77IrVWRA/mGhjNfhdodIMbAdLlNCTUAy0sS2we+5BVLZhTwg+ Z+ZuSjlrEu/WdcZtYUZh5vJ3Fb8yhzYuD0EhqKUam+40/vENJjRitnPyKr/n9A36KoH3wX+7TmT ne30uOeMdc+2yf65xwWeM7gcsQFh36Vxm/J2fZA== X-Received: by 2002:a05:6a20:daa0:b0:186:bd68:fa95 with SMTP id iy32-20020a056a20daa000b00186bd68fa95mr1299042pzb.22.1699880370338; Mon, 13 Nov 2023 04:59:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDxCjSVfyf3DVMRkhBix70+kfIk2hQ8QpgoSxRaEQGdLFpYSySudFNr8ZfxESTxY+/rBLZ0pDLwwMiNWQT+CI= X-Received: by 2002:a05:6a20:daa0:b0:186:bd68:fa95 with SMTP id iy32-20020a056a20daa000b00186bd68fa95mr1299034pzb.22.1699880370053; Mon, 13 Nov 2023 04:59:30 -0800 (PST) MIME-Version: 1.0 References: <20231107-dap-not-stopped-v1-0-3d91c935255d@adacore.com> <20231107-dap-not-stopped-v1-1-3d91c935255d@adacore.com> In-Reply-To: <20231107-dap-not-stopped-v1-1-3d91c935255d@adacore.com> From: Alexandra Petlanova Hajkova Date: Mon, 13 Nov 2023 13:59:18 +0100 Message-ID: Subject: Re: [PATCH 1/3] Automatically run (most) DAP requests in gdb thread To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000009e397c060a083d18" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --0000000000009e397c060a083d18 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 7, 2023 at 7:29=E2=80=AFPM Tom Tromey wrot= e: > Nearly every DAP request implementation forwards its work to the gdb > thread, using send_gdb_with_response. This patch refactors the > 'request' decorator to make this automatic, and to provide some > parameters so that the unusual requests can express their needs as > well. > > In a few spots this simplifies the code by removing an unnecessary > helper function. This could be done in more places as well if we > wanted. > > The main motivation for this patch is that I thought it would be > helpful for cancellation. I am still working on that, but meanwhile > the parameterization of 'request' makes it easy to handle the > 'notStopped' response as well. > > I can confirm this commit introduces no regressions with Fedora Rawhide ppc64le. Also I like the simplification this brings. Thanks, Alexandra --0000000000009e397c060a083d18 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Nov 7, 2023 at 7:29=E2=80=AFP= M Tom Tromey <tromey@adacore.com> wrote:
Ne= arly every DAP request implementation forwards its work to the gdb
thread, using send_gdb_with_response.=C2=A0 This patch refactors the
'request' decorator to make this automatic, and to provide some
parameters so that the unusual requests can express their needs as
well.

In a few spots this simplifies the code by removing an unnecessary
helper function.=C2=A0 This could be done in more places as well if we
wanted.

The main motivation for this patch is that I thought it would be
helpful for cancellation.=C2=A0 I am still working on that, but meanwhile the parameterization of 'request' makes it easy to handle the
'notStopped' response as well.


=
Thanks,
Alexandra
--0000000000009e397c060a083d18--