From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U1KAOQ4qBGYKUBgAWB0awg (envelope-from ) for ; Wed, 27 Mar 2024 10:15:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YIUoNACZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DCE5E1E0C0; Wed, 27 Mar 2024 10:15:42 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5B081E030 for ; Wed, 27 Mar 2024 10:15:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 09CA83858C31 for ; Wed, 27 Mar 2024 14:15:40 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 477A93858C55 for ; Wed, 27 Mar 2024 14:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 477A93858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 477A93858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711548919; cv=none; b=nfW9jmPLzBY3/R4jMYchwtdHWJlSp2mT2hfHCE1oXpKtPu1IFV/JGt9udjFcT9LtkUIBLmuDMN79MrlRUkhogxyCslVixFV4PTq6yG1DF+fYmp1tXC0rfNnuWRlY/KMC667N6ckxQ6SxDpO0Q4RvCVV+HlCpccNyVxe1qAZ1dJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711548919; c=relaxed/simple; bh=1Vx0BbOneR6IvPpM3021W3yJBoFMsbBhVw9+RzEf5yc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=JTXCiN4AACSFk1g9ZNiXITaAc31r6l7KclhNI/IhHhFvpEAptT60lOK7em+TOxIEvp0L6m9l67v0oB+OjLq07xGMd7LnvgqhSBdE+gMcHsTO8VY3fGtkq4pI713a7ykIwcWmi5Q1u63p7E2xx6PKXD93ZeS30gbrNdMyZlYldYg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711548917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bLGsuKnZqj008ZEPzedxvhvQsiTouJX5ZiLc5WeQom8=; b=YIUoNACZGy+6rEG5XfQCQlSy6JI1Aj6iECnJlc/GJcAQcAP2fziBUK4L544N9hLZL3mIlv py80g2AmnIb8oinw2kK10Rvy+ZX+oy/nBmuoEnq9YuHAlIzjtMd3tL2lb2qg/177OS21ve 1P0xdTJviVsbLu92cxvjq812rMNonm0= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-NG1rRUHfNP2saCEBORuHlQ-1; Wed, 27 Mar 2024 10:15:14 -0400 X-MC-Unique: NG1rRUHfNP2saCEBORuHlQ-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-5ca5b61c841so4787463a12.3 for ; Wed, 27 Mar 2024 07:15:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711548913; x=1712153713; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bLGsuKnZqj008ZEPzedxvhvQsiTouJX5ZiLc5WeQom8=; b=UmcPGOmP3I9n4muU/U0D6KQCPaDCGMRiAzF/LZzJgyCzAD3XbDzu8Eq1xIb9lvLAUO cQiMEyrXzgReM5OzGZa4Ph7VMZg2BfAH77eiACHy8M7CRTWgGXWy3mflz8xMamV8l+6E 85PVOxYs7FO8q1o62UROSZpvyyIqdygf+odu+oItuylyvxt9QKaCHXPoUl8g/UhVwEeC FiMFS2stcKedSDKJqZq/T7+gKQP8kItXSMAha6Zsc5tLxomWAwh2KE25sJUUf2ZJ8bP/ tQj7S/TSVZ25NzbXQGJQH+ovkXkXM8EtBPSF+jOasdmUfLxkm4xRiFE8cvhR3eKC5S9L +vLQ== X-Gm-Message-State: AOJu0YwYZFaBM4M+qB4VKuawBVNsfw9PuYSYJ7+QBc6ankYFarTBZia5 cKKvviizkGLKqwhNEVYETv8eMblVjb8o3pjbCgF7xz8V39pUcX0aRLRytsKrOYXL3ski6+N5NtG hwtziHcMkv5k4Mw6p5NaDlwkcXN2VfZ7HC6ZazADlzEB9FTrJkvw2QMiG1krLZp5kln0ptNBFIv s3m3x6UzEFauCtQkyL2W3zcZ5DIQwYcmYPLA== X-Received: by 2002:a17:903:2444:b0:1e0:95c:d104 with SMTP id l4-20020a170903244400b001e0095cd104mr1517250pls.2.1711548913363; Wed, 27 Mar 2024 07:15:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFR8PkcfZ/fqVY0At7kB0IrR1KEZB454+/BSOzPsdBzjqFYqwvpQ/vVqLVYryZzaarlf1U7iIw0lGN9eVro7XE= X-Received: by 2002:a17:903:2444:b0:1e0:95c:d104 with SMTP id l4-20020a170903244400b001e0095cd104mr1517223pls.2.1711548912993; Wed, 27 Mar 2024 07:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20240320-bcache-type-v1-0-fe616105e9ae@adacore.com> <20240320-bcache-type-v1-2-fe616105e9ae@adacore.com> In-Reply-To: <20240320-bcache-type-v1-2-fe616105e9ae@adacore.com> From: Alexandra Petlanova Hajkova Date: Wed, 27 Mar 2024 15:15:01 +0100 Message-ID: Subject: Re: [PATCH 2/3] Make bcache more type-safe To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000f9adb80614a50838" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --000000000000f9adb80614a50838 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 20, 2024 at 9:24=E2=80=AFPM Tom Tromey wro= te: > The bcache uses memcpy to make copies of the data passed to it. In > C++, this is only safe for trivially-copyable types. > > This patch changes bcache to require this property, and slightly > changes the API to make it easier to use when copying a single object. > It also makes the new 'insert' template methods return the correct > type. > --- > gdb/bcache.h | 25 ++++++++++++++++++++++++- > gdb/gdbtypes.c | 2 +- > gdb/macrotab.c | 12 ++++++------ > gdb/psymtab.c | 6 ++---- > 4 files changed, 33 insertions(+), 12 deletions(-) > > > I can confirm this change does not cause any regressions on Fedora Rawhid= e aarch64. --000000000000f9adb80614a50838 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable --000000000000f9adb80614a50838--