From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CiBMCLT9q2THwRwAWB0awg (envelope-from ) for ; Mon, 10 Jul 2023 08:46:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=VMo3B6eO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1345C1E0BD; Mon, 10 Jul 2023 08:46:44 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EDADC1E00F for ; Mon, 10 Jul 2023 08:46:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C523D385E017 for ; Mon, 10 Jul 2023 12:46:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C523D385E017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688993200; bh=CcIkeC6JiVQnZb1x+qyzjnbZxySK/ERt8QaqqloYYi0=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VMo3B6eOuNmNXUtX4gjLMM/7u1HAe7hFE7JYKqR0XO1mD7UGIqvyLzVJ7ZxYeVx// 7WkwSGLngpOWW8ufg3n6JGrQlkm8i4oV8pgds0O4Otwt1dWFafCIQfJZSCzVQeZBhQ hr26nUzC0UtjWws/M1m5lQORQE1YeRndePjsIONI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 067523853D3D for ; Mon, 10 Jul 2023 12:46:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 067523853D3D Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-TnneiB66O6iwuiWyAu_2NQ-1; Mon, 10 Jul 2023 08:46:20 -0400 X-MC-Unique: TnneiB66O6iwuiWyAu_2NQ-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-565d30b4311so3344472eaf.1 for ; Mon, 10 Jul 2023 05:46:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688993179; x=1691585179; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4bOSS7zBtWMRqWlZTI9Bs5s0vLXhktji12wpZcMni/8=; b=iCWHsU6ZvsXqpBj0POir+8jKNGQP6VuiEU2mKpFrBEVvqwB+jEWdunsemU4gWzpWSL naebzBshfi1S4Wst98DKT3VwcwrszziS45GOVXf4aA9D+W62q714JsfxLVr/BrL/Dw4S k9IUFTSGDNWqUAjxEA/bGtTat1is3vMKPQxu3G9ACtn8lLIpswo5dWjyVYoVJyqS0Dsk wwkXV6OpHao7ahydui2dwSbkVsZh3Pd+0i+LHswfGlDNOGeSFzOMwbHutajlUEyJP5Ah 5H5iMF47+r2iJtdWraCczyIPdcQq/1zp9CJomWUe2kj6OrW8w/U4N4y7ezhi87aKlYeO Tj+w== X-Gm-Message-State: ABy/qLYP55lAs1CM5LYhKsAaCPrcLswBdO6qBKaVFIVISW4bAB+/ItAn g97ZJvY0rPhNfNglGxaZAlShVhckDEfR0xX15F/g/lNVlSkjoKjDd8WgntElYvviUOuUwmnqGUe +YQvdPZHdMtG9N+1HqxcHjHU0bErT0+w5UBvipKABpBqvVA== X-Received: by 2002:a05:6870:b52b:b0:1b3:dc5b:13c7 with SMTP id v43-20020a056870b52b00b001b3dc5b13c7mr14424545oap.43.1688993179334; Mon, 10 Jul 2023 05:46:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlGA5+Q5zTqB9lUnco7lfz6o+aq7pCiasbTls7ESxl7Ymxpd26apUgeBV2DTsmKVk8I+dtfFRdTR9rI5YNjsJwM= X-Received: by 2002:a05:6870:b52b:b0:1b3:dc5b:13c7 with SMTP id v43-20020a056870b52b00b001b3dc5b13c7mr14424535oap.43.1688993179023; Mon, 10 Jul 2023 05:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20230703030458.1192525-1-zhiyong.yan@windriver.com> In-Reply-To: <20230703030458.1192525-1-zhiyong.yan@windriver.com> Date: Mon, 10 Jul 2023 14:46:07 +0200 Message-ID: Subject: Re: [PATCH] gdbserver: Install single-step breakpoint for a pending thread whose last_resume_kind is resume_step To: zhiyong.yan@windriver.com Cc: gdb-patches@sourceware.org, tom@tromey.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexandra Petlanova Hajkova via Gdb-patches Reply-To: Alexandra Petlanova Hajkova Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, Jul 3, 2023 at 5:05=E2=80=AFAM wrote: > From: Zhiyong Yan > > Gdb should not assume pending threads always generate =E2=80=9Ca non-gdbs= erver > trap event=E2=80=9D, for example =E2=80=9CSignal 17=E2=80=9D event could = happen. Now that > resume_stopped_resumed_lwps() -> may_hw_step() assumes that the break poi= nt > must already exist, resume_one_thread() should ensure the software breaki= ng > point is installed although the thread is pending. > > Signed-off-by: Zhiyong Yan zhiyong.yan@windriver.com > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30387 I can confirm this patch causes no regression Fedora-Rawhide, ppc64le.