From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 94E4738708C5 for ; Tue, 21 Jul 2020 18:11:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 94E4738708C5 Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-ChLxykL_M0KMT2DGR2jbZQ-1; Tue, 21 Jul 2020 14:11:21 -0400 X-MC-Unique: ChLxykL_M0KMT2DGR2jbZQ-1 Received: by mail-ua1-f71.google.com with SMTP id n4so4190843uaq.17 for ; Tue, 21 Jul 2020 11:11:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WdMbXfMiyvjKM507HjAPhv+xeCjDhOtu5X5lBeHTF6k=; b=tYBfU92XodumwBnqatevY2gL7FRnONA7m/wnmVaBFmxIo1ozCyyZrgWTksGWlD+ytT 0ZcgHuZ/jYhQxLNpbbpNWMs37IurLavKNsBZLYczyEXMZDTefLOSO9EsnSySb5xQkoz0 Z+w1850f31Ua+NogaTmSNDS9pgUS6KRopgN1WCpEL3cTOXmbgS+1JZAB6bYKxXD3gNvm 5phDreicfNKTBljiJooFRbnnyoZGZRAqSEyBYGdVnxzF2TDJZJIUAuBGuf0QUgKhA+jD RHahP50ItA7asGLMe5McSBfpTohHvMDvJNVqSWdL2k0QhZ35WqLnCA6uKSGkgAQgvuQH bsDw== X-Gm-Message-State: AOAM531yQqM1F0gg9nL11eWi/avQKNayC8mT71txv5TpbNV5hHs/CvDB gPOmKWXw+V9Ali4NvEEZU1EzntYH6lcSgzlHGYBuw6qohXjNcm7hs1DDofgOXbvhyckswvWEPiH mesf4lPfYFI9aF/dh/3rX7xp+kg1s2aO6nneD X-Received: by 2002:a1f:1943:: with SMTP id 64mr20849774vkz.40.1595355081444; Tue, 21 Jul 2020 11:11:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAjcZxAPzabi1YDC1aPaEvTY0cBxDVoHhnhn4nCopcZXSmBFnEZ1uvSyQCevGWsWuyBN8Cv2TtEVbPzrcUbFE= X-Received: by 2002:a1f:1943:: with SMTP id 64mr20849764vkz.40.1595355081236; Tue, 21 Jul 2020 11:11:21 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <3d9da16939fa6b503188033b56d30531e03d5d2a.camel@redhat.com> <87a72ino27.fsf@tromey.com> <64517fee-8b8f-84b2-a116-c3d146ff1119@simark.ca> <87eep4hp3s.fsf@tromey.com> In-Reply-To: <87eep4hp3s.fsf@tromey.com> From: Aaron Merey Date: Tue, 21 Jul 2020 14:11:10 -0400 Message-ID: Subject: Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES To: Tom Tromey Cc: Simon Marchi , Aaron Merey via Binutils , Jeff Law , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 18:11:25 -0000 On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote: > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? > > Simon> Otherwise, from GDB's point of view I think it looks good, unless > Simon> Tom has some things to add. > > I'm happy with it. Thanks for persevering. Great. I can push to binutils-gdb but not gcc. Should I just push to binutils-gdb for now or wait until the patch can be applied to both repos at once? Aaron