From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 59E873857C47 for ; Fri, 24 Jul 2020 20:03:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59E873857C47 Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-3WncNkAcMsy-cC9b-IOfYQ-1; Fri, 24 Jul 2020 16:03:25 -0400 X-MC-Unique: 3WncNkAcMsy-cC9b-IOfYQ-1 Received: by mail-vk1-f200.google.com with SMTP id v68so3342637vkf.13 for ; Fri, 24 Jul 2020 13:03:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZgeC7i6J+c7VsecOY62PZLfgCwdL2V3v61S+CG0PtGU=; b=V3h/gHvHcBDfrQgeGVQyH9ONK3ICIoxTGL10xFsZOG9DY22ebuKTuFHV+JP/NXPX00 9qdy6S3lI40ZFZNq3gtS9EnFqE1LgNg0gTYy/bCMT+jD11uFn/hFkW85vJYP5t1wNrI+ 0vlX7/geosFWBv2Pca/iXCVOwLLNdenHaQXIv1NJQXeQqPLfT3IDY3hDvm3lbUizNwrX htF8ny+LjgWvTsFmmIZWkxMwcR/HoY5HDz920TWlCAuFE7RfcdE+j2dS8U04d+5KgD2A FrKTYvm/ygJ5HEPmtg3JjieINjHHhCoI/zrL84J6B3Us4tIcCyfcAytLQVWAo8kTXEL7 02Dg== X-Gm-Message-State: AOAM532NweRahHaNU4I2HWyJU0fkVam/HrvuqL0eME07Atn94Gp6k+3y DeO2O4Ji7EujjRXgxTvgb4Ug5x/F5uo21QjRQAiVj9kH9403r2oNNtx8xB4EftTKtH4tjVVTIyn n1JOEo7sca8+49Syem8nfDIeIFzLIKo3Sd/3A X-Received: by 2002:a05:6102:53c:: with SMTP id m28mr9150936vsa.118.1595621004586; Fri, 24 Jul 2020 13:03:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7atOQ0ATIYKwfLIE5DdeH1xcDrWXr/ZRfup+9sH9BWgecpnzE14WeZ7hsfoyIfl+SY8V7zwcTsTYFfp7mkqM= X-Received: by 2002:a05:6102:53c:: with SMTP id m28mr9150915vsa.118.1595621004349; Fri, 24 Jul 2020 13:03:24 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <3d9da16939fa6b503188033b56d30531e03d5d2a.camel@redhat.com> <87a72ino27.fsf@tromey.com> <64517fee-8b8f-84b2-a116-c3d146ff1119@simark.ca> <87eep4hp3s.fsf@tromey.com> In-Reply-To: From: Aaron Merey Date: Fri, 24 Jul 2020 16:03:13 -0400 Message-ID: Subject: Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES To: Tom Tromey Cc: Simon Marchi , Aaron Merey via Binutils , Jeff Law , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jul 2020 20:03:28 -0000 On Tue, Jul 21, 2020 at 2:11 PM Aaron Merey wrote: > > On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote: > > > > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put the include > > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac? > > > > Simon> Otherwise, from GDB's point of view I think it looks good, unless > > Simon> Tom has some things to add. > > > > I'm happy with it. Thanks for persevering. > > Great. I can push to binutils-gdb but not gcc. Should I just push to > binutils-gdb for now or wait until the patch can be applied to both > repos at once? I'm going to go ahead and push to binutils-gdb. Since these changes should not affect gcc there shouldn't be any conflicts. Aaron