From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MGrmFTVsw2Y/wQwAWB0awg (envelope-from ) for ; Mon, 19 Aug 2024 12:00:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eeis3i7D; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 542121E0D0; Mon, 19 Aug 2024 12:00:53 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F9601E08C for ; Mon, 19 Aug 2024 12:00:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5FC6384A494 for ; Mon, 19 Aug 2024 16:00:50 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B2BB4384A84B for ; Mon, 19 Aug 2024 16:00:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2BB4384A84B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2BB4384A84B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724083234; cv=none; b=nIkAH3UZKGzTlzlmZZXAi8JMKBTtGPd3jp2vDDUOcqr5jUJb/O7zYvdoyFdnhxaqbors7xrw+BB4Cg858lF5IWXEtAD6+ETtZvmXY3TQxA2oQ6mKxtDLeWKH7uZAIw+OAJylHwh6r0tIYpsST+Jry7/hycZaSf3Ez2yjbl+sS4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724083234; c=relaxed/simple; bh=xrAnvQYJ2IbTPQls+5PnP5AG8FrE9gJZ/FrtYz1nU1I=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=TB092nqRWcnlQ9Bqbx7616ct6Gy7hQ4pyA/ioysROKeYYjqT9FsSnqq7xr8MZRF91om037SE4NPNtJqNr7C0W0FpHFts65zS2OCpGhGfQrGAXPvB7OwFaKwF5rlKrUUiwEDi6TKm0RcTXtoQji51k9WKU2jFuBhQzXD2EOCmanI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724083232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ig9qrjOq1v4w3Fysmx5nAcNBtnEnnOgOUtytt4aMeeI=; b=eeis3i7DJBtdp9p5MVjEvjpfS6twX1YpyieRkgeeYEOybxuYCcOHnX8qAcmgY4ZxR/N/Au zTrzl197NdBJhEsFUYI4CLGXKoBToBLZskUrVxuGw0aJJJ5q5f/a7PYlE/VU7HyTVcgF2o D+0LoztFmFUsxs/sQLf6O0wt5V10JTY= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-b7ujEEdMO8iuuOE94a6iNQ-1; Mon, 19 Aug 2024 12:00:30 -0400 X-MC-Unique: b7ujEEdMO8iuuOE94a6iNQ-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-81fb21a0e41so442701539f.2 for ; Mon, 19 Aug 2024 09:00:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724083230; x=1724688030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ig9qrjOq1v4w3Fysmx5nAcNBtnEnnOgOUtytt4aMeeI=; b=r2xmOa7gBUk2lQLTkDk4Damy2zAf7eUD36/MV/1X5xiONIbwmy71UJw6bafIIztVch UaiKlclR6R2bGLCiN/WPjOwydJaETxXYOqGuH7W7vcldTWA22pKfhBq6+bGWwXnfXVSk 1Lz5iI6HOb/90Z0qWKRnkNFhkNUCKym7lkcd5yIewK6dRwBhLa3DVpp9L/5ecTqKta5r omiB+5MK00Sjfavrjuf4xZv02P/KWeXyT2cwtT0gPxK3ogmRAwsWQKzsUp0UIIPMobpE Lo9KsydSgX95eRiNe50T0LPwLxN5RZ8wcCAanRco1WJi5GWrVGjtV1WR4BQeKPNgfuq3 k49Q== X-Forwarded-Encrypted: i=1; AJvYcCU1fg8B/2Gb7GPzKffDM5NQFy/D5RFqT8SWly5iS2+D9duHljsZ49eiOn6rwJqmCj4Eta400S0TJdv5Q12mTfHPn+Ccib4SfTs2iw== X-Gm-Message-State: AOJu0YxGwNoolk/YIx6akndZWGya+ZeyjoCrbD2rmKWkFmpRKwjTP/br C2TITpOZxul57YWuw5o+buF0t5yeLw1A0tlsorjRFHfTyw5pN9/JYyrLGyo3IwNoeUMGq2Kg+y+ mR2ej1366/9F+KkxkFzNm1SmtEbgRAja1riVEtvUfOZgvVrljq4zeSC7f3VTk7k/NgW5AYuvwtx 1AOvjN9IxIOdU4i7LosZOv2kunKxoEiyFC X-Received: by 2002:a92:c249:0:b0:39a:e8cf:80d0 with SMTP id e9e14a558f8ab-39d26d05f4bmr123148175ab.14.1724083230226; Mon, 19 Aug 2024 09:00:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTlAoNImFyPRG2iq35wT8NpqbCYaUssk2y1QBrC47V94nIDzj/bjqNcKz3zy9qT9AJGulGgFli2SPjg7q1puk= X-Received: by 2002:a92:c249:0:b0:39a:e8cf:80d0 with SMTP id e9e14a558f8ab-39d26d05f4bmr123147555ab.14.1724083229671; Mon, 19 Aug 2024 09:00:29 -0700 (PDT) MIME-Version: 1.0 References: <20240313201827.1853989-1-amerey@redhat.com> <878r2lm1un.fsf@tromey.com> <22883d8d-b634-4e71-802c-239114d01279@simark.ca> <87r0gclw9w.fsf@tromey.com> <3c44e27f-22fe-49ce-ad64-a48ad5cff9f0@suse.de> In-Reply-To: <3c44e27f-22fe-49ce-ad64-a48ad5cff9f0@suse.de> From: Aaron Merey Date: Mon, 19 Aug 2024 12:00:16 -0400 Message-ID: Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev To: Tom de Vries Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, On Sun, Aug 18, 2024 at 3:10=E2=80=AFPM Tom de Vries wro= te: > > On 8/14/24 16:47, Tom de Vries wrote: > > On 3/14/24 18:45, Aaron Merey wrote: > >> We should be able to reproduce this in a testcase by overwriting part = of > >> a small binary with zeros. I'll resubmit the patch with a testcase. > > > > I ran into this problem as well via PR32081 (where correct debuginfo is > > read incorrectly). > > After writing the test-case for this patch ( > https://sourceware.org/pipermail/gdb-patches/2024-August/211114.html ) I > realized it would be easy to modify it to trigger (a form of) this > problem. Result attached. > > Feel free to ignore this, incorporate this into a v2, or suggest to me > to submit a v2 in case you don't have the bandwidth to work on this any > time soon. Thanks for the testcase. Sorry for not following up with this sooner, this task kept getting put on the back burner. I'll submit v2 with your test. Aaron