Re: [PATCH 1/1] Add debuginfod support to GDB

Aaron Merey
2020-01-10T16:46:18Z

On Fri, Jan 10, 2020 at 9:23 AM Tom Tromey <tom@tromey.com> wrote:
> Ok. Well, if you want to keep that, then you'll also have to submit the
> top-level changes to GCC and get them approved there. gcc and
> binutils-gdb share the top-level configury. It's canonically maintained
> in the gcc repository; on occasion we do land a patch in binutils-gdb
> first, but normally the process is to land there first.

Ok good to know. Like you said it's more convenient to have debuginfod.m4
local to gdb. But since the binutils configury uses it too, maybe it's worth
submitting this change to GCC to minimize duplication.

> >> A lot of this code is duplicated in 3 places. I think it would be
> >> better to have a helper function to consolidate the shared code.
>
> Aaron> Agreed, is gdb/gdbsupport/ a good place for this helper?
>
> No, since gdbserver won't use this code.

Ok how about gdb/debuginfod-support.h then?

Aaron