From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39103 invoked by alias); 10 Jan 2020 16:32:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39092 invoked by uid 89); 10 Jan 2020 16:32:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 16:32:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578673923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1YPOcc5/3pUGq2GDNkn85G5SS2xHDucPSkJqCe/aR28=; b=UobyBxeyqMkUbdXw+b1nwVJ6SplVEQwpNrl8D7Vy0S8XuT/la61hpz+gBss0RUb1luavNa h6+eaU5fkKH/mMqz70zhXov1RCrsn8lG08/HB5u5yNpAqU3dCG0soTo2S2NuDpGWwM+m2l ue82k4olkUZwh3MJm+rpvM0FawMjWqE= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-UOJQeGuUP2W-rfTpR9H_Tg-1; Fri, 10 Jan 2020 11:32:02 -0500 Received: by mail-vk1-f199.google.com with SMTP id l188so1045665vke.15 for ; Fri, 10 Jan 2020 08:32:01 -0800 (PST) MIME-Version: 1.0 References: <87h814r6p4.fsf@tromey.com> In-Reply-To: From: Aaron Merey Date: Fri, 10 Jan 2020 16:32:00 -0000 Message-ID: Subject: Re: [PATCH 1/1] Add debuginfod support to GDB To: Christian Biesinger Cc: Tom Tromey , gdb-patches X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2020-01/txt/msg00255.txt.bz2 On Thu, Jan 9, 2020 at 6:28 PM Christian Biesinger wrote: > On Thu, Jan 9, 2020 at 4:41 PM Aaron Merey wrote: > > The reason for the top-level AC_DEBUGINFOD is to prevent the top-level > > configure check from succeeding in cases where --with-debuginfod is > > given but the debuginfod library or header cannot be found. > > Why is debuginfo special in that way? There are a lot of other > libraries in the same situation. It was recommended to me on binutils@ that the top-level configure check should fail if --with-debuginfod is given but not installed. https://sourceware.org/ml/binutils/2019-11/msg00371.html Despite that I can remove the top-level AC_DEBUGINFOD to match the behavior of other configure options. > Now that GDB is C++, I'd move the declarations to where the variables > are used, e.g.: > debuginfod_client *client =3D debuginfod_begin (); > > + if (client !=3D NULL) > > nullptr > > +++ b/gdb/elfread.c > > same here Ok. > Don't you also need to update gdb/README (the `configure' options > section) and doc/gdb.texinfo (@node Configure Options)? gdb.texinfo was updated in this patch but not README, will fix that. Aaron