Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PING][PATCH] gdb/elfread.c: Use bfd filename instead of objfile->original_name
Date: Tue, 30 Aug 2022 20:45:41 -0400	[thread overview]
Message-ID: <CAJDtP-Scy+t+g9QverpZjjNHBDgywdi1G4c7vUYQvK1mm9owHA@mail.gmail.com> (raw)
In-Reply-To: <87sflda9wd.fsf@tromey.com>

On Tue, Aug 30, 2022 at 2:01 PM Tom Tromey <tom@tromey.com> wrote:
> Thanks, this is ok.

Thanks, pushed as commit 803584b96d9.

> >> > In some cases original_name is prefixed with gdb's working directory
> >> > even though the objfile is not located in the working directory.
>
> Offhand this seems bad.

It looks like this can occur when gdb_abspath converts an executable name
to an absolute path in the objfile ctor.  For invocations like `gdb prog`
it assumes the user meant `gdb ./prog` even when prog is found somewhere
else.

Aaron


      reply	other threads:[~2022-08-31  0:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 20:07 [PATCH] " Aaron Merey via Gdb-patches
2022-07-05 22:43 ` Aaron Merey via Gdb-patches
2022-08-26 21:24   ` [PING][PATCH] " Aaron Merey via Gdb-patches
2022-08-30 18:01     ` Tom Tromey
2022-08-31  0:45       ` Aaron Merey via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJDtP-Scy+t+g9QverpZjjNHBDgywdi1G4c7vUYQvK1mm9owHA@mail.gmail.com \
    --to=gdb-patches@sourceware.org \
    --cc=amerey@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox