From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47496 invoked by alias); 20 Feb 2020 19:55:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47433 invoked by uid 89); 20 Feb 2020 19:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 19:55:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582228517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7hHZJGB99qB6GLE62NbTCr4KfzaX4L2lrqHuOQADLvc=; b=EbcAGItQ2VHecf7QI+9SCZ/Dgu+AsawRzvBdN82GKn6SUIRIx0X4ZZa3YEBcgOC+e+p3Gb AVtHDkBxDXnqAIErvBchUtjUc4s9nDfHGgPHVAEn/ROuAMgPWb6MX3A5QKsZ6Fx/2mBv8T cAQUkmCipmna5ogjBJshgGwZfRi8jSc= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-q2fZYZ-0OvOL6IHM70o9DA-1; Thu, 20 Feb 2020 14:55:13 -0500 Received: by mail-vs1-f71.google.com with SMTP id s23so652545vsl.9 for ; Thu, 20 Feb 2020 11:55:13 -0800 (PST) MIME-Version: 1.0 References: <4d971725-4f83-a1d3-80a2-9e54a78c6e56@simark.ca> <871rqphwo8.fsf@tromey.com> In-Reply-To: <871rqphwo8.fsf@tromey.com> From: Aaron Merey Date: Thu, 20 Feb 2020 19:55:00 -0000 Message-ID: Subject: Re: [PATCH v3] Add debuginfod support to GDB To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org, Christian Biesinger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2020-02/txt/msg00838.txt.bz2 On Thu, Feb 20, 2020 at 2:43 PM Tom Tromey wrote: > >>>>> "Simon" =3D=3D Simon Marchi writes: > Simon> Following a discussion on IRC, I changed my mind, the simplest sol= ution > Simon> for now would be: when the user cancels a download, GDB will conti= nue > Simon> as if debug info was not available for that objfile. However, I w= ould suggest > Simon> printing a message saying that the download of debug info for XYZ = was cancelled, > Simon> so the user is not surprised to not have its debug info. > > Wouldn't this imply also clearing (or more precisely - not preserving) > the quit flag in the interrupt case? > > It seems to me that as long as the interrupt is processed by the > library, then we wouldn't want to set the quit flag again. Otherwise > that will look like a double interrupt. I'm going to change the interrupt handling to not preserve the quit_flag in cases where the inferior is not running. The download will abort and gdb will continue as if no debuginfo/source was found. If the inferior is running and ^C happens during a download, quit_flag will be preserved and the inferior should see ^C. If ^C happens a second time during the download then it will abort. This will be accompanied by some help text so the user knows what's going on. This is my understanding of what was discussed on IRC. Aaron