From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X6x3NSQnlGDAKQAAWB0awg (envelope-from ) for ; Thu, 06 May 2021 13:28:04 -0400 Received: by simark.ca (Postfix, from userid 112) id CF7C21F11C; Thu, 6 May 2021 13:28:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9F1211E54D for ; Thu, 6 May 2021 13:28:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 246573846077; Thu, 6 May 2021 17:28:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 246573846077 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620322083; bh=YXyIKMgEXJfcZPZ0sI/SGX1OZrx6SmxFj4zRmnVEeco=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KFc+tZlUOayFhfcm6M74xprYP3yc6s5wrz70inD6VNT5QQmkfizKqtHzVfiiUJkaa YQMwjcmckPpE1om0wthn8d0R0HTo6bdZ1nbcJOxo3iEaxGb9ZuEmQswkNjqQrshgA5 2KOr5VZ5KStC9rI0NQTIPRWmNoFtxSwuNv2JtDxo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0C2F8385E000 for ; Thu, 6 May 2021 17:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C2F8385E000 Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-xD7oVqfmNpm5LW9TZkNEew-1; Thu, 06 May 2021 13:27:57 -0400 X-MC-Unique: xD7oVqfmNpm5LW9TZkNEew-1 Received: by mail-vs1-f71.google.com with SMTP id s26-20020a67c39a0000b02902274964b0a0so3048484vsj.19 for ; Thu, 06 May 2021 10:27:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YXyIKMgEXJfcZPZ0sI/SGX1OZrx6SmxFj4zRmnVEeco=; b=R+QRTOuWkbEJWpfdQ/riZRgEmfgDsXJhtpna+qojTsfl89F9bPVTJhYCFc7sEVsHac BWj4iaC3vRJwOVu0Ao3o5a0l2sfskAZZ6GwEao4TZKveL3X1P/tNv5qEPJKqJIW63+Vc FdZmkekj2uBbLcPqMnM1FfBMylugSfJgP+1w9fwyeGdgqsYqiDvg5jYLDiTiY0ydya9B l3hPh0vArKRX4GrtpZmJ+AhooRyiKDbrX2961VmO8agleTXNPOmJKUWAImtM6NJ68bcC YkSR6NX5Is6UFwmRSDweKYA+49zPIc0FB/1odxBOn/FsMBJHe3pdAMSlCy/1YrhscGij uNOw== X-Gm-Message-State: AOAM532WGaGht5pdkkPrz9vA6phe1/xtKNDkGQfASFqnBawbgP9cLoyX MA5QBgaG3qk/Lsg9A2dIwZKJchpMtiEDkmKEHJSPYuwb/XZ12y7+L3SH7eUtlbzRO/mvH5ux+jS 14tGWHYrygFQXIxCK5skNZ6j+oZ/D6BS6MJAj X-Received: by 2002:ab0:77c1:: with SMTP id y1mr5356974uar.89.1620322077198; Thu, 06 May 2021 10:27:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydcF+EjHS/VP0dgIqE5oWxazszY0JjrSZbXf1aQhIZFnC97YmJ8YatWGI2/Xcc5+0wEDOpErjkBaoc5tLURYs= X-Received: by 2002:ab0:77c1:: with SMTP id y1mr5356954uar.89.1620322077013; Thu, 06 May 2021 10:27:57 -0700 (PDT) MIME-Version: 1.0 References: <20210430235735.1371915-1-amerey@redhat.com> <87eeek1y07.fsf@redhat.com> In-Reply-To: <87eeek1y07.fsf@redhat.com> Date: Thu, 6 May 2021 13:27:46 -0400 Message-ID: Subject: Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client To: "Frank Ch. Eigler" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Aaron Merey via Gdb-patches Reply-To: Aaron Merey Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wed, May 5, 2021 at 8:56 PM Frank Ch. Eigler via Gdb-patches wrote: > > Will there ever be a need to finalize this object? Like, shut it down > > cleanly in some way? > > Nope (except perhaps if running gdb under valgrind?). Running gdb under valgrind appears to work properly and no debuginfod-related leaks are reported. If there aren't any other concerns then I will merge this patch with Tom's suggestion to define global_client in debuginfod_init() included. Aaron