From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uHCcOlKn8GFmCwAAWB0awg (envelope-from ) for ; Tue, 25 Jan 2022 20:43:46 -0500 Received: by simark.ca (Postfix, from userid 112) id ED6211F3B6; Tue, 25 Jan 2022 20:43:46 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D87C1EA69 for ; Tue, 25 Jan 2022 20:43:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 00C603851C0C for ; Wed, 26 Jan 2022 01:43:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 00C603851C0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643161426; bh=klSb9KX0EmexqtcHN1F9o2m2yB2og0kOtnMQWYN+UtY=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=i+5EOHkjzbI8y/xJuCcVHWQ6q68g80622AY8UvVMqCOtSA0MD2XHN7F1+PSq7LcXd HmWKGXegztOugNnReAujBMgZzLgUJCQFyXqG+xZp8GAiG3C2eRZcYCzBsZjrATJ57W cWx9SxejiYL47FobQzJdrdt67FMnxTgQlmqtuDnw= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B3DF53858C60 for ; Wed, 26 Jan 2022 01:43:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B3DF53858C60 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-Enp-gB19OiGd5f3nCawEOA-1; Tue, 25 Jan 2022 20:43:25 -0500 X-MC-Unique: Enp-gB19OiGd5f3nCawEOA-1 Received: by mail-qv1-f69.google.com with SMTP id hu4-20020a056214234400b0041ad4e40960so23434896qvb.13 for ; Tue, 25 Jan 2022 17:43:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=klSb9KX0EmexqtcHN1F9o2m2yB2og0kOtnMQWYN+UtY=; b=RehfjvF3GHzzoKcFBdLga3TJUrcDHbwjQTYo58puqePkmJSW5x/68kFCTBngGPOXhB 7lam1g+vWNG4FXXC3s/YHnmhs3UzFcbkPT2NAnP2Ed7+8KC8fyv2xGYr24l2W3Ufs5be kQXNguCc3qAKt5vfc7hSbjp6Xn/uIj73JjpW/FDSc6LaxgbjApeDHUBUbbbDOiXLjo7G 6+7Ix/eVnlannx9D+6PeZKd6GC44K5E7ymPbJgDIjpYhyKRjJqHVmDGtNQek5kOK9Ehs Mq3vJpjoT9S5l+N488at3pXepfAEJjuJuwt5LwUxsd2bu67BTgDWhZUxQk2eEYyezQIZ vkxw== X-Gm-Message-State: AOAM532qwl3IVS1YNNAQraiRSJqIL3893LVNb69ujbK0tUSS4ppiqCTY wls+mh4HwUULYDlpeIQ/hY6kSslhjsYJDl4TjHEkYyugXpv5O72V4D3SgRTIw4z/u0WZ7jNus52 B1eKYGDmQKQcd5b4SxZ9Af1/fKh7icjdTCl2F X-Received: by 2002:ad4:5ceb:: with SMTP id iv11mr4377214qvb.99.1643161404649; Tue, 25 Jan 2022 17:43:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkEhGFyCENUMGa4lSqgQrHxRMrC456hms+LEMHVQbJSZWdJ/kE2UECdBpKn3LsKeuivuSsAmXPSE1vVkis/8o= X-Received: by 2002:ad4:5ceb:: with SMTP id iv11mr4377206qvb.99.1643161404375; Tue, 25 Jan 2022 17:43:24 -0800 (PST) MIME-Version: 1.0 References: <20211120004140.737744-1-amerey@redhat.com> In-Reply-To: <20211120004140.737744-1-amerey@redhat.com> Date: Tue, 25 Jan 2022 20:43:13 -0500 Message-ID: Subject: Re: [PATCH] PR gdb/27876 - debuginfod-downloaded source files don't pass proper fullname across mi / (gdb)info source To: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Aaron Merey via Gdb-patches Reply-To: Aaron Merey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Ping Thanks, Aaron On Fri, Nov 19, 2021 at 7:42 PM Aaron Merey wrote: > > Source files downloaded from debuginfod currently use their original DWARF > filename as their "fullname". This causes a mismatch between the fullname > and the actual location of the source file in the debuginfod client cache. > > MI consumers such as VSCode will fail to open debuginfod-downloaded > source files due to this. Also 'info source' will fail to include the > true paths of these files. > > To fix this, use the debuginfod cache path as the fullname for debuginfod- > downloaded source files. > --- > gdb/debuginfod-support.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c > index 2e1837da949..3f57b5d50cb 100644 > --- a/gdb/debuginfod-support.c > +++ b/gdb/debuginfod-support.c > @@ -201,6 +201,7 @@ debuginfod_source_query (const unsigned char *build_id, > if (c == nullptr) > return scoped_fd (-ENOMEM); > > + char *dname = nullptr; > user_data data ("source file", srcpath); > > debuginfod_set_user_data (c, &data); > @@ -208,7 +209,7 @@ debuginfod_source_query (const unsigned char *build_id, > build_id, > build_id_len, > srcpath, > - nullptr)); > + &dname)); > debuginfod_set_user_data (c, nullptr); > > if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT) > @@ -217,7 +218,7 @@ debuginfod_source_query (const unsigned char *build_id, > styled_string (file_name_style.style (), srcpath)); > > if (fd.get () >= 0) > - *destname = make_unique_xstrdup (srcpath); > + destname->reset (dname); > > return fd; > } > -- > 2.33.1 >