Re: [PATCH] [PR gdb/27026] CTRL-C is ignored when debug info is downloaded

Tom Tromey
2021-12-01T16:45:49Z

>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Aaron> + gdb::optional<target_terminal::scoped_restore_terminal_state> term_state;
Aaron> + if (target_supports_terminal_ours ())
Aaron> + {
Aaron> + term_state.emplace ();
Aaron> + target_terminal::ours ();
Aaron> + }

I was curious to know if the gdb::optional and the
target_supports_terminal_ours checks are really needed here.
I think plenty of spots do this stuff unconditionally, so I
was wondering if this code has some special need.

Tom