From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126289 invoked by alias); 1 Nov 2019 21:03:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126280 invoked by uid 89); 1 Nov 2019 21:03:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=our X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Nov 2019 21:03:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572642221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pbh01eW14IudqIB9gZPXjg0+KFTDg9VutF9pii2OcnM=; b=IKlL42M8ygKVdIWn+CYFsl2BnrkNZ1wCgU0wToKspcEd6MwnHHAwMFvmSWXHYGDm+kWtIe iMFJeIfLCFA+3McPPgbGajtUgh9gQoavgzCEV0wH+4ef9zYDeyeeGDYN3FXI8OHum3+YgQ PweF0R6QUb7qp6GgjyU0mwesMOw3J1o= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-Np0y8iiNMPK5KF14ErHKAg-1; Fri, 01 Nov 2019 17:03:38 -0400 Received: by mail-vk1-f200.google.com with SMTP id u64so4349060vke.18 for ; Fri, 01 Nov 2019 14:03:38 -0700 (PDT) MIME-Version: 1.0 References: <20190820202809.25367-1-amerey@redhat.com> <87pnj6dl3k.fsf@tromey.com> <87sgn71ji6.fsf@tromey.com> In-Reply-To: <87sgn71ji6.fsf@tromey.com> From: Aaron Merey Date: Fri, 01 Nov 2019 21:03:00 -0000 Message-ID: Subject: Re: [RFC PATCH] Support debuginfo and source file fetching via debuginfo server To: Tom Tromey Cc: Christian Biesinger via gdb-patches , Christian Biesinger X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-11/txt/msg00044.txt.bz2 On Fri, Nov 1, 2019 at 3:31 PM Tom Tromey wrote: > Aaron> domain name resolution). However ctrl+c does not interrupt our sym= bol > Aaron> downloading within GDB. This may be due to GDB's SIGINT handling, > Aaron> which just sets a flag for the event loop when it is not safe to > Aaron> throw an exception. Based on a comment in > Aaron> gdb/event-top.c:handle_sigint(), symfile reading is one such regio= n. > > Aaron> Also, we have an environment var $DEBUGINFOD_TIMEOUT that lets use= rs > Aaron> control how much time is spent attempting each download without ha= ving > Aaron> to rely on ctrl+c. > > I think an environment variable may be too late. I realize gdb doesn't > generally allow interrupting the reading of symbol tables. But, this > case is a little different, in that the main thing happening is the > download of the debug info. Being able to interrupt this would be good, > because servers can wedge, download speeds can be low, etc. Also, maybe > printing something if the download takes too long would be good to do. Ok makes sense. One approach would be for the debuginfod_find_* functions to temporarily install their own SIGINT handler that cancels any downloading. Though during this time ctrl+c won't have the same gdb-wide effect that it currently has. When this happens maybe we could print a message to indicate that the interrupt applied specifically to the downloading. How does this sound to you? Aaron