Re: [PATCH v4] Add debuginfod support to GDB

Aaron Merey
2020-02-24T20:46:11Z

On Mon, Feb 24, 2020 at 3:39 PM Simon Marchi <simark@simark.ca> wrote:
> I just noticed that the debuginfod_debuginfo_query definition is not in sync with
> the declaration, so when we build without debug info support, we get:
>
> CXX debuginfod-support.o
> /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c: In function ‘scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::unique_xmalloc_ptr<char>*)’:
> /home/smarchi/src/binutils-gdb/gdb/debuginfod-support.c:36:1: error: no previous declaration for ‘scoped_fd debuginfod_debuginfo_query(const unsigned char*, int, gdb::unique_xmalloc
> _ptr<char>*)’ [-Werror=missing-declarations]
> debuginfod_debuginfo_query (const unsigned char *build_id __attribute__((unused)),
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> I also think you could remove the __attribute__((unused)). We don't use -Wunused-parameter
> in GDB, and I don't think we plan to (there are a ton of places with unused parameters like
> that, that don't hurt).

Ah ok I will change that on my end, I won't repost the patch over that unless
you'd like me to.

Aaron