From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 69wMIbOhNGjDajUAWB0awg (envelope-from ) for ; Mon, 26 May 2025 13:15:31 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JYuRw6eC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 798EE1E102; Mon, 26 May 2025 13:15:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 857771E102 for ; Mon, 26 May 2025 13:15:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2F96C385C412 for ; Mon, 26 May 2025 17:15:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F96C385C412 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JYuRw6eC Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by sourceware.org (Postfix) with ESMTPS id 503D93858415 for ; Mon, 26 May 2025 17:14:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 503D93858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 503D93858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::743 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748279689; cv=none; b=ESpI2IRF73RWGoNayoerTxjACsMrwWtnvinrv+WDVgQSSGE5rFURUnZVoEPqXgSO34HGcQSs7YNRVt1V9uiPQIbm4dEDItC+JctkaDZ+O6FHYawTo+qMrtibzJXtViyOgudVya+itPDtqqKvo2D43APTylK8AtzgRjbx2qkZLsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748279689; c=relaxed/simple; bh=9NaIb1y1474tr5aV9l/W9QU4+mDGvH1WKgJ3yBwemsI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Bcw3jviQmWfr/c7nLDZanVe8zmlIyikuOx/FmhXh75wyAdHifdtDdsXdu9jzezYm4whZYjagPgdnKB4dKguXlno+iCfi7tb2j37SR1qXajLVwN0FFGyiWtK5Imn814ZPYCc0oVWKFpEYfWYrrRprrljfTTIvxSbMBy1WKKWYr3I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 503D93858415 Received: by mail-qk1-x743.google.com with SMTP id af79cd13be357-7c56a3def84so228453785a.0 for ; Mon, 26 May 2025 10:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748279688; x=1748884488; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5QlOQPOMtGeVO4J3kd2dEl64ebrolzaT+eMLJkpJSso=; b=JYuRw6eC3l1Qyvj+V8J07qfkjLXpSGVozOgJ52u1v4Plzvk/Yrv/M1QSgxk1+rl+cN B00u1u6lXobk750mW6xMfohJrRgxajSUvQ+90Eo8lzJPawBneShk1hPA+2DbwiSd8YIt /5NRVhO7oZI7nJV7Y+bWxbAw81he5fffDlvapB1MQX22u87bX6M6ff8jWXDHOXXyIJ5T 5VYugI30AXKyu4MApmXp+ca8pS+mhUbD+sFFAorDLX275Hs3TnyH1Rz7D09tlGG4wVCz URLHrwfnC/sSVcTrvFEeBYaIIWANpOsu8P0tHw+MM+nUbqear3T7E5lXTYcgq/9RS2I3 8cHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748279688; x=1748884488; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5QlOQPOMtGeVO4J3kd2dEl64ebrolzaT+eMLJkpJSso=; b=oJR4zcNRIZfGn9N+rTfPvKNLFy3qJF+XU+TzySayVV5Votl9/eiKcb2p+2Op7yBwjQ lyI1AyoFmprs+nyq46+0vh0zlOf6fUzztYRXJbezwFtYE+e/hua7zztNPCSbctjCEd/5 LbmLhOhV/ba8bWAbbnCRM96oIglqDO3iFyqek/p3bXbGD7opCx+daT3zCwk73Ku8sTdN XKgjj8XH2fx2Y5U+e6IF+tHU7rUgNhrjX4mM6OJEdvvElx+PuR8yORJJI28oZdb7pcSc biZ0yJRaq8EQyFg135/GFoGOaNv1x9BIxRTBDjHblptsLy/wnUnqLq8kdGHE6yBQfzBM lCAw== X-Gm-Message-State: AOJu0Yzvlo+A288CoOoqcUYh31BpFC4+fduJ88ln9HDfoEW439a8usVZ L2OGOoaL934BywUop0BvFXeF4WgQF6BaJl3ypXAyMW5iIoPDaJHnKxxjvvtnXPtZGrLe+oTkbrq sAprtxAVEtjcYKhKX1R8cwqAhDkUJc+FOA9AhcCE= X-Gm-Gg: ASbGnctgzrlq5v+Sdp/sCYFRQw4mmLASSR17U6ofm5hkiSq++XugI5Shp4xOqeMbRhc NMZEh4CGyVLutkJKHoW2QJeb3AvQk3HclgnHRXRM1TVrZGzkq0+Wwh5CDzagTe1oJRTCm/udMyJ zF+wFZgvbB4+esMMZzfD3pLdnXNXG2ol1d+dUtV+cDc+I= X-Google-Smtp-Source: AGHT+IF280SidARTiAtROfrItRr9K57S9esnUi0IWRxvdJ2/xLgqa8EqVnjgQRkAIx6feA9BambjGvvLUV6mfIqQ954= X-Received: by 2002:a05:620a:2549:b0:7c8:39ea:5166 with SMTP id af79cd13be357-7ceecbf9bf2mr1527921285a.55.1748279688586; Mon, 26 May 2025 10:14:48 -0700 (PDT) MIME-Version: 1.0 References: <20250526151219.399450-1-yodel.eldar@gmail.com> <20250526151219.399450-2-yodel.eldar@gmail.com> <8634crz6xu.fsf@gnu.org> In-Reply-To: <8634crz6xu.fsf@gnu.org> From: Yodel Date: Mon, 26 May 2025 12:14:37 -0500 X-Gm-Features: AX0GCFuxUUKaaxQGsbON4VTi7kJHKJclnXrjVm_6piGJu1HnJ4aNjEtYtjaZQMU Message-ID: Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/alternative; boundary="000000000000ce680c06360d154d" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --000000000000ce680c06360d154d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 26, 2025 at 11:13=E2=80=AFAM Eli Zaretskii wrote= : > > From: Yodel Eldar > > Cc: Yodel Eldar > > Date: Mon, 26 May 2025 10:12:18 -0500 > > > > This commit adds target description support for Alpha. > > > > The target description obviates the alpha_register_type and > > alpha_register_name functions in alpha-tdep.c. Removal of > > alpha_register_reggroup_p was considered but ultimately abandoned, > > because the "info regs" command would no longer omit the zero, fpcr, an= d > > unique registers from its output (they are neither vector nor float > > types). > > > > Register types in the target description annex match the types that the > > alpha_register_type function returned. > > > > The locally defined register_names array was moved out of > > alpha_register_name and renamed to alpha_register_names as a static > > global; calls to alpha_register_name have been replaced with direct > > access of the array. > > > > The patch follows the code pattern outlined in the following GDB > > Internals Wiki entry: > > > > > https://sourceware.org/gdb/wiki/Internals%20Adding-Target-Described-Regis= ter-Support > > --- > > gdb/NEWS | 2 + > > gdb/alpha-tdep.c | 87 ++++++++++++++++++++---------------- > > gdb/doc/gdb.texinfo | 42 ++++++++++++++++++ > > gdb/features/Makefile | 1 + > > gdb/features/alpha-core.xml | 88 +++++++++++++++++++++++++++++++++++++ > > gdb/features/alpha.c | 84 +++++++++++++++++++++++++++++++++++ > > gdb/features/alpha.xml | 11 +++++ > > 7 files changed, 276 insertions(+), 39 deletions(-) > > create mode 100644 gdb/features/alpha-core.xml > > create mode 100644 gdb/features/alpha.c > > create mode 100644 gdb/features/alpha.xml > > Thanks. > > > diff --git a/gdb/NEWS b/gdb/NEWS > > index 2e48a00df5a..099c137a16f 100644 > > --- a/gdb/NEWS > > +++ b/gdb/NEWS > > @@ -195,6 +195,8 @@ qXfer:threads:read > > subsystem to be disabled at configure time, in the form of > > --disable-gdb-compile. > > > > +* The Alpha target now supports target descriptions. > > + > > *** Changes in GDB 16 > > This part is okay. > > > +The @samp{org.gnu.gdb.alpha.core} feature is required for Alpha > targets. It > > ^^ > Two spaces between sentences, please. > > Thanks for pointing that out. It's corrected now. > Reviewed-By: Eli Zaretskii > --000000000000ce680c06360d154d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, May 26, 2025= at 11:13=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Yodel Eldar <yodel.eldar@gmail.com>
> Cc: Yodel Eldar <yodel.eldar@gmail.com>
> Date: Mon, 26 May 2025 10:12:18 -0500
>
> This commit adds target description support for Alpha.
>
> The target description obviates the alpha_register_type and
> alpha_register_name functions in alpha-tdep.c. Removal of
> alpha_register_reggroup_p was considered but ultimately abandoned,
> because the "info regs" command would no longer omit the zer= o, fpcr, and
> unique registers from its output (they are neither vector nor float > types).
>
> Register types in the target description annex match the types that th= e
> alpha_register_type function returned.
>
> The locally defined register_names array was moved out of
> alpha_register_name and renamed to alpha_register_names as a static > global; calls to alpha_register_name have been replaced with direct > access of the array.
>
> The patch follows the code pattern outlined in the following GDB
> Internals Wiki entry:
>
> https://sou= rceware.org/gdb/wiki/Internals%20Adding-Target-Described-Register-Support
> ---
>=C2=A0 gdb/NEWS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 2 +
>=C2=A0 gdb/alpha-tdep.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 87 += +++++++++++++++++++----------------
>=C2=A0 gdb/doc/gdb.texinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 42 ++++++= ++++++++++++
>=C2=A0 gdb/features/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 1 +
>=C2=A0 gdb/features/alpha-core.xml | 88 +++++++++++++++++++++++++++++++= ++++++
>=C2=A0 gdb/features/alpha.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 84 +++++++++++= ++++++++++++++++++++++++
>=C2=A0 gdb/features/alpha.xml=C2=A0 =C2=A0 =C2=A0 | 11 +++++
>=C2=A0 7 files changed, 276 insertions(+), 39 deletions(-)
>=C2=A0 create mode 100644 gdb/features/alpha-core.xml
>=C2=A0 create mode 100644 gdb/features/alpha.c
>=C2=A0 create mode 100644 gdb/features/alpha.xml

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2e48a00df5a..099c137a16f 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -195,6 +195,8 @@ qXfer:threads:read
>=C2=A0 =C2=A0 subsystem to be disabled at configure time, in the form o= f
>=C2=A0 =C2=A0 --disable-gdb-compile.
>=C2=A0
> +* The Alpha target now supports target descriptions.
> +
>=C2=A0 *** Changes in GDB 16

This part is okay.

> +The @samp{org.gnu.gdb.alpha.core} feature is required for Alpha targe= ts. It
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^^
Two spaces between sentences, please.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>
--000000000000ce680c06360d154d--