From: Gary Benson <gbenson@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v2] Indicate batch mode failures by exiting with nonzero status
Date: Fri, 31 Aug 2018 13:30:00 -0000 [thread overview]
Message-ID: <CAHegJiJkYTTbRdXwR+da9Cr+A3unhCtQSNwLbbaO4YPqv4TWFA@mail.gmail.com> (raw)
In-Reply-To: <8736uviosv.fsf@redhat.com>
On 30 August 2018 at 21:26, Sergio Durigan Junior <sergiodj@redhat.com> wrote:
> On Wednesday, August 22 2018, Gary Benson wrote:
>> This patch causes GDB in batch mode to exit with nonzero status
>> if the last command to be executed fails.
>>
>> Changes since version 1:
>> - I've reworked the patch to not use a global variable.
>> - Behaviour has not changed from version 1.
>>
>> Built and regtested on RHEL 7.5 x86_64.
>
> Hey, just to make sure this is reported here: I'm seeing failures when
> running this test on my Fedora 28 x86_64:
>
> FAIL: gdb.base/batch-exit-status.exp: -batch -jslkflsdjlkfjlksdjf: $actual_status == $expect_status
> FAIL: gdb.base/batch-exit-status.exp: -batch -ex "set not-a-thing 4": $actual_status == $expect_status
> FAIL: gdb.base/batch-exit-status.exp: -batch -x /home/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.bad-commands: $actua$
> _status == $expect_status
> FAIL: gdb.base/batch-exit-status.exp: -batch -x /home/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.good-commands -x /ho$
> e/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.bad-commands: $actual_status == $expect_status
> FAIL: gdb.base/batch-exit-status.exp: -batch -x /home/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.good-commands -ex "s$
> t not-a-thing 4": $actual_status == $expect_status
>
> This has also been caught by the BuildBot:
>
> https://sourceware.org/ml/gdb-testers/2018-q3/msg05129.html
> https://sourceware.org/ml/gdb-testers/2018-q3/msg05223.html
>
> Let me know if you need more details.
Yes please! Is it failing on *every* platform? I looked in gdb.log.xz
but there's no output from GDB, only the PASS/FAIL lines. So I don't
really know what to do, I can't reproduce :/
Cheers,
Gary
next prev parent reply other threads:[~2018-08-31 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 10:47 Gary Benson
2018-08-22 14:37 ` Eli Zaretskii
2018-08-23 8:00 ` Gary Benson
2018-08-23 16:37 ` Pedro Alves
2018-08-30 20:26 ` Sergio Durigan Junior
2018-08-31 13:30 ` Gary Benson [this message]
2018-08-31 14:33 ` Tom Tromey
2018-08-31 14:42 ` Pedro Alves
2018-09-03 16:12 ` [PATCH] Fix batch exit status test failure on Fedora 28 Gary Benson
2018-09-04 11:39 ` Pedro Alves
2018-09-04 14:37 ` Gary Benson
2018-08-31 15:38 ` [PATCH v2] Indicate batch mode failures by exiting with nonzero status Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHegJiJkYTTbRdXwR+da9Cr+A3unhCtQSNwLbbaO4YPqv4TWFA@mail.gmail.com \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox