From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45125 invoked by alias); 1 Mar 2019 14:10:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45102 invoked by uid 89); 1 Mar 2019 14:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw1-f68.google.com Received: from mail-yw1-f68.google.com (HELO mail-yw1-f68.google.com) (209.85.161.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Mar 2019 14:10:09 +0000 Received: by mail-yw1-f68.google.com with SMTP id z191so13443713ywa.6 for ; Fri, 01 Mar 2019 06:10:09 -0800 (PST) MIME-Version: 1.0 References: <1550848393-2743-1-git-send-email-gbenson@redhat.com> <87va1b69h1.fsf@tromey.com> In-Reply-To: <87va1b69h1.fsf@tromey.com> From: Gary Benson Date: Fri, 01 Mar 2019 14:10:00 -0000 Message-ID: Subject: Re: [PATCH] Fix coff_start_symtab resource leak found by Coverity To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00008.txt.bz2 Tom Tromey wrote: > >>>>> "Gary" == Gary Benson writes: > > Gary> Hi all, > Gary> This commit fixes a resource leak found by Coverity, where > Gary> coff_start_symtab performs an xstrdup that is now performed > Gary> within start_symtab by buildsym_compunit::buildsym_compunit. > > Gary> Built and regtested on RHEL 7.6 x86_64. > > Gary> Ok to commit? > > Yes, thank you. Thanks, I pushed it. Cheers, Gary