From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16253 invoked by alias); 7 Jul 2014 20:59:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16240 invoked by uid 89); 7 Jul 2014 20:59:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f49.google.com Received: from mail-oa0-f49.google.com (HELO mail-oa0-f49.google.com) (209.85.219.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 07 Jul 2014 20:59:47 +0000 Received: by mail-oa0-f49.google.com with SMTP id i7so5278723oag.36 for ; Mon, 07 Jul 2014 13:59:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=BA7P8tj1goqwLsRs6+CF3/svhx5FGAuewnNfL2UgKpo=; b=BCu7ty56vd9Wq210fMj9EZ4HrDRJGb8MlO1Y1THtHCTKHB+r2wLtDIG9+JGMnhxpeK JujVq0kSPp7NEb+lEWsi7iItZWtb/gs0Ui7aaR/QNkxOFyCarRntHuGKwXjV7dHD6imz 9nNH/dGsS0zamkdJ/WhHe5vVtID5pwBEW1FPWjnB01wXhBIyjMMiQJ+Y//ze79GSZHG+ 5WuEs31vRHXKG/kAMIyAEvac6eqEZ66OULGpm3xXrbQzjl3Q2lG2qb1pnHqH5sHRsI2r dSQbJKxAqcKCpUFBYCqUz/9Z/0TcEItra3tXk9j9yp47AKmo6aYywzUEUwYx9nwadAX3 BK5A== X-Gm-Message-State: ALoCoQkg7hjDrXd+1BGf/+UKq6NvmKeuJJccq8H0iZtkJ7wThGwwnpb48DAw70sbVIlSYxZoxv75 MIME-Version: 1.0 X-Received: by 10.182.66.79 with SMTP id d15mr34256509obt.49.1404766785423; Mon, 07 Jul 2014 13:59:45 -0700 (PDT) Received: by 10.182.144.133 with HTTP; Mon, 7 Jul 2014 13:59:45 -0700 (PDT) In-Reply-To: References: <83oay128ca.fsf@gnu.org> <87ioo7uuqm.fsf@fleche.redhat.com> Date: Mon, 07 Jul 2014 20:59:00 -0000 Message-ID: Subject: Re: [PATCH] Add Frame.read_register to Python API From: Alexander Smundak To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-07/txt/msg00137.txt.bz2 Ping. On Mon, Jun 30, 2014 at 9:22 AM, Alexander Smundak wrote: > Ping > > On Mon, Jun 23, 2014 at 3:46 PM, Alexander Smundak wrote: >> Ping >> >> On Wed, Jun 18, 2014 at 10:18 AM, Alexander Smundak wrote: >>> Ping. >>> >>> On Wed, Jun 11, 2014 at 4:52 PM, Alexander Smundak wrote: >>>>> Alexander> def __init__(self, fobj): >>>>> Alexander> super(InlinedFrameDecorator, self).__init__(fobj) >>>>> Alexander> + self.fobj = fobj >>>>> >>>>> Alexander> def function(self): >>>>> Alexander> - frame = fobj.inferior_frame() >>>>> Alexander> + frame = self.fobj.inferior_frame() >>>>> Alexander> name = str(frame.name()) >>>>> >>>>> I think this is a nice fix but it seems unrelated to the patch at hand. >>>>> >>>>> Alexander> @defun Frame.find_sal () >>>>> Alexander> -Return the frame's symtab and line object. >>>>> Alexander> +Return the frame's @code{gdb.Symtab_and_line} object. >>>>> >>>>> Likewise. >>>> >>>> Should I mail these two as a single patch or as two separate patches? >>>> >>>>> Alexander> + FRAPY_REQUIRE_VALID (self, frame); >>>>> Alexander> + if (!PyArg_ParseTuple (args, "i", ®num)) >>>>> Alexander> + { >>>>> Alexander> + const char *regnum_str; >>>>> Alexander> + PyErr_Clear(); /* Clear PyArg_ParseTuple failure above. */ >>>>> Alexander> + if (PyArg_ParseTuple (args, "s", ®num_str)) >>>>> Alexander> + { >>>>> Alexander> + regnum = user_reg_map_name_to_regnum (get_frame_arch (frame), >>>>> Alexander> + regnum_str, >>>>> Alexander> + strlen (regnum_str)); >>>>> Alexander> + } >>>>> Alexander> + } >>>>> >>>>> I tend to think this would be clearer if the arguments were only parsed >>>>> once and then explicit type checks were applied to the resulting object. >>>> >>>> Did that, and then started doubting whether it is really necessary to read >>>> a register by its (very arch-specific) number. The new version supports >>>> reading the register by the name. Another change is that it now throws >>>> an exception if the name is wrong. >>>> >>>>> Alexander> +# On x86-64, PC is register 16. >>>>> Alexander> +gdb_test "python print ('result = %s' % ((f0.architecture().name() != 'i386:x86-64') or f0.read_register('pc') == f0.read_register(16)))" \ >>>>> Alexander> + "True" \ >>>>> Alexander> + "test Frame.read_register(regnum)" >>>>> >>>>> A test that is arch-specific needs to be conditionalized somehow. >>>> IMHO it's borderline arch-specific -- it is runnable on any platform, >>>> although it will not be testing much on any but x86-64. There hasn't >>>> been any arch-specific tests for Python so far, so I am not sure what to do. >>>> >>>> Here's the new version (style violations have been addressed, too): >>>> >>>> The ability to read registers is needed to use Frame Filter API to >>>> display the frames created by JIT compilers. >>>> >>>> gdb/Changelog >>>> 2014-06-11 Sasha Smundak >>>> >>>> * python/py-frame.c (frapy_read_register): New function. >>>> >>>> 2014-06-11 Sasha Smundak >>>> >>>> * python.texi (Frames in Python): Add read_register description. >>>> >>>> 2014-06-11 Sasha Smundak >>>> >>>> * gdb.python/py-frame.exp: Test Frame.read_register.