From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13650 invoked by alias); 9 Jun 2014 19:15:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13635 invoked by uid 89); 9 Jun 2014 19:15:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f54.google.com Received: from mail-oa0-f54.google.com (HELO mail-oa0-f54.google.com) (209.85.219.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 09 Jun 2014 19:15:28 +0000 Received: by mail-oa0-f54.google.com with SMTP id eb12so3878301oac.27 for ; Mon, 09 Jun 2014 12:15:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=GpvpPhrjcEBYGx61SBvV9VMnh1HXoiZlBc7EFkfF9x8=; b=nKolI5oVRVi8QlX+L3KTb8ZjFBySUAxiCkmY4e2KjfhgeYSpvvmw3cYBx+sTDMJRpQ Gpcd9oqFFwaSpfDScvxdCjVw1Kdj0DI1brQInx3815he9OODaI7BiChyPtJmnK+il9kD S0vOB1W2layX1I/J0pxwCESmiwPkynwg9gz986F/JnQStIenlwTysegLyMB+kjOrM7Ln mc2oNA8wG1F4mK9FTSU2i+JArFWx6d2lN0NE4id/dMSt8Wea6WULAIuP3Qk2md160zAr l3Y25o+/ELlx5qA8lBFn9T5AhqaSUPhTxTUHvKhGlqQgRnCK9AMtGynUsSTqEIr3UEx4 HNXQ== X-Gm-Message-State: ALoCoQk+dvYNAxcSjT6JDPS+S6bT1rdMUXYciCVsmFOJ04mT/cOy7SV8DZ6pCFPRRkKZnmg0uuMY MIME-Version: 1.0 X-Received: by 10.182.63.70 with SMTP id e6mr5127070obs.64.1402341326328; Mon, 09 Jun 2014 12:15:26 -0700 (PDT) Received: by 10.182.144.133 with HTTP; Mon, 9 Jun 2014 12:15:26 -0700 (PDT) Date: Mon, 09 Jun 2014 19:15:00 -0000 Message-ID: Subject: [PATCH] Add Frame.read_register to Python API From: Alexander Smundak To: gdb-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-06/txt/msg00401.txt.bz2 The ability to read registers is needed to use Frame Filter API to display the frames created by JIT compilers. gdb/Changelog 2014-06-09 Sasha Smundak * python/py-frame.c (frapy_read_register): New function. 2014-06-09 Sasha Smundak * python.texi (Writing a Frame Filter): Fix example code. (Frames in Python): Add read_register description. (Frames in Python): Fix reference in find_sal description. 2014-06-09 Sasha Smundak * gdb.python/py-frame.exp: Test Frame.read_register. diff --git a/gdb/NEWS b/gdb/NEWS index 1397e8b..b3b7a22 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,9 @@ *** Changes since GDB 7.7 +* Python Scripting + Access frame registers + * New command line options -D data-directory diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi index 4688783..a7ff162 100644 --- a/gdb/doc/python.texi +++ b/gdb/doc/python.texi @@ -2046,9 +2046,10 @@ class InlinedFrameDecorator(FrameDecorator): def __init__(self, fobj): super(InlinedFrameDecorator, self).__init__(fobj) + self.fobj = fobj def function(self): - frame = fobj.inferior_frame() + frame = self.fobj.inferior_frame() name = str(frame.name()) if frame.type() == gdb.INLINE_FRAME: @@ -3585,10 +3586,16 @@ Return the frame called by this frame. @end defun @defun Frame.find_sal () -Return the frame's symtab and line object. +Return the frame's @code{gdb.Symtab_and_line} object. @xref{Symbol Tables In Python}. @end defun +@defun Frame.read_register (register) +Return the value of @var{register} in this frame. The @var{register} +argument must be a string (e.g., 'rsp' or 'r1'), or a register number. +Returns @code{Gdb.Value} object. +@end defun + @defun Frame.read_var (variable @r{[}, block@r{]}) Return the value of @var{variable} in this frame. If the optional argument @var{block} is provided, search for the variable from that diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c index 77077d3..4375541 100644 --- a/gdb/python/py-frame.c +++ b/gdb/python/py-frame.c @@ -28,6 +28,7 @@ #include "python-internal.h" #include "symfile.h" #include "objfiles.h" +#include "user-regs.h" typedef struct { PyObject_HEAD @@ -235,6 +236,38 @@ frapy_pc (PyObject *self, PyObject *args) return gdb_py_long_from_ulongest (pc); } +/* Implementation of gdb.Frame.read_register (self, register) -> gdb.Value. + Returns the value of a register in this frame. */ +static PyObject * +frapy_read_register (PyObject *self, PyObject *args) +{ + struct frame_info *frame; + volatile struct gdb_exception except; + int regnum = -1; + struct value *val = NULL; + TRY_CATCH (except, RETURN_MASK_ALL) + { + FRAPY_REQUIRE_VALID (self, frame); + if (!PyArg_ParseTuple (args, "i", ®num)) + { + const char *regnum_str; + PyErr_Clear(); /* Clear PyArg_ParseTuple failure above. */ + if (PyArg_ParseTuple (args, "s", ®num_str)) + { + regnum = user_reg_map_name_to_regnum (get_frame_arch (frame), + regnum_str, + strlen (regnum_str)); + } + } + if (regnum >= 0) + { + val = value_of_register (regnum, frame); + } + } + GDB_PY_HANDLE_EXCEPTION (except); + return val ? value_to_value_object (val) : NULL; +} + /* Implementation of gdb.Frame.block (self) -> gdb.Block. Returns the frame's code block. */ @@ -674,6 +707,9 @@ Return the reason why it's not possible to find frames older than this." }, { "pc", frapy_pc, METH_NOARGS, "pc () -> Long.\n\ Return the frame's resume address." }, + { "read_register", frapy_read_register, METH_VARARGS, + "read_register (register) -> gdb.Value\n\ +Return the value of the register in the frame." }, { "block", frapy_block, METH_NOARGS, "block () -> gdb.Block.\n\ Return the frame's code block." }, diff --git a/gdb/testsuite/gdb.python/py-frame.exp b/gdb/testsuite/gdb.python/py-frame.exp index 3517824..9c56d34 100644 --- a/gdb/testsuite/gdb.python/py-frame.exp +++ b/gdb/testsuite/gdb.python/py-frame.exp @@ -94,3 +94,10 @@ gdb_test "python print ('result = %s' % f0.read_var ('variable_which_surely_does gdb_test "python print ('result = %s' % f0.read_var ('a'))" " = 1" "test Frame.read_var - success" gdb_test "python print ('result = %s' % (gdb.selected_frame () == f1))" " = True" "test gdb.selected_frame" + +# Can read SP register +gdb_test "python print ('result = %s' % f0.read_register('sp'))" " = 0x\[0-9a-fA-F\]+" "test Frame.read_register(fp)" +# PC value obtained via read_register is as expected +gdb_test "python print ('result = %s' % (f0.read_register('pc').cast(gdb.lookup_type('unsigned long')) == f0.pc()))" "True" "test Frame.read_register(pc)" +# On x86-64, PC is register 16. +gdb_test "python print ('result = %s' % ((f0.architecture().name() != 'i386:x86-64') or f0.read_register('pc') == f0.read_register(16)))" "True" "test Frame.read_register(regnum)"