From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11860 invoked by alias); 20 Dec 2011 16:12:52 -0000 Received: (qmail 11839 invoked by uid 22791); 20 Dec 2011 16:12:51 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Dec 2011 16:12:35 +0000 Received: by iacb35 with SMTP id b35so10231347iac.0 for ; Tue, 20 Dec 2011 08:12:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.42.163.200 with SMTP id d8mr2270055icy.41.1324397555009; Tue, 20 Dec 2011 08:12:35 -0800 (PST) Received: by 10.50.10.129 with HTTP; Tue, 20 Dec 2011 08:12:34 -0800 (PST) In-Reply-To: References: <1322492788-29388-1-git-send-email-andrew.smirnov@gmail.com> Date: Tue, 20 Dec 2011 16:13:00 -0000 Message-ID: Subject: Re: [PATCH 022/238] [misc.] bcache.c: -Wshadow fix. From: Andrey Smirnov To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00681.txt.bz2 On Tue, Dec 20, 2011 at 7:41 AM, Tom Tromey wrote: >>>>>> "Andrey" =3D=3D Andrey Smirnov writes: > > Andrey> =A0 =A0 =A0 =A0 * bcache.c (expand_hash_table): Rename `bcache' t= o `cache'(-Wshadow). > > Ok. > Thanks for reviewing the patch. I think I'm going to postpone applying it, since that what I told Joel I would do. > For the record, I am approving the ones I think are useful. > I still think that the best course is to use -Wshadow in conjunction > with a newer GCC; and to implement configury to check for this GCC > feature. I washed my hands of the issue, so I won't be sending patches implementing said configury or any code to that effect anytime soon, but I think that statement for the record will probably get lost among all the messages on -Wshadow topic, and you're going to have to repeat yourself once the issue is brought up again in the future :) Andrey Smirnov