Re: [PATCH 022/238] [misc.] bcache.c: -Wshadow fix.

Andrey Smirnov
2011-12-20T16:12:52Z

On Tue, Dec 20, 2011 at 7:41 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Andrey" == Andrey Smirnov <andrew.smirnov@gmail.com> writes:
>
> Andrey>         * bcache.c (expand_hash_table): Rename `bcache' to `cache'(-Wshadow).
>
> Ok.
>

Thanks for reviewing the patch. I think I'm going to postpone applying
it, since that what I told Joel I would do.

> For the record, I am approving the ones I think are useful.
> I still think that the best course is to use -Wshadow in conjunction
> with a newer GCC; and to implement configury to check for this GCC
> feature.

I washed my hands of the issue, so I won't be sending patches
implementing said configury or any code to that effect anytime soon, but
I think that statement for the record will probably get lost among all
the messages on -Wshadow topic, and you're going to have to repeat
yourself once the issue is brought up again in the future :)

Andrey Smirnov