From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16070 invoked by alias); 24 Nov 2011 03:18:52 -0000 Received: (qmail 16062 invoked by uid 22791); 24 Nov 2011 03:18:51 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f169.google.com (HELO mail-iy0-f169.google.com) (209.85.210.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Nov 2011 03:18:35 +0000 Received: by iaek3 with SMTP id k3so3275371iae.0 for ; Wed, 23 Nov 2011 19:18:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.29.137 with SMTP id q9mr7110050ibc.27.1322104714627; Wed, 23 Nov 2011 19:18:34 -0800 (PST) Received: by 10.50.186.228 with HTTP; Wed, 23 Nov 2011 19:18:34 -0800 (PST) In-Reply-To: References: <878vn88fw3.fsf@gmail.com> <4ECBA525.1010801@redhat.com> <201111221027.52484.vapier@gentoo.org> Date: Thu, 24 Nov 2011 03:18:00 -0000 Message-ID: Subject: Re: [PATCH 22/348] Fix -Wsahdow warnings From: Andrey Smirnov To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00668.txt.bz2 On Thu, Nov 24, 2011 at 12:06 AM, Tom Tromey wrote: >>>>>> "Andrey" =3D=3D Andrey Smirnov writes: > > Andrey> Initially, there were 17 patches, which, upon suggestion from Tom > Andrey> Tromey, I split so that every patch contain only changes to one > Andrey> particular function or some other small unit of the source code. I > Andrey> tend to agree with Tom that my initial decision to make only 17 > Andrey> patches made it rather hard to review each, because every one of = them > Andrey> contained many small but disparate changes. > > I didn't really mean for you to split it down this much, but now you've > done it. =A0I don't want to make too much extra work for you. Et tu, Brute? :) I'll try to condense the patches. > Andrey> Squashing or splitting commits is not really a problem and I can = do > Andrey> this, but if you want me to do so, than please point out the patc= hes > Andrey> I should squash together. > > It is hard for us to do that without seeing the whole series :) Well, this problem can be solved quite easily. As soon as I'm done with ChangeLogs I can create a repo on github and all the changes would be accessible to anyone. > Conversely maybe it is hard for you to know which patches are likely to > be controversial and which are obvious. > > I think it is hard to discuss in the abstract. =A0One idea would be for > you to merge reasonably obvious patches together in a file-based way, > using your best judgment about what "reasonably obvious" means. > > Or, we can just carry on. > > Andrey> So given the aforementioned amount of work, can't we ignore that = the > Andrey> patch count is over 9000? > > Not sure what this refers to. > Internet memes, Dragon Ball Z. Sorry about that. Rephrased the sentence would be: "So given the aforementioned amount of work, can't we ignore that the patch count is very large?" Andrey Smirnov